mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-31 22:35:10 +00:00
Code Issues Releases Wiki Activity

Oflow test of nmemb > SIZE_MAX / size is fine (don't need >=).

Browse Source 
Use memcpy() instead of strcpy() in estrdup() so this is strcpy()-free.
This commit is contained in:
Todd C. Miller
2003-03-13 17:00:31 +00:00
parent 96376b6d4e
commit 5b40c964de
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
alloc.c
View File

@@ -115,7 +115,7 @@ emalloc2(nmemb, size)
Argv[0]);
exit(1);
}
if (nmemb >= SIZE_MAX / size) {
if (nmemb > SIZE_MAX / size) {
(void) fprintf(stderr, "%s: internal error, emalloc2() overflow\n",
Argv[0]);
exit(1);
@@ -170,7 +170,7 @@ erealloc3(ptr, nmemb, size)
Argv[0]);
exit(1);
}
if (nmemb >= SIZE_MAX / size) {
if (nmemb > SIZE_MAX / size) {
(void) fprintf(stderr, "%s: internal error, erealloc3() overflow\n",
Argv[0]);
exit(1);
@@ -193,10 +193,12 @@ estrdup(src)
const char *src;
{
char *dst = NULL;
size_t size;
if (src != NULL) {
dst = (char *) emalloc(strlen(src) + 1);
(void) strcpy(dst, src);
size = strlen(src) + 1;
dst = (char *) emalloc(size);
(void) memcpy(dst, src, size);
}
return(dst);
}