mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-09-04 08:15:15 +00:00
Code Issues Releases Wiki Activity

Fix newly introduced use after frees found by llvm checker.

Browse Source
This commit is contained in:
Todd C. Miller
2013-10-22 10:43:15 -06:00
parent b2cba83688
commit 798e82bd61
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/sudoers/defaults.c
View File

@@ -826,15 +826,15 @@ store_mode(char *val, struct sudo_defs_types *def, int op)
static void static void
list_op(char *val, size_t len, struct sudo_defs_types *def, enum list_ops op) list_op(char *val, size_t len, struct sudo_defs_types *def, enum list_ops op)
{ {
struct list_member *tmp, *cur, *prev = NULL; struct list_member *cur, *prev = NULL;
debug_decl(list_op, SUDO_DEBUG_DEFAULTS) debug_decl(list_op, SUDO_DEBUG_DEFAULTS)
if (op == freeall) { if (op == freeall) {
SLIST_FOREACH_SAFE(cur, &def->sd_un.list, entries, tmp) { while ((cur = SLIST_FIRST(&def->sd_un.list)) != NULL) {
efree(tmp->value); SLIST_REMOVE_HEAD(&def->sd_un.list, entries);
efree(tmp); efree(cur->value);
efree(cur);
} }
SLIST_INIT(&def->sd_un.list);
debug_return; debug_return;
} }