mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-09-02 15:25:58 +00:00
Code Issues Releases Wiki Activity

malloc() sets errno to ENOMEM on failure so we don't need to set

Browse Source 
it explicitly.
This commit is contained in:
Todd C. Miller
2015-06-20 19:26:43 -06:00
parent f6627e70b0
commit 887a76489a
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/sudoers/env.c
View File

@@ -307,10 +307,8 @@ sudo_putenv_nodebug(char *str, bool dupcheck, bool overwrite)
return -1; return -1;
} }
nenvp = reallocarray(env.envp, nsize, sizeof(char *)); nenvp = reallocarray(env.envp, nsize, sizeof(char *));
if (nenvp == NULL) { if (nenvp == NULL)
errno = ENOMEM;
return -1; return -1;
}
env.envp = nenvp; env.envp = nenvp;
env.env_size = nsize; env.env_size = nsize;
#ifdef ENV_DEBUG #ifdef ENV_DEBUG
@@ -453,10 +451,8 @@ sudo_setenv_nodebug(const char *var, const char *val, int overwrite)
} }
/* Allocate and fill in estring. */ /* Allocate and fill in estring. */
if ((estring = ep = malloc(esize)) == NULL) { if ((estring = ep = malloc(esize)) == NULL)
errno = ENOMEM;
goto done; goto done;
}
for (cp = var; *cp && *cp != '='; cp++) for (cp = var; *cp && *cp != '='; cp++)
*ep++ = *cp; *ep++ = *cp;
*ep++ = '='; *ep++ = '=';