mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-31 14:25:15 +00:00
Code Issues Releases Wiki Activity

Got back to calling alias_free() on alias_add() failure.

Browse Source 
We now need to remove the name and members from the leak list
*before* calling alias_add() since alias_add() will consume them
for both success and failure.
This commit is contained in:
Todd C. Miller
2021-02-02 14:40:37 -07:00
parent 8f2254594f
commit bdb02b1eff
3 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/sudoers/alias.c
View File

@@ -136,11 +136,11 @@ alias_add(struct sudoers_parse_tree *parse_tree, char *name, int type,
HLTQ_TO_TAILQ(&a->members, members, entries);
switch (rbinsert(parse_tree->aliases, a, NULL)) {
case 1:
free(a);
alias_free(a);
errno = EEXIST;
debug_return_bool(false);
case -1:
free(a);
alias_free(a);
debug_return_bool(false);
}
debug_return_bool(true);