mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-09-02 23:35:36 +00:00
Code Issues Releases Wiki Activity

set_cmnd_path: apply runchroot if set when finding the command path

Browse Source 
Previously we would prepend runchroot to the path we were checking
but that does not properly handle symbolic links.
This commit is contained in:
Todd C. Miller
2023-02-21 13:24:33 -07:00
parent 13a311bc71
commit bff4e3ce16
7 changed files with 31 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/sudoers/goodpath.c
View File

@@ -39,24 +39,13 @@
* Verify that path is a normal file and executable by root.
*/
bool
sudo_goodpath(const char *path, const char *runchroot, struct stat *sbp)
sudo_goodpath(const char *path, struct stat *sbp)
{
bool ret = false;
struct stat sb;
debug_decl(sudo_goodpath, SUDOERS_DEBUG_UTIL);
if (path != NULL) {
char pathbuf[PATH_MAX];
struct stat sb;
if (runchroot != NULL) {
const int len =
snprintf(pathbuf, sizeof(pathbuf), "%s%s", runchroot, path);
if (len >= ssizeof(pathbuf)) {
errno = ENAMETOOLONG;
goto done;
}
path = pathbuf; // -V507
}
if (sbp == NULL)
sbp = &sb;
@@ -68,6 +57,5 @@ sudo_goodpath(const char *path, const char *runchroot, struct stat *sbp)
errno = EACCES;
}
}
done:
debug_return_bool(ret);
}