mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-31 14:25:15 +00:00
Code Issues Releases Wiki Activity

setenv(3) in Linux treats a NUL value as the empty string

Browse Source 
setenv(3) in BSD doesn't return an error if the name has '=' in it, it
just treats the '=' as end of string.
This commit is contained in:
Todd C. Miller
2009-04-24 18:53:15 +00:00
parent 182711e341
commit c0c7180bba
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
env.c
View File

@@ -250,23 +250,27 @@ setenv(var, val, overwrite)
int overwrite; int overwrite;
{ {
char *estring; char *estring;
const char *varend;
size_t esize; size_t esize;
int len;
if (strchr(var, '=') != NULL) { /*
errno = EINVAL; * POSIX says a var name with '=' is an error but BSD
return(-1); * just ignores the '=' and anything after it.
} */
for (varend = var; *varend && *varend != '='; varend++)
;
esize = strlen(var) + 1 + strlen(val) + 1; if (val == NULL)
val = ""; /* glibc treats a NULL val as "" */
esize = (size_t)(varend - var) + 1 + strlen(val) + 1;
estring = emalloc(esize); estring = emalloc(esize);
/* Build environment string and insert it. */ len = snprintf(estring, esize, "%.*s=%s", (int)(varend - var), var, val);
if (strlcpy(estring, var, esize) >= esize || if (len < 0 && len >= esize)
strlcat(estring, "=", esize) >= esize ||
strlcat(estring, val, esize) >= esize) {
errorx(1, "internal error, setenv() overflow"); errorx(1, "internal error, setenv() overflow");
}
/* Sync env.envp with environ as needed. */ /* Sync env.envp with environ as needed. */
if (env.envp != environ) { if (env.envp != environ) {
char **ep; char **ep;