mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-29 21:38:05 +00:00
Code Issues Releases Wiki Activity

No need to check whether the fd we opened is really a directory in

Browse Source 
sudo_edit_open_nonwritable() since if not, the openat() will fail
with ENOTDIR anyway.
This commit is contained in:
Todd C. Miller 2016-01-11 11:15:42 -07:00
parent 68c1073fe5
commit c7c80913ef
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/sudo_edit.c
View File

@ -364,13 +364,7 @@ restart:
#endif #endif
debug_return_int(-1); debug_return_int(-1);
} }
#ifndef O_DIRECTORY
if (!S_ISDIR(sb.st_mode)) {
close(dfd);
errno = ENOTDIR;
debug_return_int(-1);
}
#endif
is_writable = dir_is_writable(&sb, user_details.uid, user_details.gid, is_writable = dir_is_writable(&sb, user_details.uid, user_details.gid,
user_details.ngroups, user_details.groups); user_details.ngroups, user_details.groups);