mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-22 01:49:11 +00:00
Code Issues Releases Wiki Activity

Quiet a PVS Studio warning.

Browse Source 
The warning that need_comma is always false is correct but in this
case it is better to use a consistent construct so that if the code
is re-ordered no bugs are introduced.
This commit is contained in:
Todd C. Miller 2021-11-20 09:40:06 -07:00
parent dc5ac7424b
commit d83321388d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/sudoers/cvtsudoers_csv.c
View File

@ -456,7 +456,7 @@ print_cmndspec_csv(FILE *fp, struct sudoers_parse_tree *parse_tree,
if (len == 0 || timebuf[sizeof(timebuf) - 1] != '\0') {
sudo_warnx("%s", U_("unable to format timestamp"));
} else {
fprintf(fp, "%snotbefore=%s", need_comma ? "," : "", timebuf);
fprintf(fp, "%snotbefore=%s", need_comma ? "," : "", timebuf); // -V547
need_comma = true;
}
}