mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-09-04 08:15:15 +00:00
Code Issues Releases Wiki Activity

plugins/python/python_plugin_approval: fix negative ref count

Browse Source 
The python_plugin_api_rc_call function already decrements the
refcount of py_args.
Python avoids the double free, but the error gets shown if using python
debug build.
This commit is contained in:
Robert Manner
2020-02-13 10:31:46 +01:00
committed by Todd C. Miller
parent a71828b385
commit efa97b5b97
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/python/python_plugin_approval.c
View File

@@ -131,10 +131,10 @@ python_plugin_approval_check(struct ApprovalPluginContext *approval_ctx,
py_args = Py_BuildValue("(OOO)", py_command_info, py_run_argv, py_run_envp); py_args = Py_BuildValue("(OOO)", py_command_info, py_run_argv, py_run_envp);
} }
// Note, py_args gets cleared by api_rc_call
rc = python_plugin_api_rc_call(plugin_ctx, CALLBACK_PYNAME(check), py_args); rc = python_plugin_api_rc_call(plugin_ctx, CALLBACK_PYNAME(check), py_args);
CALLBACK_SET_ERROR(plugin_ctx, errstr); CALLBACK_SET_ERROR(plugin_ctx, errstr);
Py_CLEAR(py_args);
Py_CLEAR(py_command_info); Py_CLEAR(py_command_info);
Py_CLEAR(py_run_argv); Py_CLEAR(py_run_argv);
Py_CLEAR(py_run_envp); Py_CLEAR(py_run_envp);