mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-22 01:49:11 +00:00
Code Issues Releases Wiki Activity

revoke_pty: use killpg() not kill() to send HUP to the process group

Browse Source 
Also make sure we never call killpg(-1, SIGHUP), which would send
SIGHUP to process 1 (init).  It is possible for cmnd_pid to be -1
in certain error conditions where sudo killed the command itself.
This may explain GitHub issue #458.
This commit is contained in:
Todd C. Miller 2025-07-14 16:55:34 -06:00
parent e5d953f339
commit fb208d383a
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/exec_pty.c
View File

@ -358,9 +358,11 @@ revoke_pty(struct exec_closure *ec)
pgrp = tcpgrp; pgrp = tcpgrp;
close(io_fds[SFD_LEADER]); close(io_fds[SFD_LEADER]);
} }
sudo_debug_printf(SUDO_DEBUG_NOTICE, "%s: killpg(%d, SIGHUP)", if (pgrp != -1) {
__func__, (int)pgrp); sudo_debug_printf(SUDO_DEBUG_NOTICE, "%s: killpg(%d, SIGHUP)",
kill(pgrp, SIGHUP); __func__, (int)pgrp);
killpg(pgrp, SIGHUP);
}
} }
/* /*