mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-29 13:28:10 +00:00
Code Issues Releases Wiki Activity
9,108 Commits 6 Branches 326 Tags
Commit Graph

9108 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Todd C. Miller
fa2ab63da9 Stop looking for an editor as soon as we find one. 
A similar fix was made to visudo some time ago.
 2017-12-21 16:31:42 -07:00
Todd C. Miller
740a479806 The session ID was added in 1.8.6p7 to prevent a user in another 
session from re-using the time stamp file.
Other minor cleanups.
 2017-12-21 14:37:13 -07:00
Todd C. Miller
54158f6918 "time stamp" not "timestamp" 2017-12-21 14:21:48 -07:00
Todd C. Miller
feb48b8ebf Add "kernel" as a possible value of timestamp_type. 
Currently only supported on OpenBSD.
 2017-12-20 16:19:54 -07:00
Todd C. Miller
5f3797c754 Document the sudoers time stamp file format. 2017-12-20 13:01:06 -07:00
Todd C. Miller
ae8917a070 Verify start time of the current process, allowing for some clock 
drift.  For Linux, process start time is relative to boot time, not
wallclock time.
 2017-12-19 10:10:54 -07:00
Todd C. Miller
f41927488b sync 2017-12-18 11:34:59 -07:00
Todd C. Miller
e73a5574ce regen 2017-12-18 10:52:45 -07:00
Todd C. Miller
6ce85b1746 Trivial test for process start time. We don't try to check the 
resulting timespec as it differs by platform.  On most it is wallclock
time, on others it is relative to boot time (Linux).
 2017-12-18 10:35:37 -07:00
Todd C. Miller
d93559e9c0 regen 2017-12-18 09:39:06 -07:00
Todd C. Miller
de2f455d3e Support start time on macOS and 4.4BSD 2017-12-17 07:40:21 -07:00
Todd C. Miller
428a487e0b Include sys/types.h for mode_t used in sudoers.h. 2017-12-16 20:55:01 -07:00
Todd C. Miller
b78296197d Fix compilation error on FreeBSD 2017-12-16 20:46:58 -07:00
Todd C. Miller
79caf1e68d Fix debug_decl(), it should be SUDOERS_DEBUG_UTIL 
Add debugging for the successful case
For Linux, don't NUL out *ep before parsing with strtoull().
* * *
Add missing debug info for the System V /proc version.
 2017-12-16 14:50:14 -07:00
Todd C. Miller
1709dc7f77 In the timestamp record, include the start time of the terminal 
session leader for tty-based timestamps or the start time of the
parent process for ppid-based timestamps.  Idea from Duncan Overbruck.
 2017-12-16 05:53:05 -07:00
Todd C. Miller
5cec5734cc If the lock record doesn't match the expected record size we need 
to seek to the end of the record as we otherwise may have gone too
far (or not far enough).  Fixes interop problems when the time stamp
record changes size.
 2017-12-15 21:08:38 -07:00
Todd C. Miller
cd0b700543 No need for a loop around the recv() now that we don't have to worry 
about EINTR.  CID 180697
 2017-12-12 21:44:23 -07:00
Todd C. Miller
bda2f4c441 Try to be clearer about sudo's exit value when the -l option is used. 2017-12-12 15:42:21 -07:00
Todd C. Miller
3604ff5bb2 sync 2017-12-12 15:13:52 -07:00
Todd C. Miller
6ca8447e00 An empty RunAsUser means run as the invoking user, similar to how 
the sudoers files works.
 2017-12-12 14:20:56 -07:00
Todd C. Miller
f869086eff regen 2017-12-12 14:19:13 -07:00
Todd C. Miller
1350a30737 Add authfail_message sudoers option to allow the user to override 
the default message of %d incorrect password attempt(s).
 2017-12-11 12:43:58 -07:00
Todd C. Miller
5106bfc139 Allow the plugin to determine whether or not an empty timeout is 
allowed.  For sudoers, an error will be returned for an empty timeout.
 2017-12-11 09:20:41 -07:00
Todd C. Miller
b5463c2809 Return an error for an empty timeout string. Just use strtol() for 
syntax checking instead of scanning with strspn().
 2017-12-11 09:19:42 -07:00
Todd C. Miller
bbc43b5e30 Change some _() into U_() since they are used for warn/fatal. 
We always want to issue warnings in the user's locale.
 2017-12-11 08:07:01 -07:00
Todd C. Miller
b68554b7cf update my email address 2017-12-11 06:02:52 -07:00
Todd C. Miller
3d13fe4fae Don't print mercurial branch info for merges. 2017-12-10 19:45:52 -07:00
Todd C. Miller
a388ddbcf5 Use log size instead of using a separator between the log entry and 
the file names.
 2017-12-10 13:39:41 -07:00
Todd C. Miller
d322caf7ac Print usage and return an error when an empty argument is given for 
all command line arguments other than -p and -E.  Bug #817
 2017-12-10 07:53:09 -07:00
Todd C. Miller
00a00ebd1d Better input validation of settings passed by the sudo front-end. 
Instead of ignoring an empty setting, throw an error.
 2017-12-10 07:45:49 -07:00
Todd C. Miller
63209fe8f7 Treat a blank line in a commit message as a line break. There 
doesn't appear to be a way to make perl's format use a blank field
but at least the line break happens now.
 2017-12-10 05:56:22 -07:00
Todd C. Miller
5f5a60f822 Add script to generate ChangeLog from git log output. 2017-12-09 20:40:28 -07:00
Todd C. Miller
b16912da1d Don't include syslog.h from logging.h, just include it in the two 
.c files it is actually needed.
 2017-12-08 15:00:41 -07:00
Todd C. Miller
e78283af99 Document that in check mode, visudo does not check the owner/mode 
on files specified with the -f flag.
 2017-12-06 10:17:33 -07:00
Todd C. Miller
48fba3c2cc update my email to Todd.Miller@sudo.ws 2017-12-03 17:53:40 -07:00
Todd C. Miller
01587b1b14 Add missing carriage return before prompt when replay is done. 2017-12-02 21:32:24 -07:00
Todd C. Miller
a2eff11509 Track window size changes that happen while sudo is suspended 2017-12-02 21:30:11 -07:00
Todd C. Miller
988328393a regen 2017-12-01 15:43:04 -07:00
Todd C. Miller
276d83cc98 regen for sudo 1.8.22 2017-12-01 14:37:16 -07:00
Todd C. Miller
e8532bdcee Sudo 1.8.22 2017-12-01 14:35:34 -07:00
Todd C. Miller
c2eee7904d Background processes started by the command will no longer receive 
SIGHUP.
 2017-12-01 13:53:09 -07:00
Todd C. Miller
b561d0d7dd When the command completes, make the monitor the foreground process 
group before informing the main sudo process of the command's exit
status.  This will prevent processes started by the command (which
runs in a different process group) from receiving SIGHUP since the
kernel sends SIGHUP to the foreground process group associated with
the terminal session.  The monitor has a SIGHUP handler installed
so the signal is effectively ignored.
 2017-12-01 13:43:06 -07:00
Todd C. Miller
4168668f53 Add debug printfs around group list retrieval. 2017-12-01 12:58:37 -07:00
Todd C. Miller
116c5d7eff Move call to sudo_ev_loopcontinue() into schedule_signal() itself. 
We always want to prioritize signal forwarding.
 2017-11-30 10:02:15 -07:00
Todd C. Miller
b9adb3dd51 Don't loop over read/write, recv/send or tcgetpgrp/tcsetpgrp trying 
to handle EINTR.  We now use SA_RESTART with signals so this is not
needed and is potentially dangerous if it is possible to receive
SIGTTIN or SIGTTOU (which it currently is not).
 2017-11-30 09:53:21 -07:00
Todd C. Miller
9298a2a42e Better describe things when a command is run in a pty. 2017-11-21 16:59:54 -07:00
Todd C. Miller
486ced7c11 Sprinkle some extra debugging printfs 2017-11-29 13:13:33 -07:00
Todd C. Miller
54acf4f991 Handle receipt of SIGTTIN/SIGTTOU when reading/writing from/to the tty. 
We can't use a signal event for these since that would restart the
system call after the signal was handled and the callback would not
get a chance to run.  Fixes running a command in the background that
write to the tty when the TOSTOP terminal flag is set.
 2017-11-29 12:06:12 -07:00
Todd C. Miller
5ccc7ab879 We don't need to be the foreground process to be able to write to 
the terminal in most cases.  If the background process tries to
modify the terminal flags it will receive SIGTTOU which is relayed
to the sudo front-end.  This currently mishandles terminals with
the TOSTOP local flag set.
 2017-11-29 12:06:12 -07:00
Todd C. Miller
93828eca65 Avoid a double free when ipa_hostname is set in sssd.conf and it 
is an unqualified host name.  From Daniel Kopecek.

Also move the "unable to allocate memory" warning into get_ipa_hostname()
itself to make it easier to see where the allocation failed in the
debug log.
 2017-11-28 11:28:44 -07:00