mir/tdesktop
2
0
Fork 0
mirror of https://github.com/telegramdesktop/tdesktop synced 2025-09-01 06:55:58 +00:00
Code Issues Releases Wiki Activity

QtLottie: Fix UB in last keyframe easing point.

Browse Source 
Example: https://lottiefiles.com/427-happy-birthday

The present box top was rendered below the body or not depending on
the uninitialized bytes from QBezier.
This commit is contained in:
John Preston
2019-04-29 19:08:00 +04:00
parent f073963582
commit 2fae2278f7
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Telegram/ThirdParty/qtlottie vendored

Submodule Telegram/ThirdParty/qtlottie updated: 553ec1bc79...92c5c182fd

11
Telegram/ThirdParty/qtlottie_helper/QtBodymovin/private/bmspatialproperty_p.h vendored
View File

@@ -112,9 +112,14 @@ public:
int adjustedFrame = qBound(m_startFrame, frame, m_endFrame); int adjustedFrame = qBound(m_startFrame, frame, m_endFrame);
if (const EasingSegment<QPointF> *easing = getEasingSegment(adjustedFrame)) { if (const EasingSegment<QPointF> *easing = getEasingSegment(adjustedFrame)) {
qreal progress = ((adjustedFrame - m_startFrame) * 1.0) / (m_endFrame - m_startFrame); if (easing->complete) {
qreal easedValue = easing->easing.valueForProgress(progress); qreal progress = ((adjustedFrame - m_startFrame) * 1.0) / (m_endFrame - m_startFrame);
m_value = m_bezierPath.pointAtPercent(easedValue); qreal easedValue = easing->easing.valueForProgress(progress);
m_value = m_bezierPath.pointAtPercent(easedValue);
} else {
// In case of incomplete easing we should just take the final point.
m_value = m_bezierPath.pointAtPercent(1.);
}
} }
return true; return true;