mir/tdesktop
2
0
Fork 0
mirror of https://github.com/telegramdesktop/tdesktop synced 2025-08-31 06:26:18 +00:00
Code Issues Releases Wiki Activity

Fix -Wredundant-move and -Wdeprecated-copy warnings (#6663)

Browse Source 
* Do not move result at end of function

This makes GCC 9.1.2 happy with the active -Wredundant-move warning.
Indeed, such moving of local variables or local arguments before
returning is unnecessary and prevents the compiler from copy elision
optimization.
This commit is contained in:
Nicholas Guriev
2019-11-12 18:15:34 +03:00
committed by John Preston
parent a196b0aba7
commit 793862bee6
34 changed files with 60 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Telegram/SourceFiles/settings/settings_privacy_security.cpp
View File

@@ -525,7 +525,7 @@ object_ptr<Ui::BoxContent> EditCloudPasswordBox(not_null<Main::Session*> session
session->api().clearUnconfirmedPassword();
}, box->lifetime());
return std::move(result);
return result;
}
void RemoveCloudPassword(not_null<::Main::Session*> session) {
@@ -565,7 +565,7 @@ object_ptr<Ui::BoxContent> CloudPasswordAppOutdatedBox() {
tr::lng_menu_update(tr::now),
callback);
*box = result.data();
return std::move(result);
return result;
}
void AddPrivacyButton(