Fix crash in session destruction.

Also use rpl::event_stream for downloaderTaskFinished.

Telegram/SourceFiles/chat_helpers/field_autocomplete.cpp

@@ -604,9 +604,10 @@ FieldAutocompleteInner::FieldAutocompleteInner(
 , _brows(brows)
 , _srows(srows)
 , _previewTimer([=] { showPreview(); }) {
-	subscribe(
-		controller->session().downloaderTaskFinished(),
-		[=] { update(); });
+	controller->session().downloaderTaskFinished(
+	) | rpl::start_with_next([=] {
+		update();
+	}, lifetime());
 }
 
 void FieldAutocompleteInner::paintEvent(QPaintEvent *e) {

Telegram/SourceFiles/chat_helpers/gifs_list_widget.cpp

@@ -153,9 +153,10 @@ GifsListWidget::GifsListWidget(
 		refreshSavedGifs();
 	}, lifetime());
 
-	subscribe(controller->session().downloaderTaskFinished(), [this] {
+	controller->session().downloaderTaskFinished(
+	) | rpl::start_with_next([=] {
 		update();
-	});
+	}, lifetime());
 
 	subscribe(controller->gifPauseLevelChanged(), [=] {
 		if (!controller->isGifPausedAtLeastFor(

Telegram/SourceFiles/chat_helpers/stickers_emoji_pack.cpp

@@ -198,7 +198,7 @@ std::shared_ptr<LargeEmojiImage> EmojiPack::image(EmojiPtr emoji) {
 						if (!strong->image) {
 							strong->load = nullptr;
 							strong->image.emplace(std::move(image));
-							_session->downloaderTaskFinished().notify();
+							_session->notifyDownloaderTaskFinished();
 						}
 					}
 				}

Telegram/SourceFiles/chat_helpers/stickers_list_widget.cpp

@@ -105,9 +105,7 @@ struct StickerIcon {
 
 };
 
-class StickersListWidget::Footer
-	: public TabbedSelector::InnerFooter
-	, private base::Subscriber {
+class StickersListWidget::Footer : public TabbedSelector::InnerFooter {
 public:
 	explicit Footer(not_null<StickersListWidget*> parent);
 
@@ -132,7 +130,7 @@ protected:
 	void mousePressEvent(QMouseEvent *e) override;
 	void mouseMoveEvent(QMouseEvent *e) override;
 	void mouseReleaseEvent(QMouseEvent *e) override;
-	bool event(QEvent *e) override;
+	bool eventHook(QEvent *e) override;
 
 	void processHideFinished() override;
 
@@ -249,9 +247,10 @@ StickersListWidget::Footer::Footer(not_null<StickersListWidget*> parent)
 
 	_iconsLeft = _iconsRight = st::emojiCategorySkip + st::stickerIconWidth;
 
-	subscribe(_pan->session().downloaderTaskFinished(), [=] {
+	_pan->session().downloaderTaskFinished(
+	) | rpl::start_with_next([=] {
 		update();
-	});
+	}, lifetime());
 }
 
 void StickersListWidget::Footer::clearHeavyData() {
@@ -600,7 +599,7 @@ void StickersListWidget::Footer::finishDragging() {
 	updateSelected();
 }
 
-bool StickersListWidget::Footer::event(QEvent *e) {
+bool StickersListWidget::Footer::eventHook(QEvent *e) {
 	if (e->type() == QEvent::TouchBegin) {
 	} else if (e->type() == QEvent::Wheel) {
 		if (!_icons.empty()
@@ -609,7 +608,7 @@ bool StickersListWidget::Footer::event(QEvent *e) {
 			scrollByWheelEvent(static_cast<QWheelEvent*>(e));
 		}
 	}
-	return InnerFooter::event(e);
+	return InnerFooter::eventHook(e);
 }
 
 void StickersListWidget::Footer::scrollByWheelEvent(
@@ -890,12 +889,13 @@ StickersListWidget::StickersListWidget(
 			Box<StickersBox>(controller, StickersBox::Section::Installed));
 	});
 
-	subscribe(session().downloaderTaskFinished(), [=] {
+	session().downloaderTaskFinished(
+	) | rpl::start_with_next([=] {
 		if (isVisible()) {
 			update();
 			readVisibleFeatured(getVisibleTop(), getVisibleBottom());
 		}
-	});
+	}, lifetime());
 
 	session().changes().peerUpdates(
 		Data::PeerUpdate::Flag::StickersSet

Telegram/SourceFiles/chat_helpers/tabbed_selector.cpp

@@ -938,7 +938,7 @@ void TabbedSelector::Inner::panelHideFinished() {
 }
 
 TabbedSelector::InnerFooter::InnerFooter(QWidget *parent)
-: TWidget(parent) {
+: RpWidget(parent) {
 	resize(st::emojiPanWidth, st::emojiFooterHeight);
 }
 

Telegram/SourceFiles/chat_helpers/tabbed_selector.h

@@ -276,7 +276,7 @@ private:
 
 };
 
-class TabbedSelector::InnerFooter : public TWidget {
+class TabbedSelector::InnerFooter : public Ui::RpWidget {
 public:
 	InnerFooter(QWidget *parent);