2
0
mirror of https://github.com/VinylDNS/vinyldns synced 2025-08-22 02:02:14 +00:00

Fix Dev Deployment Failure due to Flyway DB Migration Issue (#1104)

This commit is contained in:
Nicholas Spadaccino 2022-04-12 10:07:22 -04:00 committed by GitHub
parent 8ce9b95270
commit 230c7f7420
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
15 changed files with 23 additions and 0 deletions

View File

@ -17,3 +17,4 @@ JDBC_URL=jdbc:mariadb://vinyldns-integration:19002/vinyldns?user=root&password=p
JDBC_MIGRATION_URL=jdbc:mariadb://vinyldns-integration:19002/?user=root&password=pass JDBC_MIGRATION_URL=jdbc:mariadb://vinyldns-integration:19002/?user=root&password=pass
JDBC_USER=root JDBC_USER=root
JDBC_PASSWORD=pass JDBC_PASSWORD=pass
FLYWAY_OUT_OF_ORDER=false

View File

@ -186,6 +186,8 @@ vinyldns {
user = ${?JDBC_USER} user = ${?JDBC_USER}
password = "pass" password = "pass"
password = ${?JDBC_PASSWORD} password = ${?JDBC_PASSWORD}
flyway-out-of-order = false
flyway-out-of-order = ${?FLYWAY_OUT_OF_ORDER}
} }
# TODO: Remove the need for these useless configuration blocks # TODO: Remove the need for these useless configuration blocks

View File

@ -186,6 +186,8 @@ vinyldns {
user = ${?JDBC_USER} user = ${?JDBC_USER}
password = "pass" password = "pass"
password = ${?JDBC_PASSWORD} password = ${?JDBC_PASSWORD}
flyway-out-of-order = false
flyway-out-of-order = ${?FLYWAY_OUT_OF_ORDER}
} }
# TODO: Remove the need for these useless configuration blocks # TODO: Remove the need for these useless configuration blocks

View File

@ -186,6 +186,8 @@ vinyldns {
user = ${?JDBC_USER} user = ${?JDBC_USER}
password = "pass" password = "pass"
password = ${?JDBC_PASSWORD} password = ${?JDBC_PASSWORD}
flyway-out-of-order = false
flyway-out-of-order = ${?FLYWAY_OUT_OF_ORDER}
} }
# TODO: Remove the need for these useless configuration blocks # TODO: Remove the need for these useless configuration blocks

View File

@ -195,6 +195,8 @@ vinyldns {
user = ${?JDBC_USER} user = ${?JDBC_USER}
password = "pass" password = "pass"
password = ${?JDBC_PASSWORD} password = ${?JDBC_PASSWORD}
flyway-out-of-order = false
flyway-out-of-order = ${?FLYWAY_OUT_OF_ORDER}
} }
# TODO: Remove the need for these useless configuration blocks # TODO: Remove the need for these useless configuration blocks

View File

@ -186,6 +186,8 @@ vinyldns {
user = ${?JDBC_USER} user = ${?JDBC_USER}
password = "pass" password = "pass"
password = ${?JDBC_PASSWORD} password = ${?JDBC_PASSWORD}
flyway-out-of-order = false
flyway-out-of-order = ${?FLYWAY_OUT_OF_ORDER}
} }
# TODO: Remove the need for these useless configuration blocks # TODO: Remove the need for these useless configuration blocks

View File

@ -13,6 +13,7 @@ mysql {
url = "jdbc:mariadb://"${mysql.endpoint}"/vinyldns2" url = "jdbc:mariadb://"${mysql.endpoint}"/vinyldns2"
user = "root" user = "root"
password = "pass" password = "pass"
flyway-out-of-order = false
# see https://github.com/brettwooldridge/HikariCP # see https://github.com/brettwooldridge/HikariCP
connection-timeout-millis = 1000 connection-timeout-millis = 1000
@ -49,6 +50,7 @@ queue {
url = "jdbc:mariadb://"${mysql.endpoint}"/vinyldns2?user=root&password=pass" url = "jdbc:mariadb://"${mysql.endpoint}"/vinyldns2?user=root&password=pass"
user = "root" user = "root"
password = "pass" password = "pass"
flyway-out-of-order = false
# see https://github.com/brettwooldridge/HikariCP # see https://github.com/brettwooldridge/HikariCP
connection-timeout-millis = 1000 connection-timeout-millis = 1000

View File

@ -35,6 +35,7 @@ final case class MySqlConnectionConfig(
url: String, url: String,
user: String, user: String,
password: String, password: String,
flywayOutOfOrder: Boolean,
migrationSchemaTable: Option[String], migrationSchemaTable: Option[String],
// Optional settings, will use Hikari defaults if unset // Optional settings, will use Hikari defaults if unset
// see https://github.com/brettwooldridge/HikariCP#frequently-used // see https://github.com/brettwooldridge/HikariCP#frequently-used

View File

@ -48,6 +48,7 @@ object MySqlConnector {
val placeholders = Map("dbName" -> config.name) val placeholders = Map("dbName" -> config.name)
val migration = Flyway val migration = Flyway
.configure() .configure()
.outOfOrder(config.flywayOutOfOrder)
.dataSource(migrationDataSource) .dataSource(migrationDataSource)
.placeholders(placeholders.asJava) .placeholders(placeholders.asJava)
.schemas(config.name) .schemas(config.name)

View File

@ -11,6 +11,7 @@ mysql {
url = "url" url = "url"
user = "some-user" user = "some-user"
password = "some-pass" password = "some-pass"
flyway-out-of-order = false
# see https://github.com/brettwooldridge/HikariCP # see https://github.com/brettwooldridge/HikariCP
connection-timeout-millis = 1000 connection-timeout-millis = 1000

View File

@ -55,6 +55,7 @@ class MySqlConnectionConfigSpec extends AnyWordSpec with Matchers {
| url = "url" | url = "url"
| user = "some-user" | user = "some-user"
| password = "some-pass" | password = "some-pass"
| flyway-out-of-order = false
| } | }
| """.stripMargin) | """.stripMargin)

View File

@ -18,6 +18,7 @@ mysql {
url = "http://foo.bar" url = "http://foo.bar"
user = "root" user = "root"
password = "pass" password = "pass"
flyway-out-of-order = false
} }
repositories { repositories {

View File

@ -23,3 +23,4 @@ JDBC_URL=jdbc:mariadb://vinyldns-integration:19002/vinyldns?user=root&password=p
JDBC_MIGRATION_URL=jdbc:mariadb://vinyldns-integration:19002/?user=root&password=pass JDBC_MIGRATION_URL=jdbc:mariadb://vinyldns-integration:19002/?user=root&password=pass
JDBC_USER=root JDBC_USER=root
JDBC_PASSWORD=pass JDBC_PASSWORD=pass
FLYWAY_OUT_OF_ORDER=false

View File

@ -132,6 +132,8 @@ vinyldns {
user = ${?JDBC_USER} user = ${?JDBC_USER}
password = "pass" password = "pass"
password = ${?JDBC_PASSWORD} password = ${?JDBC_PASSWORD}
flyway-out-of-order = false
flyway-out-of-order = ${?FLYWAY_OUT_OF_ORDER}
# see https://github.com/brettwooldridge/HikariCP # see https://github.com/brettwooldridge/HikariCP
connection-timeout-millis = 1000 connection-timeout-millis = 1000
idle-timeout = 10000 idle-timeout = 10000

View File

@ -187,6 +187,8 @@ vinyldns {
user = ${?JDBC_USER} user = ${?JDBC_USER}
password = "pass" password = "pass"
password = ${?JDBC_PASSWORD} password = ${?JDBC_PASSWORD}
flyway-out-of-order = false
flyway-out-of-order = ${?FLYWAY_OUT_OF_ORDER}
# see https://github.com/brettwooldridge/HikariCP # see https://github.com/brettwooldridge/HikariCP
connection-timeout-millis = 1000 connection-timeout-millis = 1000
idle-timeout = 10000 idle-timeout = 10000