mir/vinyldns
2
0
Fork 0
mirror of https://github.com/VinylDNS/vinyldns synced 2025-08-22 02:02:14 +00:00
Code Issues Releases Wiki Activity

fix 422 errors for updating records in private zones from zone view

Browse Source
This commit is contained in:
nspadaccino 2024-12-03 15:43:06 -05:00
parent 37109b4917
commit 2e4bf94126
No known key found for this signature in database
GPG Key ID: AB060C9A2C68918E
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modules/api/src/main/scala/vinyldns/api/domain/record/RecordSetService.scala
View File

@ -161,9 +161,8 @@ class RecordSetService(
&& !auth.isSuper) { && !auth.isSuper) {
recordSetOwnerShipApproveStatus(recordSet).toResult recordSetOwnerShipApproveStatus(recordSet).toResult
} else ().toResult } else ().toResult
_ = logger.debug(s"updated recordsetgroupchange: ${recordSet.recordSetGroupChange}") _ = logger.info(s"updated recordsetgroupchange: ${recordSet.recordSetGroupChange}")
_ = logger.debug(s"existing recordsetgroupchange: ${existing.recordSetGroupChange}") _ = logger.info(s"existing recordsetgroupchange: ${existing.recordSetGroupChange}")
// recordSet <- if(zone.shared) updateRecordSetGroupChangeStatus(recordSet, existing, zone)
recordSet <- updateRecordSetGroupChangeStatus(recordSet, existing, zone) recordSet <- updateRecordSetGroupChangeStatus(recordSet, existing, zone)
change <- RecordSetChangeGenerator.forUpdate(existing, recordSet, zone, Some(auth)).toResult change <- RecordSetChangeGenerator.forUpdate(existing, recordSet, zone, Some(auth)).toResult
// because changes happen to the RS in forUpdate itself, converting 1st and validating on that // because changes happen to the RS in forUpdate itself, converting 1st and validating on that

2
modules/api/src/main/scala/vinyldns/api/domain/record/RecordSetValidations.scala
View File

@ -495,7 +495,7 @@ object RecordSetValidations {
existing: RecordSet existing: RecordSet
): Either[Throwable, Unit] = ): Either[Throwable, Unit] =
Either.cond( Either.cond(
updates.recordSetGroupChange == existing.recordSetGroupChange, updates.recordSetGroupChange == existing.recordSetGroupChange || existing.recordSetGroupChange.isEmpty,
(), (),
InvalidRequest("Cannot update RecordSet OwnerShip Status when zone is not shared.") InvalidRequest("Cannot update RecordSet OwnerShip Status when zone is not shared.")
) )