mir/vinyldns
2
0
Fork 0
mirror of https://github.com/VinylDNS/vinyldns synced 2025-09-03 15:55:42 +00:00
Code Issues Releases Wiki Activity

turn on coverage in batch validations file (#134)

Browse Source 
* turn on coverage in batch validations file

* also remove irrelevant comment
This commit is contained in:
Rebecca Star
2018-08-23 16:16:12 -04:00
committed by GitHub
parent c6de8964d1
commit efdaad52dd
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/api/src/main/scala/vinyldns/api/domain/batch/BatchChangeValidations.scala
View File

@@ -25,17 +25,12 @@ import vinyldns.api.domain.batch.BatchTransformations._
import vinyldns.api.domain.record._ import vinyldns.api.domain.record._
import vinyldns.api.domain.{AccessValidationAlgebra, _} import vinyldns.api.domain.{AccessValidationAlgebra, _}
// turn on coverage once we start implementing these
// $COVERAGE-OFF$
trait BatchChangeValidationsAlgebra { trait BatchChangeValidationsAlgebra {
def validateBatchChangeInputSize(input: BatchChangeInput): Either[BatchChangeErrorResponse, Unit] def validateBatchChangeInputSize(input: BatchChangeInput): Either[BatchChangeErrorResponse, Unit]
def validateInputChanges(input: List[ChangeInput]): ValidatedBatch[ChangeInput] def validateInputChanges(input: List[ChangeInput]): ValidatedBatch[ChangeInput]
// Note: once we add cnames, deletes in,
// this will also want the prior request context (all requests before the current)
// so the caller will likely have to do some kinda funky fold. Will deal with that later
def validateChangesWithContext( def validateChangesWithContext(
changes: ValidatedBatch[ChangeForValidation], changes: ValidatedBatch[ChangeForValidation],
existingRecords: ExistingRecordSets, existingRecords: ExistingRecordSets,
@@ -335,4 +330,3 @@ class BatchChangeValidations(changeLimit: Int, accessValidation: AccessValidatio
UserNotAuthorizedError(batchChange.id).asLeft UserNotAuthorizedError(batchChange.id).asLeft
} }
} }
// $COVERAGE-ON$