mirror of
https://github.com/VinylDNS/vinyldns
synced 2025-08-22 10:10:12 +00:00
The root cause for the authentication error is that the portal was not decrypting the user secret key before signing requests. This is solved via the following: 1. Update VinylDNS controller to decrypt user secret when needed 1. Make sure that the `encrypt-user-secrets` feature flag is `on` in the API reference.conf. This was why in testing locally we did not hit the same issue that we saw in the development environment. Because the flag was false, test users secrets were not encrypted. * `portal application.conf` - set the crypto to match the API * `Dependencies.scala` - eliminate some duplication of dependencies * `api reference.conf` - set the encrypt-user-secrets flag to true * `TestApplicationData.scala` - modify the mock play app to have a CryptoAlgebra binding * `VinylDNS` - add secret decryption in getUserCreds and processCSV * `VinylDNSModule` - add binding for CryptoAlgebra for dependency injection.
174 lines
5.5 KiB
Scala
174 lines
5.5 KiB
Scala
/*
|
|
* Copyright 2018 Comcast Cable Communications Management, LLC
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package controllers
|
|
import cats.effect.IO
|
|
import org.joda.time.DateTime
|
|
import org.specs2.mock.Mockito
|
|
import play.api.inject.bind
|
|
import play.api.inject.guice.GuiceApplicationBuilder
|
|
import play.api.{Application, Configuration, Environment}
|
|
import play.api.libs.json.{JsObject, JsValue, Json}
|
|
import vinyldns.core.crypto.{CryptoAlgebra, NoOpCrypto}
|
|
import vinyldns.core.domain.membership._
|
|
|
|
import scala.util.Success
|
|
|
|
trait TestApplicationData { this: Mockito =>
|
|
val frodoDetails = UserDetails(
|
|
"CN=frodo,OU=hobbits,DC=middle,DC=earth",
|
|
"frodo",
|
|
Some("fbaggins@hobbitmail.me"),
|
|
Some("Frodo"),
|
|
Some("Baggins"))
|
|
|
|
val frodoUser = User(
|
|
"fbaggins",
|
|
"key",
|
|
"secret",
|
|
Some("Frodo"),
|
|
Some("Baggins"),
|
|
Some("fbaggins@hobbitmail.me"),
|
|
DateTime.now,
|
|
"frodo-uuid")
|
|
|
|
val newFrodoLog = UserChange(
|
|
"frodo-uuid",
|
|
frodoUser,
|
|
"fbaggins",
|
|
DateTime.now,
|
|
None,
|
|
UserChangeType.Create
|
|
).toOption.get
|
|
|
|
val serviceAccountDetails =
|
|
UserDetails("CN=frodo,OU=hobbits,DC=middle,DC=earth", "service", None, None, None)
|
|
val serviceAccount =
|
|
User("service", "key", "secret", None, None, None, DateTime.now, "service-uuid")
|
|
|
|
val frodoJsonString: String =
|
|
s"""{
|
|
| "userName": "${frodoUser.userName}",
|
|
| "firstName": "${frodoUser.firstName}",
|
|
| "lastName": "${frodoUser.lastName}",
|
|
| "email": "${frodoUser.email}",
|
|
| "created": "${frodoUser.created}",
|
|
| "id": "${frodoUser.id}"
|
|
|}
|
|
""".stripMargin
|
|
|
|
val samAccount = User(
|
|
"sgamgee",
|
|
"key",
|
|
"secret",
|
|
Some("Samwise"),
|
|
Some("Gamgee"),
|
|
Some("sgamgee@hobbitmail.me"),
|
|
DateTime.now,
|
|
"sam-uuid")
|
|
val samDetails = UserDetails(
|
|
"CN=sam,OU=hobbits,DC=middle,DC=earth",
|
|
"sam",
|
|
Some("sgamgee@hobbitmail.me"),
|
|
Some("Sam"),
|
|
Some("Gamgee"))
|
|
|
|
val frodoJson: String =
|
|
s"""{
|
|
|"name": "${frodoUser.userName}"
|
|
|}
|
|
""".stripMargin
|
|
|
|
val hobbitGroupId = "uuid-12345-abcdef"
|
|
val hobbitGroup: JsValue = Json.parse(s"""{
|
|
| "id": "${hobbitGroupId}",
|
|
| "name": "hobbits",
|
|
| "email": "hobbitAdmin@shire.me",
|
|
| "description": "Hobbits of the shire",
|
|
| "members": [ { "id": "${frodoUser.id}" }, { "id": "samwise-userId" } ],
|
|
| "admins": [ { "id": "${frodoUser.id}" } ]
|
|
| }
|
|
""".stripMargin)
|
|
|
|
val ringbearerGroup: JsValue = Json.parse(
|
|
s"""{
|
|
| "id": "ringbearer-group-uuid",
|
|
| "name": "ringbearers",
|
|
| "email": "future-minions@mordor.me",
|
|
| "description": "Corruptable folk of middle-earth",
|
|
| "members": [ { "id": "${frodoUser.id}" }, { "id": "sauron-userId" } ],
|
|
| "admins": [ { "id": "sauron-userId" } ]
|
|
| }
|
|
""".stripMargin
|
|
)
|
|
val hobbitGroupRequest: JsValue = Json.parse(s"""{
|
|
| "name": "hobbits",
|
|
| "email": "hobbitAdmin@shire.me",
|
|
| "description": "Hobbits of the shire",
|
|
| "members": [ { "id": "${frodoUser.id}" }, { "id": "samwise-userId" } ],
|
|
| "admins": [ { "id": "${frodoUser.id}" } ]
|
|
| }
|
|
""".stripMargin)
|
|
|
|
val invalidHobbitGroup: JsValue = Json.parse(s"""{
|
|
| "name": "hobbits",
|
|
| "email": "hobbitAdmin@shire.me",
|
|
| "description": "Hobbits of the shire",
|
|
| "members": [ { "id": "${frodoUser.id}" }, { "id": "merlin-userId" } ],
|
|
| "admins": [ { "id": "${frodoUser.id}" } ]
|
|
| }
|
|
""".stripMargin)
|
|
|
|
val hobbitGroupMembers: JsValue = Json.parse(
|
|
s"""{
|
|
| "members": [ ${frodoJsonString} ],
|
|
| "maxItems": 100
|
|
|}
|
|
""".stripMargin
|
|
)
|
|
|
|
val groupList: JsObject = Json.obj("groups" -> Json.arr(hobbitGroup))
|
|
val emptyGroupList: JsObject = Json.obj("groups" -> Json.arr())
|
|
|
|
val frodoGroupList: JsObject = Json.obj("groups" -> Json.arr(hobbitGroup, ringbearerGroup))
|
|
|
|
val simulatedBackendPort: Int = 9001
|
|
|
|
val testConfig: Configuration =
|
|
Configuration.load(Environment.simple()) ++ Configuration.from(
|
|
Map("portal.vinyldns.backend.url" -> s"http://localhost:$simulatedBackendPort"))
|
|
|
|
val mockAuth: Authenticator = mock[Authenticator]
|
|
val mockUserRepo: UserRepository = mock[UserRepository]
|
|
val mockUserChangeRepo: UserChangeRepository = mock[UserChangeRepository]
|
|
|
|
mockAuth.authenticate("frodo", "secondbreakfast").returns(Success(frodoDetails))
|
|
mockUserRepo.getUser(anyString).returns(IO.pure(Some(frodoUser)))
|
|
mockUserChangeRepo.save(any[UserChange]).returns(IO.pure(newFrodoLog))
|
|
|
|
def app: Application =
|
|
GuiceApplicationBuilder()
|
|
.disable[modules.VinylDNSModule]
|
|
.bindings(
|
|
bind[Authenticator].to(mockAuth),
|
|
bind[UserRepository].to(mockUserRepo),
|
|
bind[UserChangeRepository].to(mockUserChangeRepo),
|
|
bind[CryptoAlgebra].to(new NoOpCrypto())
|
|
)
|
|
.configure(testConfig)
|
|
.build()
|
|
}
|