mirror of
https://gitlab.isc.org/isc-projects/bind9
synced 2025-08-30 14:07:59 +00:00
Don't detach xfr in dns_xfrin_shutdown()
As we are now using dispatch instead of netmgr for XFR TCP connection, the xfrin_recv_done() will be called when cancelling the dispatch with ISC_R_CANCELED. This could lead to double detach from the dns_xfrin_t, one in the xfrin_recv_done() and one in the dns_xfrin_shutdown(). Remove the extra detach from the dns_xfrin_shutdown() and rely on the dispatch read callback to be always called.
This commit is contained in:
@@ -742,9 +742,6 @@ dns_xfrin_shutdown(dns_xfrin_t *xfr) {
|
||||
REQUIRE(VALID_XFRIN(xfr));
|
||||
|
||||
xfrin_fail(xfr, ISC_R_CANCELED, "shut down");
|
||||
|
||||
/* we won't reach xfrin_recv_done(), so dereference xfr here */
|
||||
dns_xfrin_unref(xfr);
|
||||
}
|
||||
|
||||
#if DNS_XFRIN_TRACE
|
||||
|
Reference in New Issue
Block a user