mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 06:25:31 +00:00
Code Issues Releases Wiki Activity

chg: dev: Restore the number of threadpool threads back to original value

Browse Source 
The issue of long-running operations potentially blocking query resolution has been fixed. Revert this temporary workaround and restore the number of threadpool threads.

Related #4898

Merge branch '4898-remove-workaround-and-note' into 'main'

See merge request isc-projects/bind9!9530
This commit is contained in:
Nicki Křížek
2024-09-20 14:47:24 +00:00
parent 958d306f52 9fc773ce4c
commit 28badd8ed4
2 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
doc/notes/notes-known-issues.rst
View File

@@ -14,12 +14,4 @@
Known Issues
------------
- Long-running tasks in offloaded threads (e.g. loading RPZ zones or
processing zone transfers) may block the resolution of queries during
these operations and cause the queries to time out.
To work around the issue, the ``UV_THREADPOOL_SIZE`` environment
variable can be set to a larger value before starting :iscman:`named`.
The recommended value is the number of RPZ zones (or number of
transfers) plus the number of threads BIND should use, which is
typically the number of CPUs. :gl:`#4898`
- There are no known issues affecting this BIND 9 branch.

5
lib/isc/loop.c
View File

@@ -351,10 +351,7 @@ threadpool_initialize(uint32_t workers) {
int r = uv_os_getenv("UV_THREADPOOL_SIZE", buf,
&(size_t){ sizeof(buf) });
if (r == UV_ENOENT) {
/* FIXME The number of threadpool threads has been temporarily
* doubled to work around the issue [GL #4898] until a proper
* solution is implemented. */
snprintf(buf, sizeof(buf), "%" PRIu32, 2 * workers);
snprintf(buf, sizeof(buf), "%" PRIu32, workers);
uv_os_setenv("UV_THREADPOOL_SIZE", buf);
}
}