mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 06:25:31 +00:00
Code Issues Releases Wiki Activity

fix: usr: Log dropped or slipped responses in the query-errors category

Browse Source 
Responses which were dropped or slipped because of RRL (Response Rate
Limiting) were logged in the ``rate-limit`` category instead of the
``query-errors`` category, as documented in ARM. This has been fixed.

Closes #5388

Merge branch '5388-rrl-log-category-fix' into 'main'

See merge request isc-projects/bind9!10676
This commit is contained in:
Arаm Sаrgsyаn
2025-07-10 08:56:09 +00:00
parent 1d71e3b507 27e7961479
commit 338bd67a10
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ns/client.c
View File

@@ -938,10 +938,10 @@ ns_client_error(ns_client_t *client, isc_result_t result) {
wouldlog, log_buf, sizeof(log_buf));
if (rrl_result != DNS_RRL_RESULT_OK) {
/*
* Log dropped errors in the query category
* Log dropped errors in the query-errors category
* so that they are not lost in silence.
* Starts of rate-limited bursts are logged in
* NS_LOGCATEGORY_RRL.
* DNS_LOGCATEGORY_RRL.
*/
if (wouldlog) {
ns_client_log(client,

5
lib/ns/query.c
View File

@@ -6945,7 +6945,7 @@ query_checkrrl(query_ctx_t *qctx, isc_result_t result) {
sizeof(log_buf));
if (rrl_result != DNS_RRL_RESULT_OK) {
/*
* Log dropped or slipped responses in the query
* Log dropped or slipped responses in the query-errors
* category so that requests are not silently lost.
* Starts of rate-limited bursts are logged in
* DNS_LOGCATEGORY_RRL.
@@ -6955,7 +6955,8 @@ query_checkrrl(query_ctx_t *qctx, isc_result_t result) {
* with other truncated responses in RespTruncated.
*/
if (wouldlog) {
ns_client_log(qctx->client, DNS_LOGCATEGORY_RRL,
ns_client_log(qctx->client,
NS_LOGCATEGORY_QUERY_ERRORS,
NS_LOGMODULE_QUERY,
DNS_RRL_LOG_DROP, "%s", log_buf);
}