mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 14:35:26 +00:00
Code Issues Releases Wiki Activity

Add few missing qpcache_hit() calls

Browse Source 
There were couple of missing qpcache_hit() calls in qpcache.c:add()
function where existing data was better than the newly added header.
This commit is contained in:
Ondřej Surý
2025-08-27 13:52:42 +02:00
parent 7b7901494d
commit 37fa960bd5
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/dns/qpcache.c
View File

@@ -2559,6 +2559,7 @@ expire_ncache_entry(qpcache_t *qpdb, qpcnode_t *qpnode, dns_slabtop_t *top,
/*
* The NXDOMAIN/NODATA(QTYPE=ANY) is more trusted.
*/
qpcache_hit(qpdb, top->header);
bindrdataset(qpdb, qpnode, top->header, now, nlocktype,
tlocktype,
addedrdataset DNS__DB_FLARG_PASS);
@@ -2751,6 +2752,7 @@ add(qpcache_t *qpdb, qpcnode_t *qpnode, dns_slabheader_t *newheader,
if (trust < header->trust &&
(ACTIVE(header, now) || !EXISTS(header)))
{
qpcache_hit(qpdb, header);
bindrdataset(qpdb, qpnode, header, now, nlocktype,
tlocktype,
addedrdataset DNS__DB_FLARG_PASS);
@@ -2774,8 +2776,6 @@ add(qpcache_t *qpdb, qpcnode_t *qpnode, dns_slabheader_t *newheader,
qpdb->common.rdclass,
DNS_TYPEPAIR_TYPE(header->typepair)))
{
qpcache_hit(qpdb, header);
if (header->noqname == NULL &&
newheader->noqname != NULL)
{
@@ -2788,6 +2788,8 @@ add(qpcache_t *qpdb, qpcnode_t *qpnode, dns_slabheader_t *newheader,
header->closest = newheader->closest;
newheader->closest = NULL;
}
qpcache_hit(qpdb, header);
bindrdataset(qpdb, qpnode, header, now, nlocktype,
tlocktype,
addedrdataset DNS__DB_FLARG_PASS);
@@ -2824,8 +2826,6 @@ add(qpcache_t *qpdb, qpcnode_t *qpnode, dns_slabheader_t *newheader,
header->expire < newheader->expire &&
dns_rdataslab_equal(header, newheader))
{
qpcache_hit(qpdb, header);
if (header->noqname == NULL &&
newheader->noqname != NULL)
{
@@ -2838,6 +2838,8 @@ add(qpcache_t *qpdb, qpcnode_t *qpnode, dns_slabheader_t *newheader,
header->closest = newheader->closest;
newheader->closest = NULL;
}
qpcache_hit(qpdb, header);
bindrdataset(qpdb, qpnode, header, now, nlocktype,
tlocktype,
addedrdataset DNS__DB_FLARG_PASS);