mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 22:15:20 +00:00
Code Issues Releases Wiki Activity

changes from code review: use ISC_LIST_EMPTY(msg->sections[i])

Browse Source 
rather than msg->counts[i] > 0 to determine whether a section is
empty, since the count field does not track pseudosections
This commit is contained in:
Andreas Gustafsson
2000-03-20 16:57:46 +00:00
parent ac4e7a61a8
commit afda57a68e
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
bin/tests/printmsg.c
View File

@@ -196,35 +196,34 @@ printmessage(dns_message_t *msg) {
(unsigned int)((opt->ttl & 0x00ff0000) >> 16),
(unsigned int)opt->rdclass);
if (msg->counts[DNS_SECTION_TSIG] > 0)
printf(";; PSEUDOSECTIONS: TSIG: %u\n",
msg->counts[DNS_SECTION_TSIG]);
if (msg->counts[DNS_SECTION_QUESTION] > 0) {
if (! ISC_LIST_EMPTY(msg->sections[DNS_SECTION_TSIG]))
printf(";; PSEUDOSECTIONS: TSIG\n");
if (! ISC_LIST_EMPTY(msg->sections[DNS_SECTION_QUESTION])) {
printf("\n");
result = printsection(msg, DNS_SECTION_QUESTION, "QUESTION");
if (result != DNS_R_SUCCESS)
return (result);
}
if (msg->counts[DNS_SECTION_ANSWER] > 0) {
if (! ISC_LIST_EMPTY(msg->sections[DNS_SECTION_ANSWER])) {
printf("\n");
result = printsection(msg, DNS_SECTION_ANSWER, "ANSWER");
if (result != DNS_R_SUCCESS)
return (result);
}
if (msg->counts[DNS_SECTION_AUTHORITY] > 0) {
if (! ISC_LIST_EMPTY(msg->sections[DNS_SECTION_AUTHORITY])) {
printf("\n");
result = printsection(msg, DNS_SECTION_AUTHORITY, "AUTHORITY");
if (result != DNS_R_SUCCESS)
return (result);
}
if (msg->counts[DNS_SECTION_ADDITIONAL] > 0) {
if (! ISC_LIST_EMPTY(msg->sections[DNS_SECTION_ADDITIONAL])) {
printf("\n");
result = printsection(msg, DNS_SECTION_ADDITIONAL,
"ADDITIONAL");
if (result != DNS_R_SUCCESS)
return (result);
}
if (msg->counts[DNS_SECTION_TSIG] > 0) {
if (! ISC_LIST_EMPTY(msg->sections[DNS_SECTION_TSIG])) {
printf("\n");
result = printsection(msg, DNS_SECTION_TSIG,
"PSEUDOSECTION TSIG");