mirror of
https://gitlab.isc.org/isc-projects/bind9
synced 2025-08-31 06:25:31 +00:00
Prevent invalid warnings about missing identifiers
The Danger script inspects differences between the current version of a given merge request's target branch and the merge request branch. If the latter falls behind the former, the Danger script will wrongly warn about missing GitLab/RT identifiers because it incorrectly treats the "+++" diff marker as an indication of the merge request adding new lines to a file. Tweak the relevant conditional expression to prevent such invalid warnings from being raised.
This commit is contained in:
@@ -21,7 +21,7 @@ def added_lines(target_branch, paths):
|
||||
'--'] + paths)
|
||||
added_lines = []
|
||||
for line in diff.splitlines():
|
||||
if line.startswith(b'+'):
|
||||
if line.startswith(b'+') and not line.startswith(b'+++'):
|
||||
added_lines.append(line)
|
||||
return added_lines
|
||||
|
||||
|
Reference in New Issue
Block a user