mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 14:35:26 +00:00
Code Issues Releases Wiki Activity

Improve tempdir logging for pytest runner

Browse Source 
At the end of the test, display the symlink path to the artifact
directory in case it's preserved. Log the full tempdir name in debug
log.
This commit is contained in:
Tom Krizek
2023-08-10 16:24:38 +02:00
parent e1ca5c8071
commit f91d0b13e8
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
bin/tests/system/conftest.py
View File

@@ -451,7 +451,7 @@ else:
# System tests are meant to be executed from their directory - switch to it.
old_cwd = os.getcwd()
os.chdir(testdir)
mlogger.info("switching to tmpdir: %s", testdir)
mlogger.debug("switching to tmpdir: %s", testdir)
try:
yield testdir # other fixtures / tests will execute here
finally:
@@ -461,13 +461,27 @@ else:
result = get_test_result()
# Clean temporary dir unless it should be kept
keep = False
if request.config.getoption("--noclean"):
mlogger.debug("--noclean requested, keeping temporary directory")
mlogger.debug(
"--noclean requested, keeping temporary directory %s", testdir
)
keep = True
elif result == "failed":
mlogger.debug("test failure detected, keeping temporary directory")
mlogger.debug(
"test failure detected, keeping temporary directory %s", testdir
)
keep = True
elif not request.node.stash[FIXTURE_OK]:
mlogger.debug(
"test setup/teardown issue detected, keeping temporary directory"
"test setup/teardown issue detected, keeping temporary directory %s",
testdir,
)
keep = True
if keep:
mlogger.info(
"test artifacts in: %s", symlink_dst.relative_to(system_test_root)
)
else:
mlogger.debug("deleting temporary directory")