Michał Kępień
1f400b68a8
Do not ignore resolv.conf syntax errors
...
irs_resconf_load() stores the value returned by add_search() into ret
without consulting its current value first. This causes any previous
errors raised while parsing resolv.conf to be ignored as long as any
"domain" or "search" statement is present in the file.
Prevent this by returning early in case an error is detected while
parsing resolv.conf. Ensure that "searchlist" and "magic" members of
the created irs_resconf_t structure are always initialized before
isc_resconf_destroy() is called.
2018-03-06 08:27:45 +01:00
Mark Andrews
5c0327e8ff
Merge branch '126-make-distclean-fail' into 'master'
...
Resolve ""make distclean" fail."
Closes #126
See merge request isc-projects/bind9!102
2018-03-06 00:08:22 -05:00
Mark Andrews
57f7cf211c
don't allow a macro to end in '\'
2018-03-06 15:13:03 +11:00
Evan Hunt
8529e124ea
Merge branch 'fix-changes' into 'master'
...
fix CHANGES
See merge request isc-projects/bind9!96
2018-03-02 14:56:11 -05:00
Evan Hunt
91d8c1f95c
fix CHANGE notes
2018-03-02 11:53:38 -08:00
Evan Hunt
3fed986199
Merge branch '124-revert-deadlock-check' into 'master'
...
revert cname loop test due to effects on apex CNAMEs under insecure delegations
See merge request isc-projects/bind9!95
2018-03-02 14:47:14 -05:00
Evan Hunt
b291b45312
temporarily revert change #4859
2018-03-02 11:30:02 -08:00
Michał Kępień
148cc40381
Merge branch 'fix-fetchlimit' into 'master'
...
Improve failure logging in fetchlimit system test
See merge request isc-projects/bind9!81
2018-03-01 09:39:24 -05:00
Evan Hunt
86838b2a02
revise soft limit test
...
- don't bail out of the loop if clients are exceeded, just count incidents
- verbosely describe expectations and results
2018-03-01 09:26:14 -05:00
Michał Kępień
78352caba7
Merge branch '121-views-system-test-has-wrong-test-strings-for-reload-completion' into 'master'
...
Resolve "views system test has wrong test strings for reload completion."
Closes #121
See merge request isc-projects/bind9!88
2018-02-28 08:54:38 -05:00
Mark Andrews
4cb0873a0a
wait for 'all zones loaded' rather than 'reloading zones succeeded' which just indicates that everything kicked off ok
2018-02-28 17:14:30 +11:00
Evan Hunt
cb6633c11c
Merge branch '96-update-contributors-guide-and-move-it-at-top-level-so-it-s-recognised-by-gitlab' into 'master'
...
Update contributor's guide and move it to top level, so it's recognized by GitLab
Closes #96
See merge request isc-projects/bind9!58
2018-02-27 17:52:11 -05:00
Evan Hunt
985d35f6b7
Set up CONTRIBUTING.md
...
- moved into place from doc/dev/contrib.md
- build CONTRIBUTING from CONTRIBUTING.md, like README and OPTIONS
2018-02-27 14:40:34 -08:00
Evan Hunt
f22af09819
Merge branch '113-minor-testsummary.sh-improvements' into 'master'
...
Minor testsummary.sh improvements (handling colored output, failure summary)
Closes #113
See merge request isc-projects/bind9!80
2018-02-27 12:33:33 -05:00
Stephen Morris
58ad17bd54
Merge branch '97-windows-version-of-bind-failing-to-build' into 'master'
...
Resolve "Windows version of BIND failing to build"
Closes #97
See merge request isc-projects/bind9!65
2018-02-27 04:58:05 -05:00
Michał Kępień
b7c22b8f09
Merge branch '98-add-util-git-replay-merge.sh' into 'master'
...
Put git-replay-merge in source tree
Closes #98
See merge request isc-projects/bind9!83
2018-02-27 04:39:10 -05:00
Michał Kępień
f7fe1e3098
Add util/git-replay-merge.sh
...
git-replay-merge.sh is a script whose purpose is to make backporting
merge requests more convenient by automating the process as much as
possible.
For more information, including usage examples, see:
https://gitlab.isc.org/isc-projects/bind9/wikis/Backporting-a-Merge-Request
2018-02-27 10:23:32 +01:00
Evan Hunt
38940619c6
Do not destroy systests.output if there are no test.output files
2018-02-27 09:47:59 +01:00
Michał Kępień
642e20db8a
Use echoinfo for printing test summary
...
This ensures testsummary.sh is consistent with other scripts belonging
to the test framework.
2018-02-27 09:47:59 +01:00
Michał Kępień
28068857e7
Make testsummary.sh print a list of failed system tests
...
Print a list of failed system tests, if any, below the system test
summary to avoid the need to manually search through the test log.
2018-02-27 09:45:03 +01:00
Michał Kępień
9006d6dbbd
Tweak the regular expression used for extracting system test results
...
The current regular expression used for extracting system test results
from systests.output, "^R:", is anchored at the start of a line, which
prevents colored system test output from being properly processed. As
just "R:" would arguably be too general, extend the pattern a bit to
ensure it will only match lines containing system test results.
2018-02-27 08:59:51 +01:00
Evan Hunt
8282fd8b50
Merge branch 'test-output' into 'master'
...
Clean up test output
See merge request isc-projects/bind9!66
2018-02-27 02:50:34 -05:00
Evan Hunt
0e52fbd0b3
clean up test output
...
- removed a few remaing places where output wasn't being passed
through echo_i or cat_i
- added a "digcomp" function to conf.sh.in to send digcomp.pl output
through cat_i and return the correct exit value
- set SYSTESTDIR when calling echo_i from nsX directories, so that
the test name will always be printed correctly
- fixed a test name typo in conf.sh.in
2018-02-26 23:37:05 -08:00
Mukund Sivaraman
e656041fd7
Merge branch '79-add-working-directory-to-example-in-doc-dev-dev-md' into 'master'
...
Resolve "Add working directory to example in doc/dev/dev.md"
Closes #79
See merge request isc-projects/bind9!47
2018-02-26 22:27:02 -05:00
Evan Hunt
2e7c726bb0
Merge branch '112-fix-mx-checks-for-dynamic-updates' into 'master'
...
Fix MX checks for dynamic updates
Closes #112
See merge request isc-projects/bind9!79
2018-02-26 17:56:32 -05:00
Mukund Sivaraman
451241a776
working directory is usually not in PATH
2018-02-26 12:55:12 -08:00
Evan Hunt
409cc22934
Merge branch 'check-for-test-interfaces-before-running-system-tests' into 'master'
...
Check for test interfaces before running system tests
See merge request isc-projects/bind9!19
2018-02-26 13:00:37 -05:00
Evan Hunt
a8b583e78b
test interfaces directly in runall.sh and parallel.mk
2018-02-26 14:58:16 +01:00
Michał Kępień
e0221f2d25
Check for test interfaces before running system tests
...
Prevent runall.sh and "make test" from even attempting to run system
tests when "ifconfig.sh up" has not been run beforehand. This ensures
the user is not flooded with error messages in such a case.
2018-02-26 14:12:48 +01:00
Michał Kępień
1d403f9d3c
Add CHANGES entry
...
4903. [bug] "check-mx fail;" did not prevent MX records containing
IP addresses from being added to a zone by a dynamic
update. [GL #112 ]
2018-02-26 13:47:28 +01:00
Michał Kępień
857a40c87b
Fix MX checks for dynamic updates
...
The check_mx() function in lib/ns/update.c incorrectly tests whether the
DNS_RDATA_CHECKMX/DNS_RDATA_CHECKMXFAIL flags are set for each applied
MX record update as these flags are never set in code paths related to
dynamic updates; they can only be set when loading a zone from a master
file (DNS_ZONEOPT_CHECKMX -> DNS_MASTER_CHECKMX -> DNS_RDATA_CHECKMX).
This flaw allows MX records containing IP addresses to be added to a
zone even when "check-mx fail;" is used.
Ensure correct behavior by modifying the relevant tests in check_mx() so
that they use DNS_ZONEOPT_CHECKMX/DNS_ZONEOPT_CHECKMXFAIL instead.
2018-02-26 13:10:45 +01:00
Evan Hunt
e1d6c9a663
Merge branch '66-ixfr-system-test-fails-intermittently' into 'master'
...
chg: dev: Improved the reliability of the 'ixfr' system test. [GL #66 ]
Closes #66
See merge request isc-projects/bind9!67
2018-02-26 01:30:28 -05:00
Evan Hunt
67a8b5ec17
wait for synchronization; re-notify slave if the transfer doesn't happen
2018-02-25 22:18:30 -08:00
Mark Andrews
0dfcb9beaa
Merge branch '51-fix-cppcheck-detected-source-code-errors' into 'master'
...
Resolve "Fix cppcheck-detected source code errors"
Closes #51
See merge request isc-projects/bind9!46
2018-02-25 18:37:16 -05:00
Evan Hunt
8e71b7cd73
Merge branch 'note' into 'master'
...
add missing release note
See merge request isc-projects/bind9!73
2018-02-25 17:39:20 -05:00
Evan Hunt
cc5432cea5
added missing release note
2018-02-25 14:37:37 -08:00
Evan Hunt
cfa35420ee
Merge branch 'upforwd-error' into 'master'
...
Resolve "upforwd test error"
See merge request isc-projects/bind9!72
2018-02-25 16:55:09 -05:00
Evan Hunt
54e010d51e
fixed an upforwd test error.
2018-02-25 13:43:14 -08:00
Evan Hunt
ab0fe63f07
minor cleanup and addressed a sprintf format warning
2018-02-24 17:56:17 -08:00
Mark Andrews
48ca11df5f
update printf format to match type
2018-02-24 17:50:41 -08:00
Mark Andrews
a04bb76973
improve the conditional declaration and use of variable to silence cppcheck
2018-02-24 17:50:41 -08:00
Mark Andrews
b71a1386ed
remove deadcode
2018-02-24 17:50:41 -08:00
Mark Andrews
e8249dcd49
silence unread assignment warning by using POST macro
2018-02-24 17:50:41 -08:00
Mark Andrews
70d192eb97
update the sscanf format strings so they match the pointer types
2018-02-24 17:50:27 -08:00
Mark Andrews
a4186b1867
redefine CHECK so cppcheck see the definition
2018-02-24 17:50:27 -08:00
Mark Andrews
f2c22662cc
remove unused struct dst_context declaration
2018-02-24 17:50:08 -08:00
Mark Andrews
dcd309bea1
conditionally typedef fstrmtable
2018-02-24 17:49:49 -08:00
Mark Andrews
7b27be54ee
adjust goto target and conditional compilation so that cleanup_spillattimer and cleanup_alglock labels match the element to be cleanup and so that they are always used
2018-02-24 17:49:49 -08:00
Evan Hunt
4c753f5880
Merge branch 'tidy-runall.sh-environment-variables' into 'master'
...
Tidy runall.sh environment variables
See merge request isc-projects/bind9!18
2018-02-24 15:43:22 -05:00
Evan Hunt
bd34375e9b
Merge branch 'nssearch-timeout' into 'master'
...
chg: usr: List servers that time out in dig +nssearch. [GL #64 ]
See merge request isc-projects/bind9!28
Closes #64
2018-02-24 14:14:12 -05:00