Michał Kępień
39ddf9991f
Do not access dns_fixedname_t fields directly
...
Employ dns_fixedname_name() and dns_fixedname_initname() to no longer
directly access dns_fixedname_t fields.
2018-04-09 12:14:16 +02:00
Michał Kępień
4df4a8e731
Use dns_fixedname_initname() where possible
...
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.
This patch was mostly prepared using Coccinelle and the following
semantic patch:
@@
expression fixedname, name;
@@
- dns_fixedname_init(&fixedname);
...
- name = dns_fixedname_name(&fixedname);
+ name = dns_fixedname_initname(&fixedname);
The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.
It is likely that more occurrences of this pattern can be refactored in
an identical way. This commit only takes care of the low-hanging fruit.
2018-04-09 12:14:16 +02:00
Mukund Sivaraman
0d2a03c290
Add a dns_fixedname_initname() helper function
...
This also turns the dns_fixedname macros into functions.
2018-04-09 12:14:16 +02:00
Witold Krecicki
76fa1c181c
Merge branch 'libdns-cleanup2' into 'master'
...
libdns cleanup
See merge request isc-projects/bind9!172
2018-04-06 02:10:50 -04:00
Witold Kręcicki
f6a16bbd4a
libdns refactoring: CHANGES entry
2018-04-06 08:04:41 +02:00
Witold Kręcicki
102a397e39
libdns refactoring: get rid of multiple versions of dns_keytable_add, dns_iptable_addprefix and dns_iptable_addprefix
2018-04-06 08:04:41 +02:00
Witold Kręcicki
c8aa1ee9e6
libdns refactoring: get rid of multiple versions of dns_dt_create, dns_view_setcache, dns_zt_apply, dns_message_logfmtpacket, dns_message_logpacket, dns_ssutable_checkrules and dns_ttl_totext
2018-04-06 08:04:41 +02:00
Witold Kręcicki
d54d482af0
libdns refactoring: get rid of multiple versions of dns_view_find, dns_view_findzonecut and dns_view_flushcache
2018-04-06 08:04:41 +02:00
Witold Kręcicki
702c022016
libdns refactoring: get rid of multiple versions of dns_xfrin_create, dst_key_generate, dst_lib_init and dst_context_create
2018-04-06 08:04:41 +02:00
Witold Kręcicki
ef0e68bfc3
libdns refactoring: integrate zone->options and zone->options2 into one enum, removing unnecessary flags.
2018-04-06 08:04:41 +02:00
Witold Kręcicki
7dbc6768d6
libdns refactoring: get rid of multiple versions of dns_zone_setfile, dns_zone_notifyreceive, dns_zone_dumptostream, dns_zone_getserial
2018-04-06 08:04:41 +02:00
Witold Kręcicki
42ee8c853a
libdns refactoring: get rid of 3 versions of dns_resolver_createfetch
2018-04-06 08:04:41 +02:00
Witold Kręcicki
25cd3168a7
libdns refactoring: get rid of multiple versions of dns_dnssec_findmatchingkeys and dns_dnssec_findzonekeys
2018-04-06 08:04:41 +02:00
Witold Kręcicki
8c12e488f7
libdns refactoring: get rid of multiple versions of dns_request_createraw and dns_request_createvia
2018-04-06 08:04:41 +02:00
Witold Kręcicki
e2a06db7f3
libdns refactoring: get rid of multiple versions of dns_master_loadfile, dns_master_loadfileinc, dns_master_dump, dns_master_dumpinc, dns_master_dumptostream, dns_master_stylecreate
2018-04-06 08:04:41 +02:00
Witold Kręcicki
e20b702418
libdns refactoring: get rid of multiple versions of dns_dispatch_createtcp and dns_dispatch_addresponse, unify dns_dispatch_gettcp and dns_dispatch_gettcp2
2018-04-06 08:04:41 +02:00
Witold Kręcicki
275a6a3bec
libdns refactoring: get rid of unnecessary dns_db_dump2 and 3 versions of dns_db_load
2018-04-06 08:04:41 +02:00
Witold Kręcicki
76e17b54ea
libdns refactoring: get rid of two versions of dns_client_createx
2018-04-06 08:04:41 +02:00
Witold Kręcicki
d39b3209fb
libdns refactoring: get rid of 3 versions of dns_cache_create
2018-04-06 08:04:41 +02:00
Witold Kręcicki
d76ed0da1c
libdns refactoring: get rid of two versions of dns_byaddr_createptrname
2018-04-06 08:04:41 +02:00
Witold Kręcicki
f0a07b7546
libdns refactoring: get rid of two versions of dns_adb_createfind and dns_adb_probesize
2018-04-06 08:04:41 +02:00
Witold Kręcicki
3687648384
libdns refactoring: get rid of two versions of dns_acl_match and dns_aclelement_match
2018-04-06 08:04:40 +02:00
Mark Andrews
10814aaf3b
Merge branch '193-make-distclean-fails' into 'master'
...
Resolve "make distclean fails"
Closes #193
See merge request isc-projects/bind9!182
2018-04-05 23:37:07 -04:00
Mark Andrews
f87e0c03ee
system should only be in SUBDIRS
2018-04-06 13:33:53 +10:00
Ondřej Surý
622cffee9d
Merge branch 'fix-CHANGES-188-178' into 'master'
...
Fix typo in issue number in CHANGES file (188 -> 178)
See merge request isc-projects/bind9!181
2018-04-05 07:52:45 -04:00
Ondřej Surý
f70121ed90
Fix typo in issue number in CHANGES file (188 -> 178)
2018-04-05 13:45:54 +02:00
Ondřej Surý
860e76b9a5
Merge branch 'pemensik/bind9-no-idn2-export' into 'master'
...
Don't include -lidn2 in isc-config.sh output
Closes #163
See merge request isc-projects/bind9!178
2018-04-05 06:03:02 -04:00
Ondřej Surý
8da5e5290f
Print information about LIBIDN2 in Configuration summary ( Closes : #163 )
2018-04-05 11:52:24 +02:00
Petr Menšík
21c2871667
Remove -lidn2 from exported LIBS. Do not propagate it from isc-config.sh --libs isc.
2018-04-05 11:52:24 +02:00
Ondřej Surý
ab992d40b0
Merge branch '178-cleanup-isc_hash-functions' into 'master'
...
Clean up the isc_hash_* family of functions
See merge request isc-projects/bind9!160
2018-04-04 17:19:41 -04:00
Ondřej Surý
e74c245e29
Update CHANGES
2018-04-04 23:12:35 +02:00
Ondřej Surý
3c092eff4a
Cleanup included headers in hash.c using iwyu
2018-04-04 23:12:14 +02:00
Ondřej Surý
860d4f6177
Remove premature optimization in the FNV-1a while loop, the difference is negligible and the code is simpler.
2018-04-04 23:12:14 +02:00
Ondřej Surý
b097be17ef
Remove unused obsolete isc_hash_* function, and just keep the FNV-1a version
2018-04-04 23:12:14 +02:00
Ondřej Surý
d81e1caa71
Merge branch 'kchen/bind9-test-prereqs' into 'master'
...
Add a Net::DNS prereq for couple of tests
See merge request isc-projects/bind9!171
2018-04-04 16:29:36 -04:00
Kevin Chen
8b1b809ab4
Add a Net::DNS prereq for digdelv, fetchlimit, rpzrecurse, and zero
...
tests to avoid failed tests when Net::DNS is not present.
2018-04-04 22:23:14 +02:00
Ondřej Surý
c0405c3024
Merge branch 'ssl-double-free' into 'master'
...
Fix double free after keygen error in dnssec-keygen
Closes #109
See merge request isc-projects/bind9!70
2018-04-04 11:41:26 -04:00
Ondřej Surý
ef2b2a6c92
Add CHANGES entry
2018-04-04 17:28:55 +02:00
Ondřej Surý
d2b3188c61
A couple of more cleanups after free in opensslrsa_generate()
2018-04-04 17:28:55 +02:00
Petr Mensik
edaafacf36
Do not assign NULL conditionally in OpenSSL < 1.1, make it always explicit.
2018-04-04 17:28:55 +02:00
Petr Mensik
01cc622e7b
Fix double free on RSA_generate_key_ex failure
2018-04-04 17:28:55 +02:00
Stephen Morris
955ca7382d
Merge branch '139-tests-for-idna2008-libidn2' into 'master'
...
Resolve "Tests for IDNA2008 (libidn2)"
Closes #139
See merge request isc-projects/bind9!147
2018-04-04 09:52:23 -04:00
Stephen Morris
e0e81288cd
Check libidn2 version before proceding with one of the tests.
...
A known issue in libidn2 causes one of the tests of a fake A-label
to fail. The problem should be corrected in version 2.0.5 of
libidn2.
2018-04-04 09:42:08 -04:00
Ondřej Surý
4dad408ead
Use C.UTF-8 if available, and en_US.UTF-8 is available, otherwise do nothing and let the test break
2018-04-04 09:42:08 -04:00
Stephen Morris
8cf29aafec
Set known locale prior to running tests.
2018-04-04 09:42:08 -04:00
Stephen Morris
5009724f40
Fix check for the presence of IDNA.
2018-04-04 09:42:08 -04:00
Stephen Morris
dc7b3d7597
Added additional tests for invalid punycode strings.
2018-04-04 09:42:07 -04:00
Stephen Morris
6755118493
Initial set of IDNA tests.
2018-04-04 09:42:07 -04:00
Michał Kępień
950c354b3d
Merge branch '188-remove-duplicate-named_g_conffile-init' into 'master'
...
Remove redundant named_g_conffile initialization
Closes #188
See merge request isc-projects/bind9!166
2018-04-04 06:31:55 -04:00
Ondřej Surý
c727f0797b
Remove redundant named_g_conffile initialization from bin/named/win32/os.c
2018-04-03 20:39:34 +02:00