Ondřej Surý
78543ad5a7
Fix off-by-one error when calculating new hashtable size
...
When calculating the new hashtable bitsize, there was an off-by-one
error that would allow the new bitsize to be larger than maximum allowed
causing assertion failure in the rehash() function.
2020-08-28 16:21:21 +02:00
Michal Nowak
25d35029eb
Merge branch 'mnowak/fix-tarball-test-suite.log-print' into 'main'
...
Print test-suite.log correctly in tarball system test job
See merge request isc-projects/bind9!3990
2020-08-28 12:38:32 +00:00
Michal Nowak
0c9c755952
Print test-suite.log correctly in tarball system test job
...
Printing test-suite.log on system test failure does not work for system
test run from tarball because the "after_script" step does not honour
directory change from the "before_script" step and fails with:
Running after script...
$ cat bin/tests/system/test-suite.log
cat: bin/tests/system/test-suite.log: No such file or directory
2020-08-28 14:00:10 +02:00
Ondřej Surý
56ee60e130
Merge branch '2074-bind-allows-an-empty-cm-value-for-optional-loc-rdata-fields' into 'main'
...
Resolve "BIND allows an empty 'cm' value for optional LOC RDATA fields"
Closes #2074
See merge request isc-projects/bind9!3988
2020-08-26 14:28:17 +00:00
Mark Andrews
d9594cffab
Add CHANGES note
2020-08-26 15:31:51 +02:00
Mark Andrews
2ca4d35037
Refactor totext_loc
2020-08-26 15:31:31 +02:00
Mark Andrews
337cc878fa
Correctly encode LOC records with non integer negative altitudes.
2020-08-26 15:31:31 +02:00
Mark Andrews
888dfd78c7
Check LOC's altitude field is properly parsed and encoded.
2020-08-26 15:31:31 +02:00
Mark Andrews
9225c67835
Tighten LOC parsing to reject period and/or m as a value.
2020-08-26 15:31:31 +02:00
Mark Andrews
daca5e8912
Merge branch '2080-data-race-in-rdataset_addglue' into 'main'
...
Resolve "data race in rdataset_addglue"
Closes #2080
See merge request isc-projects/bind9!3987
2020-08-26 11:32:57 +00:00
Mark Andrews
48973c3ec6
Add CHANGES note
2020-08-26 21:16:04 +10:00
Ondřej Surý
01684cc219
Use the Fibonacci Hashing for the RBTDB glue table
...
The rbtdb version glue_table has been refactored similarly to rbt.c hash
table, so it does use 32-bit hash function return values and apply
Fibonacci Hashing to lookup the index to the hash table instead of
modulo. For more details, see the lib/dns/rbt.c commit log.
2020-08-26 21:16:04 +10:00
Mark Andrews
33d0e8d168
rbtversion->glue_table_size must be read when holding a lock
2020-08-26 21:16:04 +10:00
Michal Nowak
0ede73b9f1
Merge branch 'mnowak/tumbleweed-fix-krb5-config-location' into 'main'
...
Tumbleweed changed location of krb5-config
See merge request isc-projects/bind9!4016
2020-08-26 08:57:20 +00:00
Michal Nowak
6095811461
Tumbleweed changed location of krb5-config
...
krb5-config is now in /usr/bin/ and we should detect it automatically.
2020-08-26 10:56:01 +02:00
Ondřej Surý
045173f8a7
Merge branch '2097-manual-page-tools-need-updating' into 'main'
...
Fix generated documentation
Closes #2097
See merge request isc-projects/bind9!4017
2020-08-26 08:51:49 +00:00
Michal Nowak
56abe27b9e
Fix generated documentation
...
With Sphinx 3.2.1 line-leading period should be escaped.
2020-08-26 10:34:01 +02:00
Ondřej Surý
f3270a6d88
Merge branch 'ondrej/copy-wire-test-to-fuzz' into 'main'
...
Add dns_message_parse() fuzzer
See merge request isc-projects/bind9!4009
2020-08-25 18:19:02 +00:00
Ondřej Surý
9d14522469
Add minimized (cmin-tmin-cmin) corpus for dns_message_parse fuzzer
...
The non-minimized corpus from https://github.com/CZ-NIC/dns-fuzzing was
used as input to afl-cmin, then every case were processed by afl-tmin
and then afl-cmin was used to further minimize the corpus again.
2020-08-25 16:40:24 +02:00
Ondřej Surý
01cc80376e
Add dns_message_parse() fuzzer
...
Previously, the bin/system/wire_test.c was optionally used as a fuzzer,
this commit extracts the parts relevant to the fuzzing into a
specialized fuzzer that can be used in oss-fuzz project.
The fuzzer parses the input as UDP DNS message, then prints parsed DNS
message, then renders the DNS message and then prints the rendered DNS
message. No part of the code should cause a assertion failure.
2020-08-25 16:40:24 +02:00
Ondřej Surý
2164b6926f
Merge branch '2095-shifting-large-rcode-in-dns-message-c-results-in-undefined-behaviour' into 'main'
...
Resolve "Shifting large rcode in dns/message.c results in undefined behaviour"
Closes #2095
See merge request isc-projects/bind9!4011
2020-08-25 14:11:04 +00:00
Mark Andrews
a347641782
Cast the original rcode to (dns_ttl_t) when setting extended rcode
...
Shifting (signed) integer left could trigger undefined behaviour when
the shifted value would overflow into the sign bit (e.g. 2048).
The issue was found when using AFL++ and UBSAN:
message.c:2274:33: runtime error: left shift of 2048 by 20 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior message.c:2274:33 in
2020-08-25 14:10:05 +00:00
Michal Nowak
3f85b0fe3b
Merge branch '2053-test-disable-buffer-useinline-in-gitlab-ci' into 'main'
...
Resolve "Test --disable-buffer-useinline in GitLab CI"
Closes #2053
See merge request isc-projects/bind9!3983
2020-08-25 14:04:47 +00:00
Michal Nowak
f34df4ef90
Build CentOS 8 with --enable-buffer-useinline
2020-08-25 16:02:55 +02:00
Michal Nowak
dd425254a7
Fix warnings in when build with --enable-buffer-useinline
...
sockaddr.c:147:49: error: pointer targets in passing argument 2 of ‘isc__buffer_putmem’ differ in signedness
rdata.c:1780:30: error: pointer targets in passing argument 2 of ‘isc__buffer_putmem’ differ in signedness
2020-08-25 16:02:55 +02:00
Mark Andrews
f036e0bc7f
Merge branch 'marka-add-missing-isc_mutex_init' into 'main'
...
Add missing isc_mutex_init to manytasks subtest.
See merge request isc-projects/bind9!3996
2020-08-24 23:54:46 +00:00
Mark Andrews
2eb5c29c83
Add missing isc_mutex_init to manytasks subtest.
2020-08-24 22:38:08 +00:00
Ondřej Surý
273d21fc93
Merge branch 'ondrej/update-pregenerated-files' into 'main'
...
Update pregenerated documentation files
See merge request isc-projects/bind9!4005
2020-08-24 17:48:14 +00:00
Ondřej Surý
ca487a5db0
Sync the pregenerated files with their source counterparts
2020-08-24 14:44:05 +02:00
Ondřej Surý
586415fea2
Make sure the maintainer files are clean after rebuild
...
When updating source files, we might forget to update pre-generated
files (generated by sphinx-build and cfg_gen) and then the extra changes
would get included in the random merge request.
This commit updates the tarball-create job to enable the maintainer
mode, then clean all maintainer files (`make maintainer-clean`) rebuild
all the file from scratch and compare the result which must be a clean
git directory.
2020-08-24 14:40:39 +02:00
Ondřej Surý
62971d4a3c
Merge branch 'ondrej/update-readline-support-fix' into 'main'
...
Add missing support for --with-readline=yes
See merge request isc-projects/bind9!3984
2020-08-24 11:39:18 +00:00
Michal Nowak
727272934e
editline's pkg-config name is libeditline
2020-08-24 09:11:47 +02:00
Michal Nowak
bc1c0d2ef4
Make sure readline configuration works
2020-08-24 09:11:47 +02:00
Ondřej Surý
713b77c70e
Add missing support for --with-readline=yes
...
By error, ./configure --with-readline would fail, because 'yes' wasn't
handled properly in the top level case.
2020-08-24 09:11:47 +02:00
Ondřej Surý
41c9a5e428
Merge branch 'ondrej/add-notes-current.rst-to-util-copyright' into 'main'
...
Update util/copyright to include doc/notes/notes-current.rst
See merge request isc-projects/bind9!4002
2020-08-24 07:10:22 +00:00
Ondřej Surý
334350a75a
Update util/copyright to include doc/notes/notes-current.rst
2020-08-24 09:06:13 +02:00
Michal Nowak
3df3dadaf2
Merge branch 'mnowak/update_BIND_BASELINE_VERSION_to_v9_17_4' into 'main'
...
Update BIND_BASELINE_VERSION to v9_17_4
See merge request isc-projects/bind9!3999
2020-08-21 09:22:09 +00:00
Michal Nowak
1b1b11a3fe
Update BIND_BASELINE_VERSION to v9_17_4
2020-08-21 11:10:36 +02:00
Evan Hunt
d7362ff16d
Merge tag 'v9_17_4' into main
...
BIND 9.17.4
2020-08-20 12:05:01 -07:00
Mark Andrews
ac67436758
Merge branch '2077-negative-hook-point-value-in-filter-aaaa-c' into 'main'
...
Resolve "negative hook point value in filter-aaaa.c"
Closes #2077
See merge request isc-projects/bind9!3985
2020-08-19 00:17:05 +00:00
Mark Andrews
2fd5ba6507
Remove stray '-' from filter-aaaa initialisation
2020-08-19 09:21:59 +10:00
Ondřej Surý
e51c8613e4
Merge branch 'ondrej/dns_rdata_fromwire_text-corpus-update' into 'main'
...
Expand, but minimize (tmin, cmin) dns_rdata_fromwire_text corpus
See merge request isc-projects/bind9!3981
2020-08-18 15:44:11 +00:00
Ondřej Surý
df26656e4b
Expand, but minimize (tmin, cmin) dns_rdata_fromwire_text corpus
2020-08-18 16:39:23 +02:00
Ondřej Surý
2a8c0282da
Merge branch 'marka-fuzz-consolidated' into 'main'
...
Consolidated fuzz fixes
See merge request isc-projects/bind9!3975
2020-08-18 09:07:47 +00:00
Ondřej Surý
62c448beaf
Merge branch 'ondrej/update-readline-support' into 'main'
...
Update and cleanup the readline library support
See merge request isc-projects/bind9!3942
2020-08-18 09:05:51 +00:00
Mark Andrews
8452404bd7
A6: return FORMERR in fromwire if bits are non zero.
...
oss_fuzz: Issue 24864: bind9:dns_rdata_fromwire_text_fuzzer: Overwrites-const-input in dns_rdata_fromwire_text_fuzzer
2020-08-18 11:04:05 +02:00
Mark Andrews
f6d7b8c20d
RRSIG: reject records with empty SIG section
2020-08-18 11:04:05 +02:00
Mark Andrews
3e743da1bd
Disable compression in dns_rdata_fromwire_text()
2020-08-18 11:04:05 +02:00
Mark Andrews
aa811801cb
dns_rdata_fromwire() only accepts input up to 2^16-1 octets.
2020-08-18 11:04:05 +02:00
Mark Andrews
e4d30cb007
Print out input if dns_rdata_fromtext() fails in debug mode.
2020-08-18 11:04:05 +02:00