Mark Andrews
b089f43b7a
Check multi-line output from dns_rdata_tofmttext()
...
Check that multi-line output from dns_rdata_tofmttext() can be read
back in by dns_rdata_fromtext().
2019-04-11 19:19:46 +10:00
Mark Andrews
1a75a5cee6
Process master file comments and make input invalid again
2019-04-11 19:19:10 +10:00
Mark Andrews
7941a9554f
Set 'specials' to match 'specials' in 'lib/dns/master.c'
2019-04-11 18:13:39 +10:00
Mark Andrews
cc5e16e4d3
Fix whitespace so that the names align
2019-04-11 18:13:39 +10:00
Mark Andrews
36f30f5731
Add dns_rdata_totext() and dns_rdata_fromtext() to fromwire
...
Add dns_rdata_totext() and dns_rdata_fromtext() to fromwire for
valid inputs to ensure that what we accept in dns_rdata_fromwire()
can be written out and read back in.
2019-04-11 18:13:39 +10:00
Mark Andrews
961d256d73
Merge branch '965-delv-prints-weird-ttl-values-2' into 'master'
...
Test that dig and delve print correct TTL values.
Closes #965
See merge request isc-projects/bind9!1782
2019-04-10 01:24:44 -04:00
Mark Andrews
dfc485b02e
add CHANGES
2019-04-10 15:06:54 +10:00
Matthijs Mekking
195277ca6d
Check dig TTLs.
...
This also fixes a bug in the tests ($n was not incremented in one
place).
2019-04-10 15:06:13 +10:00
Mark Andrews
146202d6a8
Check delv TTLs.
2019-04-10 15:06:13 +10:00
Mark Andrews
68851ddb76
Merge branch '965-delv-prints-weird-ttl-values' into 'master'
...
Initialise view->mincachettl and view->minncachettl to zero in dns_view_create.
Closes #965
See merge request isc-projects/bind9!1760
2019-04-10 01:04:24 -04:00
Mark Andrews
538da8c80d
Add CHANGES.
2019-04-10 14:49:28 +10:00
Mark Andrews
8fd4308bda
Initialise mincachettl and minncachettl to zero in dns_view_create.
2019-04-10 14:48:49 +10:00
Mark Andrews
0fb2cf1e44
Merge branch '899-enforce-hash-in-ds' into 'master'
...
enforce DS hash exists
See merge request isc-projects/bind9!1575
2019-04-10 00:40:14 -04:00
Mark Andrews
97b7360ce1
add CHANGES
2019-04-10 13:39:51 +10:00
Mark Andrews
6eb28eda1e
add ds unit test
2019-04-10 13:37:03 +10:00
Mark Andrews
b274f3fad7
enforce DS hash exists
2019-04-10 13:36:08 +10:00
Mark Andrews
a32a4ed945
Merge branch '852-run-fromtext-through-fromwire' into 'master'
...
check that from fromtext produces valid towire input
Closes #852
See merge request isc-projects/bind9!1738
2019-04-09 21:27:48 -04:00
Mark Andrews
d712b88048
add CHANGES
2019-04-10 11:16:55 +10:00
Mark Andrews
7b0a653858
check that from fromtext produces valid towire input
2019-04-10 11:13:52 +10:00
Ondřej Surý
cd68cfffbf
Merge branch '971-downgrade-DLZ_DBCLIENTINFO_VERSION-in-dlz_minimal.h' into 'master'
...
Downgrade the dns_clientinfo_t structure to not contain dbversion
Closes #971
See merge request isc-projects/bind9!1773
2019-04-09 15:24:37 -04:00
Ondřej Surý
a6f09b2255
Downgrade the dns_clientinfomethod structure to the version in lib/dns/clientinfo.c
2019-04-09 10:06:12 +01:00
Mark Andrews
43828818a4
Merge branch '899-fromwire-check-flags-for-nokey' into 'master'
...
Check KEY flags for empty key in fromwire method
See merge request isc-projects/bind9!1574
2019-04-09 00:16:00 -04:00
Mark Andrews
f78c688c4f
add CHANGES
2019-04-09 13:56:05 +10:00
Mark Andrews
82d4931440
for rkey flags MUST be zero
2019-04-09 13:55:30 +10:00
Mark Andrews
2592e91516
check flags for no key in fromwire for *KEY
2019-04-09 13:55:30 +10:00
Mark Andrews
629b978fd8
Merge branch '976-dns-ecs-h-missing-isc_lang_enddecls' into 'master'
...
Resolve "dns/ecs.h missing ISC_LANG_ENDDECLS"
Closes #976
See merge request isc-projects/bind9!1774
2019-04-08 21:59:30 -04:00
Mark Andrews
698a6f955e
<dns/ecs.h> was missing ISC_LANG_ENDDECLS.
2019-04-09 11:47:26 +10:00
Evan Hunt
27d788cff3
Merge branch '973-pause-dbiterator-in-rpz' into 'master'
...
Fix deadlock in RPZ update code.
Closes #973
See merge request isc-projects/bind9!1770
2019-04-06 15:23:37 -04:00
Witold Kręcicki
06021b3529
Fix deadlock in RPZ update code.
...
In dns_rpz_update_from_db we call setup_update which creates the db
iterator and calls dns_dbiterator_first. This unpauses the iterator and
might cause db->tree_lock to be acquired. We then do isc_task_send(...)
on an event to do quantum_update, which (correctly) after each iteration
calls dns_dbiterator_pause, and re-isc_task_sends itself.
That's an obvious bug, as we're holding a lock over an async task send -
if a task requesting write (e.g. prune_tree) is scheduled on the same
workers queue as update_quantum but before it, it will wait for the
write lock indefinitely, resulting in a deadlock.
To fix it we have to pause dbiterator in setup_update.
2019-04-06 12:22:49 -07:00
Evan Hunt
b22a5b6fac
Merge branch 'placeholder' into 'master'
...
placeholder
See merge request isc-projects/bind9!1771
2019-04-06 15:20:51 -04:00
Evan Hunt
610d13b456
placeholder
2019-04-06 12:20:16 -07:00
Michał Kępień
23e6a908df
Merge branch '893-do-not-rely-on-default-dig-options-in-system-tests' into 'master'
...
Do not rely on default dig options in system tests
Closes #893
See merge request isc-projects/bind9!1556
2019-04-03 07:21:56 -04:00
Michał Kępień
b6cce0fb8b
Do not rely on default dig options in system tests
...
Some system tests assume dig's default setings are in effect. While
these defaults may only be silently overridden (because of specific
options set in /etc/resolv.conf) for BIND releases using liblwres for
parsing /etc/resolv.conf (i.e. BIND 9.11 and older), it is arguably
prudent to make sure that tests relying on specific +timeout and +tries
settings specify these explicitly in their dig invocations, in order to
prevent test failures from being triggered by any potential changes to
current defaults.
2019-04-03 12:57:33 +02:00
Witold Krecicki
7e069cb16a
Merge branch '966-resume-qmin-shuttingdown' into 'master'
...
Fix high load race crash in resolver code
Closes #966
See merge request isc-projects/bind9!1757
2019-03-29 11:22:57 -04:00
Witold Kręcicki
d11791e24c
CHANGES
2019-03-29 15:53:17 +01:00
Witold Kręcicki
7c960e89ea
In resume_qmin check if the fetch context is already shutting down - if so, try to destroy it, don't continue
2019-03-29 14:30:40 +01:00
Mark Andrews
e9771830b8
Merge branch '920-see-problem-when-multiple-sigs-with-besteffort-parsing' into 'master'
...
Address problems with best effort parsing.
Closes #920
See merge request isc-projects/bind9!1606
2019-03-26 06:30:12 -04:00
Mark Andrews
b779342017
add CHANGES
2019-03-26 21:18:19 +11:00
Witold Kręcicki
51a55ddbb7
Fix assertion failure in nslookup/dig/mdig when message has multiple SIG(0) options.
...
When parsing message with DNS_MESSAGE_BESTEFFORT (used exclusively in
tools, never in named itself) if we hit an invalid SIG(0) in wrong
place we continue parsing the message, and put the sig0 in msg->sig0.
If we then hit another sig0 in a proper place we see that msg->sig0
is already 'taken' and we don't free name and rdataset, and we don't
set seen_problem. This causes an assertion failure.
This fixes that issue by setting seen_problem if we hit second sig0,
tsig or opt, which causes name and rdataset to be always freed.
2019-03-26 21:15:00 +11:00
Mark Andrews
b01ed54bad
Merge branch '955-make-install-fails-after-configure-with-dlopen-no' into 'master'
...
Resolve "`make install` fails after ./configure --with-dlopen=no"
Closes #955
See merge request isc-projects/bind9!1742
2019-03-26 04:52:40 -04:00
Mark Andrews
bd670d4a04
add CHANGES
2019-03-26 19:38:56 +11:00
Mark Andrews
cd3593c38d
fix plugin installation
2019-03-26 19:38:13 +11:00
Ondřej Surý
d089387d7f
Merge branch '4-make-dnstap.pb-c.h-private' into 'master'
...
Make lib/dns/dnstap.pb-c.h header a private to lib/dns
See merge request isc-projects/bind9!1744
2019-03-22 06:58:02 -04:00
Ondřej Surý
8ccce7e24b
Make lib/dns/dnstap.pb-c.h private header
...
This changes dns_dtdata struct to not expose data types from dnstap.pb-c.h to
prevent the need for including this header where not really needed.
2019-03-22 11:38:45 +01:00
Evan Hunt
d0cda3dc83
Merge branch '913-allow-update' into 'master'
...
restore inheritance of 'allow-update' and 'allow-update-forwarding'
Closes #913
See merge request isc-projects/bind9!1720
2019-03-22 03:10:17 -04:00
Evan Hunt
55a7961cf3
CHANGES, release notes
2019-03-21 21:17:50 -07:00
Evan Hunt
91dca0f8da
don't fail when allow-update{,-forwarding} is used globally
2019-03-21 21:17:49 -07:00
Mark Andrews
11c862efff
Merge branch '899-zonemd-check-for-hash-existence' into 'master'
...
zonemd require non empty hash
Closes #899
See merge request isc-projects/bind9!1739
2019-03-21 15:50:29 -04:00
Mark Andrews
e1db1b8dcb
add CHANGES
2019-03-22 06:49:09 +11:00
Mark Andrews
473987d8d9
Disallow empty ZONEMD hashes
...
This change is the result of discussions with the authors of
draft-wessels-dns-zone-digest.
2019-03-22 06:49:01 +11:00