2
0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 22:15:20 +00:00
Commit Graph

42652 Commits

Author SHA1 Message Date
Petr Špaček
ddbcf9192c Port dnstap test to use isctest utilities
(cherry picked from commit f176acdfcc)
2025-05-28 11:17:30 +00:00
Evan Hunt
7f0f7168d0 [9.20] fix: nil: correct the DbC assertions in message.c
the comments for some calls in the dns_message API specified
requirements which were not actually enforced in the functions.
in most cases, this has now been corrected by adding the missing
REQUIREs. in one case, the comment was incorrect and has been
revised.

Backport of MR !10466

Merge branch 'backport-each-fix-message-requires-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!10484
2025-05-28 00:21:07 +00:00
Evan Hunt
11aa50ec83 correct the DbC assertions in message.c
the comments for some calls in the dns_message API specified
requirements which were not actually enforced in the functions.

in most cases, this has now been corrected by adding the missing
REQUIREs. in one case, the comment was incorrect and has been
revised.

(cherry picked from commit c437da59ee)
2025-05-27 16:44:24 -07:00
Nicki Křížek
2592fb319e [9.20] [CVE-2025-40775] sec: test: Add a bad TSIG algorithm hypothesis python test
Closes #5300

Backport of MR !10475

Merge branch 'backport-5300-tsig-unknown-alg-test-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!10476
2025-05-23 12:10:31 +00:00
Nicki Křížek
e77b1275a0 Add a bad TSIG algorithm hypothesis python test
Co-authored-by: Petr Špaček <pspacek@isc.org>
(cherry picked from commit 96b0621de4)
2025-05-23 11:31:42 +00:00
Michał Kępień
6ba6648935 Merge tag 'v9.20.9' into bind-9.20 2025-05-21 21:24:23 +02:00
Arаm Sаrgsyаn
a24db6433e [9.20] new: usr: Implement a new 'notify-defer' configuration option
This new option sets a delay (in seconds) to wait before sending
a set of NOTIFY messages for a zone. Whenever a NOTIFY message is
ready to be sent, sending will be deferred for this duration. This
option is not to be confused with the :any:`notify-delay` option.
The default is 0 seconds.

Closes #5259

Backport of MR !10419

Merge branch 'backport-5259-implement-zone-notify-defer-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!10465
2025-05-16 13:23:04 +00:00
Aram Sargsyan
a90e3b9e6f Implement a new 'notify-defer' configuration option
This new option sets the delay, in seconds, to wait before sending
a set of NOTIFY messages for a zone. Whenever a NOTIFY message is
ready to be sent, sending will be deferred for this duration.

(cherry picked from commit e42d6b4810)
2025-05-16 09:58:48 +00:00
Aram Sargsyan
0dd96098f9 Update the dns_zone_setnotifydelay() function's documentation
Add a note that the delay is in seconds.

(cherry picked from commit d79b14ff5d)
2025-05-15 13:29:13 +00:00
Aram Sargsyan
53c9817b29 Delete the unused dns_zone_getnotifydelete() function
The function is unused, delete it.

(cherry picked from commit 62f66c0be0)
2025-05-15 13:29:13 +00:00
Arаm Sаrgsyаn
832ab721bb [9.20] fix: test: Fix catz system test errors
Backport of MR !10444

Merge branch 'backport-aram/catz-system-test-errors-fix-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!10464
2025-05-15 13:26:17 +00:00
Aram Sargsyan
cdd8f5f966 Fix more catz system test errors
A quick grep check discovered a couple of more errors similar to the
one fixed in the previous commit. Fix them too.

(cherry picked from commit 52ac03f064)
2025-05-15 12:20:19 +00:00
Aram Sargsyan
1930dbf749 Fix catz system test error
The '|| ret=1' is omitted from the check. This was introduced in the
b171cacf4f commit. Fix the error.

(cherry picked from commit f200b1ac18)
2025-05-15 12:20:19 +00:00
Michał Kępień
5290dd3528 [9.20] chg: test: Mark test_idle_timeout as flaky on FreeBSD 13
The test_idle_timeout check in the "timeouts" system test has been
failing often on FreeBSD 13 AWS hosts.  Adding timestamped debug logging
shows that the time.sleep() calls used in that check are returning
significantly later than asked to on that platform (e.g. after 4 seconds
when just 1 second is requested), breaking the test's timing assumptions
and triggering false positives.  These failures are not an indication of
a bug in named and have not been observed on any other platform.  Mark
the problematic check as flaky, but only on FreeBSD 13, so that other
failure modes are caught appropriately.

Backport of MR !10459

Merge branch 'backport-michal/mark-test_idle_timeout-as-flaky-on-freebsd-13-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!10461
2025-05-14 17:57:59 +00:00
Michał Kępień
9e6c8f1637 Mark test_idle_timeout as flaky on FreeBSD 13
The test_idle_timeout check in the "timeouts" system test has been
failing often on FreeBSD 13 AWS hosts.  Adding timestamped debug logging
shows that the time.sleep() calls used in that check are returning
significantly later than asked to on that platform (e.g. after 4 seconds
when just 1 second is requested), breaking the test's timing assumptions
and triggering false positives.  These failures are not an indication of
a bug in named and have not been observed on any other platform.  Mark
the problematic check as flaky, but only on FreeBSD 13, so that other
failure modes are caught appropriately.

(cherry picked from commit cb76b3729e)
2025-05-14 17:18:53 +00:00
Michal Nowak
551967f410 [9.20] rem: ci: Drop Ubuntu 20.04 Focal Fossa
Focal-specific ./configure options were moved to Jammy.

Backport of MR !9899

Merge branch 'backport-mnowak/drop-ubuntu-focal-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!10455
2025-05-13 17:25:31 +00:00
Michal Nowak
3682ccecb5 Revert "Ignore .hypothesis files created by system tests"
This reverts commit f413ddbe5f.

(cherry picked from commit 84c565878e)
2025-05-13 16:26:24 +00:00
Michal Nowak
37cd7daf13 Make FreeBSD 12.x part of Community-Maintained platforms
(cherry picked from commit ff39441874)
2025-05-13 16:26:24 +00:00
Michal Nowak
c9b79d0a77 Drop Ubuntu 20.04 Focal Fossa
Focal-specific ./configure options were moved to Jammy.

(cherry picked from commit 326e19a65a)
2025-05-13 16:26:24 +00:00
Michał Kępień
24870ca4ea chg: doc: Set up version for BIND 9.20.10
Merge branch 'michal/set-up-version-for-bind-9.20.10' into 'bind-9.20'

See merge request isc-projects/bind9!10452
2025-05-12 18:38:56 +00:00
Michał Kępień
07297e0e60 Update BIND version to 9.20.10-dev 2025-05-12 20:24:39 +02:00
Michał Kępień
98f2a5b7f4 Update BIND version for release v9.20.9 2025-05-08 23:10:54 +02:00
Michał Kępień
c70bb7aa06 new: doc: Prepare documentation for BIND 9.20.9
Merge branch 'michal/prepare-documentation-for-bind-9.20.9' into 'v9.20.9-release'

See merge request isc-private/bind9!797
2025-05-08 21:08:05 +00:00
Michał Kępień
a2fdb1a5d6 Reorder release notes 2025-05-08 22:53:43 +02:00
Michał Kępień
51dee8510c Tweak and reword release notes 2025-05-08 22:53:43 +02:00
Michał Kępień
58f6b1aac5 Prepare release notes for BIND 9.20.9 2025-05-08 22:53:43 +02:00
Michał Kępień
4d92246e63 Generate changelog for BIND 9.20.9 2025-05-08 22:53:43 +02:00
Michał Kępień
b8c198ac5c [9.20] [CVE-2025-40775] sec: usr: Prevent assertion when processing TSIG algorithm
DNS messages that included a Transaction Signature (TSIG) containing an
invalid value in the algorithm field caused :iscman:`named` to crash
with an assertion failure. This has been fixed.  :cve:`2025-40775`

Backport of !793

See isc-projects/bind9#5300

Merge branch '5300-confidential-tsig-unknown-alg-bind-9.20' into 'v9.20.9-release'

See merge request isc-private/bind9!795
2025-05-07 11:46:13 +00:00
Evan Hunt
12d13ff071 Prevent assertion when processing TSIG algorithm
In a previous change, the "algorithm" value passed to
dns_tsigkey_create() was changed from a DNS name to an integer;
the name was then chosen from a table of known algorithms. A
side effect of this change was that a query using an unknown TSIG
algorithm was no longer handled correctly, and could trigger an
assertion failure.  This has been corrected.

The dns_tsigkey struct now stores the signing algorithm
as dst_algorithm_t value 'alg' instead of as a dns_name,
but retains an 'algname' field, which is used only when the
algorithm is DST_ALG_UNKNOWN.  This allows the name of the
unrecognized algorithm name to be returned in a BADKEY
response.

(cherry picked from commit decf461d68846d6754c1f64790c3f9006d158a1d)
2025-05-07 13:45:48 +02:00
Michał Kępień
8c3b226d89 [9.20] fix: usr: Fix EDNS yaml output
`dig` was producing invalid YAML when displaying some EDNS options. This has been corrected.

Several other improvements have been made to the display of EDNS option data:
- We now use the correct name for the UPDATE-LEASE option, which was previously displayed as "UL", and split it into separate LEASE and LEASE-KEY components in YAML mode.
- Human-readable durations are now displayed as comments in YAML mode so as not to interfere with machine parsing.
- KEY-TAG options are now displayed as an array of integers in YAML mode.
- EDNS COOKIE options are displayed as separate CLIENT and SERVER components, and cookie STATUS is a retrievable variable in YAML mode.

Closes #5014

Backport of MR !9695

Merge branch 'backport-5014-improve-edns-yaml-processing-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!10414
2025-05-07 07:40:45 +00:00
Mark Andrews
ca125dca24 Fix the error handling of put_yamlstr calls
The return value was sometimes being ignored when it shouldn't
have been.

(cherry picked from commit c0fcb9fd0e)
2025-05-07 00:00:10 -07:00
Mark Andrews
c3ec565f74 Fix a typo in a test description
The test description "checking delv -c CH is ignored, and
treated like IN" in digdelv was garbled.

(cherry picked from commit 5424b30d7a)
2025-05-07 00:00:10 -07:00
Mark Andrews
75ef402296 Check EDNS CLIENT-TAG and SERVER-TAG are emitted using valid YAML
Check that when an EDNS CLIENT-TAG or EDNS SERVER-TAG option is
present in the message, the emitted YAML is valid.

(cherry picked from commit 2efb15b54a)
2025-05-07 00:00:10 -07:00
Mark Andrews
082f22b2ff Check EDNS EXPIRE option is emitted using valid YAML
Check that when an EDNS EXPIRE option is present in the message,
the emitted YAML is valid.

(cherry picked from commit e611e2044a)
2025-05-07 00:00:10 -07:00
Mark Andrews
c0748d071f Check EDNS CLIENT-SUBNET option is emitted using valid YAML
Check that when there is an EDNS CLIENT-SUBNET option in the
message, the emitted YAML is valid.

(cherry picked from commit 641ca9044f)
2025-05-07 00:00:10 -07:00
Mark Andrews
93be5d085a Split EDNS COOKIE YAML into separate parts
Split the YAML display of the EDNS COOKIE option into CLIENT and SERVER
parts.  The STATUS of the EDNS COOKIE in the reply is now a YAML element
rather than a comment.

(cherry picked from commit 5eeb31f0b9)
2025-05-07 00:00:10 -07:00
Mark Andrews
d5b9e6790f Fix EDNS TCP-KEEPALIVE option YAML output
There was missing white space between the option name and its value.

(cherry picked from commit 07c28652a3)
2025-05-07 00:00:10 -07:00
Mark Andrews
246fadfef2 Fix EDNS LLQ option YAML output
The EDNS LLQ option was not being emitted as valid YAML. Correct
the output to be valid YAML with each field of the LLQ being
individually selectable.

(cherry picked from commit 81334113c3)
2025-05-07 00:00:10 -07:00
Mark Andrews
758f5e6892 Change the EDNS KEY-TAG YAML output format
When using YAML, print the EDNS KEY-TAG as an array of integers
for easier machine parsing. Check the validity of the YAML output.

(cherry picked from commit 27e8732c17)
2025-05-07 00:00:10 -07:00
Mark Andrews
b02ff4c501 Use YAML comments for durations rather than parentheses
This will allow the values to be parsed using standard yaml processing
tools, and still provide the value in a human friendly form.

(cherry picked from commit 378bc7cfa6)
2025-05-07 00:00:10 -07:00
Mark Andrews
09893287c2 Change the name and YAML format of EDNS UL
The offical EDNS option name for "UL" is "UPDATE-LEASE".  We now
emit "UPDATE-LEASE" instead of "UL", when printing messages, but
"UL" has been retained as an alias on the command line.

Update leases consist of 1 or 2 values, LEASE and KEY-LEASE.  These
components are now emitted separately so they can be easily extracted
from YAML output.  Tests have been added to check YAML correctness.

(cherry picked from commit 68cdc4774c)
2025-05-07 00:00:10 -07:00
Mark Andrews
44fc37033e Add YAML escaping where needed
When rendering text, such as domain names or the EXTRA-TEXT
field of the EDE option, backslashes and quotation marks must
be escaped to ensure that the emitted message is valid YAML.

(cherry picked from commit 280e9b7cf4)
2025-05-07 00:00:10 -07:00
Mark Andrews
145029782d Collapse common switch cases when emitting EDNS options
The CHAIN and REPORT-CHANNEL EDNS options are both domain names, so they
can be combined.  THE CLIENT-TAG and SERVER-TAG EDNS options are both 16
bit integers, so they can be combined.

(cherry picked from commit e7ef4e41eb)
2025-05-07 00:00:10 -07:00
Evan Hunt
858b3f763b refactor, add missing EDNS options, and fix option names
some EDNS option names, including DAU, DHU, N3U, and CHAIN,
were not printed in dns_message_pseudosectiontotext() or
_psuedosectiontoyaml(); they were displayed as unknown options.
this has been corrected.

that code was also refactored to use switch instead of if/else,
and to look up the option code names in a table to prevent
inconsistencies between the two formats. one such inconsistency
was corrected: the "TCP-KEEPALIVE" option is now always printed
with a hyphen, instead of being "TCP KEEPALIVE" when not using
YAML. the keepalive system test has been updated to expect this.

EDNS options that print DNS names (i.e., CHAIN and Report-Channel)
now enclose them in quotation marks to ensure YAML correctness.
the auth system test has been updated to expect this when grepping
for Report-Channel options.

(cherry picked from commit e2393ba27b)
2025-05-07 00:00:10 -07:00
Evan Hunt
b202ecc7ca add missing EDNS option mnemonics to dig
Report-Channel and ZONEVERSION EDNS options can now be sent
using `dig +ednsopt=report-channel` (or `dig +ednsopt=rc` for
short), and `dig +ednsopt=zoneversion`.

(cherry picked from commit c30754f28b)
2025-05-07 00:00:10 -07:00
Michał Kępień
ac41f158fa fix: usr: Revert NSEC3 closest encloser lookup improvements
The performance improvements for NSEC3 closest encloser lookups that
were restored in BIND 9.20.8 turned out to cause incorrect NSEC3 records
to be returned in nonexistence proofs and were therefore reverted again.

Closes #5292

Merge branch '5292-revert-nsec3-closest-encloser-lookup-improvements' into 'bind-9.20'

See merge request isc-projects/bind9!10443
2025-05-07 06:33:04 +00:00
Michał Kępień
5df876e968 Revert "Use a binary search to find the NSEC3 closest encloser"
This reverts commit ae718fab53.
2025-05-06 09:14:18 +02:00
Michał Kępień
d0e0706797 Revert "qpzone find() function could set foundname incorrectly"
This reverts commit dd1050e938.
2025-05-06 09:14:18 +02:00
Michał Kępień
e6a9a68f42 Revert "rbtdb zone find() function could set foundname incorrectly"
This reverts commit 2025ba8f7a.
2025-05-06 09:14:18 +02:00
Michał Kępień
8ea0c1d92b Revert "detect when closest-encloser name is too long"
This reverts commit 1f4ba71f56.
2025-05-06 09:14:18 +02:00