Ondřej Surý
f95e4593ed
Remove isc-hmac-fixup.exe remains from win32util/Configure
2018-11-09 01:48:52 +07:00
Ondřej Surý
c303cf5cc9
Merge branch '305-misc-fixes' into 'master'
...
Miscellaneous style fixes - implicit casts to bool and uninitialized variables fixes
Closes #305
See merge request isc-projects/bind9!851
2018-11-08 02:03:07 -05:00
Ondřej Surý
68ca987792
Remove dummy ISLOCKED macro
2018-11-08 12:22:26 +07:00
Ondřej Surý
23fff6c569
Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached
2018-11-08 12:22:17 +07:00
Ondřej Surý
b992b5b811
Modify the dbversion_test.c to detect disabled assertions
2018-11-08 12:22:17 +07:00
Ondřej Surý
29c45200e7
Add extra return failure after INSIST(0) in default branch
2018-11-08 12:22:17 +07:00
Ondřej Surý
4eaf927571
Use larger buffers on snprintf buffer overflow false positives
2018-11-08 12:21:53 +07:00
Ondřej Surý
e2e138a801
Don't assert on failed getrlimit call to allow called to handle this gracefully as it already does, just abort where we need to know the numbers
2018-11-08 12:21:53 +07:00
Ondřej Surý
a831e0f72d
When ISC assertions are disabled, still execute the condition to prevent unused variable warnings/errors from the compiler
2018-11-08 12:21:53 +07:00
Ondřej Surý
461ffead1f
Add a GitLab CI job that runs with all assertions disabled
2018-11-08 12:21:53 +07:00
Ondřej Surý
b2b43fd235
Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool
2018-11-08 12:21:53 +07:00
Ondřej Surý
fbd2e47f51
Add small tweaks to the code to fix compilation when ISC assertions are disabled
...
While implementing the new unit testing framework cmocka, it was found that the
BIND 9 code doesn't compile when assertions are disabled or replaced with any
function (such as mock_assert() from cmocka unit testing framework) that's not
directly recognized as assertion by the compiler.
This made the compiler to complain about blocks of code that was recognized as
unreachable before, but now it isn't.
The changes in this commit include:
* assigns default values to couple of local variables,
* moves some return statements around INSIST assertions,
* adds __builtin_unreachable(); annotations after some INSIST assertions,
* fixes one broken assertion (= instead of ==)
2018-11-08 12:21:53 +07:00
Mark Andrews
8e292b3262
Merge branch 'wpk-get-rid-of-bashism-in-CDS-test' into 'master'
...
Small system tests fixes for Solaris
See merge request isc-projects/bind9!988
2018-11-07 19:41:30 -05:00
Witold Krecicki
82dfb77328
Remove unnecessary sed from autosign test
2018-11-08 00:07:00 +01:00
Witold Krecicki
0949b1fe2c
Use 'local' variable in echo functions in tests
2018-11-07 23:15:06 +01:00
Witold Kręcicki
dbf2e7928e
Get rid of bashism in CDS test
2018-11-07 23:13:47 +01:00
Ondřej Surý
3317d3d2bb
Merge branch '4-add-ac_posix_shell-m4-macro' into 'master'
...
Add AX_POSIX_SHELL autoconf macro to have POSIX-compatible shell in $SHELL
See merge request isc-projects/bind9!986
2018-11-07 15:03:44 -05:00
Ondřej Surý
601abfab30
Add CHANGES entry for AX_POSIX_SHELL
2018-11-08 02:52:19 +07:00
Ondřej Surý
b1e1dd2c25
Remove m4/ files from copyright check
2018-11-08 02:52:19 +07:00
Ondřej Surý
54ff27a6bc
Add and use AX_POSIX_SHELL autoconf macro, so we can rely on POSIX shell features
2018-11-08 02:52:19 +07:00
Ondřej Surý
cd6c016896
Merge branch 'wpk-fix-typo-thread-c' into 'master'
...
Fix a typo in lib/isc/unix/thread.c
See merge request isc-projects/bind9!990
2018-11-07 14:40:08 -05:00
Witold Kręcicki
ce478b4fc9
Fix a typo in lib/isc/unix/thread.c
2018-11-07 19:31:06 +00:00
Witold Krecicki
7a2248acf9
Merge branch '650-fix-race-in-dig' into 'master'
...
Add some DBC checks in dighost; fix race between clear_query and send_done in dighost
Closes #650
See merge request isc-projects/bind9!965
2018-11-07 13:04:13 -05:00
Witold Krecicki
e9bf8e4798
Add some DBC checks in dighost; fix race between clear_query and send_done in dighost
2018-11-07 13:04:13 -05:00
Witold Krecicki
319c166a50
Merge branch 'wpk-multiple-task-queues' into 'master'
...
Multiple task queues
See merge request isc-projects/bind9!878
2018-11-06 04:44:34 -05:00
Witold Kręcicki
b673f509d2
CHANGES note
2018-11-06 08:24:22 +00:00
Witold Kręcicki
9a903789ed
Use larger quantum for network tasks
2018-11-06 08:19:50 +00:00
Witold Kręcicki
460c8038c1
Use a single wake_all_queues() function to wake all queues
2018-11-06 08:19:50 +00:00
Witold Kręcicki
b3827319e0
Switch from privileged to un-privileged mode under lock
2018-11-06 08:19:50 +00:00
Witold Kręcicki
f166cabcae
Document isc_task_sendto properly, make sure that cpu we're sending to is always sane
2018-11-06 08:19:50 +00:00
Witold Kręcicki
025c74adee
Use proper memory ordering for tasks_running/tasks_ready
2018-11-06 08:19:50 +00:00
Witold Kręcicki
8fb5bc783f
Comment about taskmgr exclusive mode, fix a REQUIRE.
2018-11-06 08:19:50 +00:00
Witold Kręcicki
152c437bb8
Allow slight over-quota in'checking lame server clients are dropped at the soft limit' test
2018-11-06 08:19:50 +00:00
Witold Kręcicki
913856911a
Saner exclusive task handling in taskmgr
2018-11-06 08:19:50 +00:00
Witold Kręcicki
17d46fd48b
Formatting
2018-11-06 08:19:50 +00:00
Witold Kręcicki
c80e25e482
Get rid of isc_taskmgr_setmode, we only use it to set privileged mode
2018-11-06 08:19:50 +00:00
Witold Kręcicki
64020dd7bc
Make sure all priority tasks are done before entering normal execution
2018-11-06 08:19:50 +00:00
Witold Kręcicki
669a694d3b
Post shutting down tasks always to manager 0
2018-11-06 08:19:50 +00:00
Witold Kręcicki
c416389d32
Separate structure for each thread/queue; 2-phase-locking for exclusive tasks
2018-11-06 08:19:50 +00:00
Witold Kręcicki
818d63a3a1
Always restart dispatchers on empty readyq
2018-11-06 08:19:50 +00:00
Witold Kręcicki
d7be8afea5
Taskmgr shutdown fixes
2018-11-06 08:19:50 +00:00
Witold Kręcicki
81a85070c5
Multiple worker queues
2018-11-06 08:19:50 +00:00
Witold Krecicki
7b6721b27f
isc_thread_setaffinity()
2018-11-06 08:19:50 +00:00
Evan Hunt
151b64aa3e
Merge branch 'rndc-nta-preen' into 'master'
...
Fixes for `rndc nta` user interface
See merge request isc-projects/bind9!845
2018-11-06 01:18:32 -05:00
Evan Hunt
6298061e24
CHANGES, release note
2018-11-05 22:10:10 -08:00
Tony Finch
1b1d63acd8
Fixes for rndc nta
user interface
...
Tell the user explicitly about their mistakes:
* Unknown options, e.g. -list instead of -dump
or -delete instead of -remove.
* Unknown view names.
* Excess arguments.
Include the view name in `rndc nta -dump` output, for consistency with
the NTA add and remove actions.
When removing an NTA from all views, do not abort with an error if the
NTA was not found in one of the views.
2018-11-05 22:01:28 -08:00
Mark Andrews
95e84464b7
Merge branch '653-idnout-only-on-tty' into 'master'
...
Enable idnout output only on tty, disable it when the stdout is not a tty
Closes #653
See merge request isc-projects/bind9!973
2018-11-06 00:58:22 -05:00
Ondřej Surý
9c0c44405c
Add CHANGES entry for GL #653
2018-11-06 12:48:44 +07:00
Ondřej Surý
2a11a7dd29
Add release notes for IDN processing update
2018-11-06 12:48:08 +07:00
Ondřej Surý
b659765869
Update the IDN documentation for nslookup
2018-11-06 12:48:08 +07:00