mir/criu
2
0
Fork 0
mirror of https://github.com/checkpoint-restore/criu synced 2025-08-31 14:25:49 +00:00
Code Issues Releases Wiki Activity

service: use waitpid() when a child pid is known

Browse Source 
We want to wait a specific child. wait() waits any child.

Signed-off-by: Andrei Vagin <avagin@gmail.com>
This commit is contained in:
Andrei Vagin
2018-10-15 19:16:13 +03:00
parent e4d8dc6f29
commit 8517bc7d27
1 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
criu/cr-service.c
View File

@@ -753,10 +753,11 @@ cout:
exit(ret);
}
wait(&status);
if (!WIFEXITED(status))
if (waitpid(pid, &status, 0) != pid) {
pr_perror("Unable to wait %d", pid);
goto out;
if (WEXITSTATUS(status) != 0)
}
if (status != 0)
goto out;
success = true;
@@ -842,7 +843,10 @@ out_ch:
close(start_pipe[1]);
if (daemon_mode) {
wait(&ret);
if (waitpid(pid, &ret, 0) != pid) {
pr_perror("Unable to wait %d", pid);
goto out;
}
if (WIFEXITED(ret)) {
if (WEXITSTATUS(ret)) {
pr_err("Child exited with an error\n");
@@ -990,20 +994,14 @@ static int handle_feature_check(int sk, CriuReq * msg)
* be send from the parent process.
*/
ret = send_criu_msg(sk, &resp);
exit(ret);
}
ret = waitpid(pid, &status, 0);
if (ret == -1)
if (waitpid(pid, &status, 0) != pid) {
pr_perror("Unable to wait %d", pid);
goto out;
}
if (status != 0)
goto out;
if (WIFEXITED(status) && !WEXITSTATUS(status))
/*
* The child process exited was able to send the answer.
* Nothing more to do here.
*/
return 0;
/*
* The child process was not able to send an answer. Tell
@@ -1070,7 +1068,10 @@ cout:
exit(ret);
}
wait(&status);
if (waitpid(pid, &status, 0) != pid) {
pr_perror("Unable to wait %d", pid);
goto out;
}
if (!WIFEXITED(status))
goto out;
switch (WEXITSTATUS(status)) {