Information about pipe's file structs saved in one global file and
fdinfo_entry is saved for each descriptor
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
[ xemul: I don't know how to make this with incremental changes either,
and just go with it :( ]
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
* create pipe
* write a maximum amount of data
* suspend/resume
* check that all data have been restored
Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This maybe not 100% correct in the generic case, but the way unix sockets are
used lets us do this trick.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
No need in separate per-type fn for doing this. We can just
find the respective fd list and do sorting in the generic code.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Since proc_parse.h declares functions which have
list_head as arguments, it should include list.h
and basic types.
Otherwise if included into the files without list support
the compilation might fail as
|
| In file included from cr-check.c:5:
| ./include/proc_parse.h:83: error: expected declaration specifiers or ‘...’ before ‘bool’
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
The ability to set PR_SET_MM_AUXV is implemented
in kernel as a separate PR_SET_MM extension, so
we need to test if the kernel patch is applied
on a running system.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
All these files are now properly prepared by the parasite
invocation code by using open_image calls.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Collect pstree_item-s on restore in big list. This lets
us not lseek this file on restore and simplifies the code
a little.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
In commit 71cc2733a7
I occasionally dropped the ability to abort on waiting
(because we used signed -1 value to inform waiters that
something is wrong and waiting should be aborted, but
the type was changed to unsigned one and as result
this condition never triggers).
So to resolve it futex_abort_and_wake() is added and
should be used explicitly where appropriate instead
if signess hack.
Reported-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: Andrew Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This was required when pages were stored in elf files for
exec. Now we can stop reading it on eof.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
The list_head ptr passed into it can be converted into
the respective _info with container_of, rather than search.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Now fdinfos are collected independently from reg files and
sockets. During tihs collect we effectively create the mirroring
list of both by checking which type-IDs are added first.
Fix this by removing the fdinfo_desc and attaching fds directly
to collected reg files and sockets. Pipes and unix sockets will
be reworked in the same manner soon.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Same as prev 2 patches now for the unix sockets. They are still in per-pid image files, but
this is going to change soon (I hope).
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Instread of re-reading this image again and again on every fd restore, pull the
reg-files.img in early and store the entries in a hash. This will simplify the
further fd restoring fixes and will allow for dump/restore via a stream (socket).
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
At moment no-deps-targets is empty thus changes
in headers do not cause correspond source files
to be rebuilt. Fix it.
Reported-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This object file will be handled by ld script so .text
sections will be squashed into one common section.
Thus no need to force these functions being always-inlined.
It's a rudiment from time when we were not using ld at
all but #include source code file itself and now this
attribute might confuse code readers since it's
unclear _why_ it's needed at all.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
There is no need for specific parasite or restorer
head sections, a general "head" one is enough.
Also .stack section is dropped since it's never used.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Otherwise I get
| sockets.c: In function ‘dump_socket’:
| sockets.c:467: error: ‘st.st_ino’ may be used uninitialized in this function
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Since kernel commit 9c501935a3 the sys/socket.h
should be included prior the linux/netlink.h.
Make it so.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
It has been used when debuggin without PTRACE_SEIZE,
not needed anymore.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
It's wrong to treat restore_thread_exec_start as arguments
area (I managed to overlook this problem in commit
014841825a) it's rather
a function start address.
The thread arguments area allocated dynamically after the
restorer blob itself.
We didn't hit any problems earlier simply because there
were a few bytes owerwritten in function prologue.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
CC: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Otherwise I'm getting error
|
| files.c: In function ‘prepare_fds’:
| files.c:329:23: error: ‘tmp’ may be used uninitialized in this function [-Werror=uninitialized]
| files.c:309:6: note: ‘tmp’ was declared here
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
It's used only to check whether we should do file re-send and verify we've served
all the cliens. This can be replaced with proper list manipulations.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Since now we have local copies of a remove FDs we can dump socket queus without entering
a parasite code. This makes the code MUCH simpler.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
We have two checks for fd being a chrdev:
One to skip stdio-s that are termilans and
The other one for any fd being a /dev/null or other special device.
Clean this a little bit.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
The statfs is not required, we now check for fd being a socket with S_IFSOCK.
The 2nd stat is just not needed, the caller provides stat info.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
This structure is actualy an fd parameter, so put it there. This will also
help with future patching.
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
