2
0
mirror of https://github.com/KDE/kdeconnect-android synced 2025-08-31 14:15:14 +00:00
Commit Graph

1648 Commits

Author SHA1 Message Date
Albert Vaca
a9ab77471e Use try-with-resources in places where it looked safe 2018-10-30 13:04:45 +01:00
Erik Duisters
b54b69032f Simplify pairing from notification
Summary: When a pairing is accepted or rejected through notification actions a new DeviceFragment was created but this fragment was never actually attached to the fragment manager so not displayed to the user.

Test Plan:
Request a pairing from the desktop and Accept or Reject the pairing on Android using the notification Action buttons

When you accept the pairing the DeviceFragment should be shown for the device, the action bar title should be set to the devices name and the device should be selected in the NavigationView

When you reject the pairing the PairingFragment should be shown

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16518
2018-10-30 12:42:38 +01:00
Nicolas Fella
2bc059c4b6 Avoid hardcoded string 2018-10-29 19:58:44 +01:00
Albert Vaca
5dc02bbb75 Remove more unnecessary API version checks 2018-10-29 19:14:14 +01:00
Albert Vaca
4799cc5bbd Fixed exception when content of some notifications
Key android.title expected String but value was a android.text.SpannableString.  The default value <null> was returned.
Attempt to cast generated internal exception:
    java.lang.ClassCastException: android.text.SpannableString cannot be cast to java.lang.String
2018-10-29 19:08:47 +01:00
Nicolas Fella
a136d29ff7 Use runWithPlugin helper in SharePlugin
Summary: Depends on D16472

Test Plan:
Share file via app
Share file from external app
Share file via direct Share

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16473
2018-10-29 15:08:45 +01:00
Nicolas Fella
5dc5539e7e Add runWithPlugin helper
Summary:
There is a common pattern:
BackgroundService.RunCommand
    getDevice
    check device != null
    getPlugin
    check plugin != null
    doCode

Add a helper for this pattern and port existing code

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16472
2018-10-29 15:07:49 +01:00
Nicolas Fella
901ead5b1f Fix mobile data detection
Summary: It always returned false previously

Test Plan: I'm seeing the mobile data warning for the first time

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16445
2018-10-29 15:07:15 +01:00
l10n daemon script
cab02df704 GIT_SILENT made messages (after extraction) 2018-10-29 03:32:58 +01:00
Albert Vaca
b5d8a86c5e No need to create a stack here, as there is only one level 2018-10-28 23:11:27 +01:00
Albert Vaca
681b4bb48a Create a stack for the Mpris activity
BUG: 399343
2018-10-28 23:11:27 +01:00
Albert Vaca
6c9c8505c7 Remove unused var 2018-10-28 20:16:55 +01:00
Albert Vaca
970b50f61f Bump version code 2018-10-28 19:17:08 +01:00
Albert Vaca
24e1a95e92 startService throws if called when the app is in the background in Oreo 2018-10-28 19:17:08 +01:00
Albert Vaca
be6b108e64 Make sure the cursor is always closed 2018-10-28 19:17:08 +01:00
l10n daemon script
555e3a3f03 GIT_SILENT made messages (after extraction) 2018-10-28 02:36:52 +01:00
Albert Vaca
28a8f2131b Use the right context and SwitchCompat
As suggested by the Android guys here:

https://issuetracker.google.com/issues/118392630
2018-10-27 23:08:35 +02:00
l10n daemon script
1132ee2814 GIT_SILENT made messages (after extraction) 2018-10-27 03:43:28 +02:00
Nicolas Fella
b53f2d11bd Remove old way of device renaming 2018-10-27 01:04:34 +02:00
Nicolas Fella
0c7b970eae Add content description 2018-10-27 00:59:58 +02:00
Nicolas Fella
15a5a8d0d5 Remove unused field 2018-10-27 00:57:59 +02:00
Nicolas Fella
dfa78f7fbd Organize imports 2018-10-27 00:53:30 +02:00
Nicolas Fella
a5e6fa14d7 Do not use presized arrays 2018-10-27 00:45:05 +02:00
Nicolas Fella
2410782662 Fix XML warnings 2018-10-27 00:39:41 +02:00
Nicolas Fella
cc59b18fb2 Use ellipsis character 2018-10-27 00:24:15 +02:00
Nicolas Fella
b19039a3df Fix XML Schema 2018-10-27 00:21:52 +02:00
Nicolas Fella
4b505b38a5 Remove unneeded parameter 2018-10-27 00:02:59 +02:00
Nicolas Fella
10c552a6f4 Only use required access modifiers 2018-10-27 00:02:26 +02:00
Nicolas Fella
e1096f5bc8 Make final where possible 2018-10-27 00:01:30 +02:00
Nicolas Fella
a49a145d69 Only use required access modifiers 2018-10-26 23:59:20 +02:00
Nicolas Fella
9650660e4a Remove unneeded casts 2018-10-26 23:59:20 +02:00
Nicolas Fella
c1426584c1 Fix id 2018-10-26 23:59:20 +02:00
Simon Redman
806a929643 [Android] Add Gradle files to repository
Summary: Gradle is automatically configured by Android Studio. However, the project is troublesome to build when using other tools. Per https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:adding_wrapper, the files added by this patch ought to be included in the repository

Test Plan: After applying this diff, it should be possible to clone a fresh repository and run ./gradlew build, resulting in an .apk in ./build/outputs/apk/*/

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16439
2018-10-26 15:57:30 -06:00
Nicolas Fella
3a8cb14c19 Remove unneeded imports 2018-10-26 23:12:31 +02:00
Nicolas Fella
2d0b97d252 Simplify asserts 2018-10-26 23:11:47 +02:00
Nicolas Fella
74d2b2e828 Fix javadoc warning 2018-10-26 23:09:24 +02:00
Nicolas Fella
9e7a06f4c4 Simplify arithmetics 2018-10-26 23:03:02 +02:00
Nicolas Fella
878cc5fdb3 Replace lambda 2018-10-26 23:02:20 +02:00
Nicolas Fella
59c72c2107 Simplify asserts 2018-10-26 23:00:53 +02:00
Nicolas Fella
42f06d4b51 Remove assert. They don't do anything 2018-10-26 22:55:06 +02:00
Nicolas Fella
7a24310cea Remove unneeded version checks
We require API 14 now which makes some checks needless
2018-10-26 22:51:13 +02:00
Albert Vaca
cbd4af2378 Bump version to release as beta 2018-10-25 21:27:17 +02:00
Albert Vaca
3e5f9bb964 Merge branch 'pie'
# Conflicts:
#	res/values/strings.xml
#	src/org/kde/kdeconnect/UserInterface/MainActivity.java
2018-10-25 21:06:18 +02:00
Erik Duisters
2c32bd334a Broadcast actual tcp server port used
Summary: UDP Identity packet should set tcpPort to the actual tcpServer port used

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, nicolasfella, sredman, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16351
2018-10-25 21:03:44 +02:00
Albert Vaca
14d70df55c Use SwitchPreference on Android 7 2018-10-25 20:56:39 +02:00
Albert Vaca
20ad6a5ffc Oops, wrong condition 2018-10-25 19:36:41 +02:00
Albert Vaca
aee692ffb3 Better titles for the settings 2018-10-25 19:23:12 +02:00
Albert Vaca
6771024a00 Explain that the notification can be hidden in Android 9 2018-10-25 19:23:12 +02:00
Albert Vaca
39ac8c9096 Remove the option to rename device from the menu
As it's now in the settings screen
2018-10-25 19:22:34 +02:00
Albert Vaca
a97b32ce1e Merge remote-tracking branch 'origin/mina-sshd0-fix' into pie 2018-10-25 17:07:03 +02:00