Summary:
Previously, if the user hadn't set a ringtone, the code raised an exception (because an empty string isn't an uri). Thus, no sound was played.
This fixes it.
BUG: 392853
Test Plan: Without having set a ringtone, it works. Otherwise, it works too.
Reviewers: #kde_connect, albertvaka
Reviewed By: #kde_connect, albertvaka
Subscribers: nicolasfella, sredman, #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D12070
Summary: You can share the just-received file. It doesn't work with a custom download directory (just like opening such files doesn't work yet). It also won't close the notification once shared.
Test Plan: Sharing to other apps works.
Reviewers: #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Subscribers: nicolasfella, #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D11680
Summary: Won't typically be a problem (you're usually connected via wifi with KDE Connect anyway), but shouldn't hurt.
Test Plan: Works with the bluetooth backend on 4G (i.e. no album art is downloaded). Still downloads album art otherwise, as expected.
Reviewers: #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Subscribers: #kde_connect
Differential Revision: https://phabricator.kde.org/D11682
Summary:
This adds some simple explanation to the `identityPacketReceived` and
`addLink` methods.
Test Plan: N/A
Reviewers: #kde_connect, mtijink
Reviewed By: #kde_connect, mtijink
Differential Revision: https://phabricator.kde.org/D11672
Summary: The image is shown, similar to when you take a screenshot.
Test Plan: Works great! Doesn't crash for non-images.
Reviewers: #kde_connect, albertvaka
Reviewed By: #kde_connect, albertvaka
Subscribers: #kde_connect
Differential Revision: https://phabricator.kde.org/D11679
Summary: If the album art is a file url, the code will ask the remote device to transfer that file. It's then stored in the album art cache.
Test Plan: Works fine for me, even when quickly skipping songs.
Reviewers: #kde_connect, nicolasfella, albertvaka
Reviewed By: #kde_connect, albertvaka
Subscribers: albertvaka, nicolasfella, #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D11018
Summary:
Adds the album art to the media notification and lock screen.
How it looks on my phone (disregard the somewhat weird look, that's just the weird UI my phone vendor uses):
{F5728066}
Google images shows how it'll look on other phones (this one includes the lock screen image):
{F5728069}
And Android Oreo automatically colors the notification based on the album art color (untested, but should work):
{F5728070}
Test Plan: Changes are minor and it works fine for me.
Reviewers: #kde_connect, nicolasfella, albertvaka
Reviewed By: #kde_connect, nicolasfella, albertvaka
Subscribers: nicolasfella
Differential Revision: https://phabricator.kde.org/D10798
Summary:
MPrisPlugin previously made two calls to `requestPlayerList()` in its
`onCreate()` method. This change deletes the first of those, so that
only one network packet is sent and received.
Test Plan:
Pair a new device, confirm that only one request for media players is
received by remote client.
Reviewers: #kde_connect, mtijink
Reviewed By: #kde_connect, mtijink
Differential Revision: https://phabricator.kde.org/D11648
Summary:
The vector icons were rastizered for older Android versions, but these were on the small side. This fixes the size.
BUG: 392061
Test Plan: The icons aren't blurry anymore on Android 4.2.
Reviewers: #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Subscribers: #kde_connect
Differential Revision: https://phabricator.kde.org/D11644
Summary:
So switching (currently playing) players in the app will also switch the
notification.
Test Plan: Tested with two players playing at the same time, and switching between them.
Reviewers: #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Subscribers: #kde_connect
Differential Revision: https://phabricator.kde.org/D11647
Summary:
The buttons are now hidden, and only showed once we know that the device
is unpaired.
Test Plan: Pairing, pairing request and opening a device still work.
Reviewers: #kde_connect, nicolasfella
Reviewed By: #kde_connect, nicolasfella
Subscribers: #kde_connect
Differential Revision: https://phabricator.kde.org/D11627
Summary: As @kossebau mentioned, a disappearing "previous" button is not really great, since you'll likely press "next". This diff makes sure that when you can press previous and/or next, both buttons are shown (potentially disabled).
Test Plan: Works in all combinations of enabled/disabled for both buttons
Reviewers: #kde_connect, albertvaka
Reviewed By: #kde_connect, albertvaka
Subscribers: kossebau, #kde_connect
Differential Revision: https://phabricator.kde.org/D11437
Summary: KDE Connect, now with correct naming!
Test Plan: It still builds.
Reviewers: #kde_connect, apol, nicolasfella
Reviewed By: #kde_connect, apol, nicolasfella
Subscribers: nicolasfella, apol
Differential Revision: https://phabricator.kde.org/D11035
Summary: Add an ActionBar entry for adding a command to the list. The current way to add commands is quite hidden.
Reviewers: #kde_connect, mtijink
Reviewed By: #kde_connect, mtijink
Subscribers: philipc, mtijink, #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D7959
Summary: Won't have a practical impact, but Lint is happy
Test Plan: Add entries to ip list
Reviewers: #kde_connect, mtijink
Reviewed By: #kde_connect, mtijink
Subscribers: mtijink, #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D10949
Summary: Some languages have more plurals than the english language. This enables translaters to select the appropriate plural form.
Test Plan: No change in english
Reviewers: #kde_connect, albertvaka
Reviewed By: #kde_connect, albertvaka
Subscribers: #kde_connect
Tags: #kde_connect
Differential Revision: https://phabricator.kde.org/D11001
