2
0
mirror of https://github.com/KDE/kdeconnect-android synced 2025-08-31 14:15:14 +00:00
Ravi Mistry 8f49ff57ab Fix byte array conversions
## Summary

Currently, KDE Connect for Android doesn't show the last 2 characters of the verification key when pairing a device. This MR solves this issue.

This bug is caused by incomplete conversions from byte arrays to strings in `SslHelper.java`:

```java
for (int i = 0; i < hash.length - 1; i++) {
    formatter.format("%02x", hash[i]);
}
```
The ```i < hash.length -1``` converts the bytes in the array up to (inclusive) the penultimate one. Removing the ```- 1``` allows for the last byte to be converted (this is the missing 2 characters).

BUG: 445955

## Test Plan

### Before:
Selecting a desktop from the available devices, then clicking the `Request Pairing` button causes a 62 character key to be displayed. It is 2 characters short of the actual key, which can be seen on the desktop KDE Connect app.

### After:
Selecting the `Request Pairing` button now shows the whole verification key, as intended.
2022-05-30 21:28:03 +00:00
2022-03-03 23:58:23 +01:00
2020-08-17 16:17:20 +02:00
2022-02-16 22:54:52 +00:00
2017-07-29 11:33:45 +02:00
2020-05-13 04:35:02 +00:00
2019-09-07 14:31:55 +02:00
2022-03-03 23:58:23 +01:00
2013-10-01 14:35:30 +02:00
2019-09-07 14:31:55 +02:00
2020-07-11 02:10:37 +00:00
2020-05-13 04:35:02 +00:00
2020-05-13 04:35:02 +00:00
2020-08-02 06:31:33 +00:00
2021-03-13 01:41:44 +00:00

KDE Connect - Android app

KDE Connect is a multi-platform app that allows your devices to communicate (eg: your phone and your computer).

(Some) Features

  • Shared clipboard: copy and paste between your phone and your computer (or any other device).
  • Notification sync: Read and reply to your Android notifications from the desktop.
  • Share files and URLs instantly from one device to another.
  • Multimedia remote control: Use your phone as a remote for Linux media players.
  • Virtual touchpad: Use your phone screen as your computer's touchpad and keyboard.

All this without wires, over the already existing WiFi network, and using TLS encryption.

About this app

This is a native Android port of the KDE Connect Qt app. You will find a more complete readme about KDE Connect here.

How to install this app

You can install this app from the Play Store as well as F-Droid. Note you will also need to install the desktop app for it to work.

Contributing

A lot of useful information, including how to get started working on KDE Connect and how to connect with the current developers, is on our KDE Community Wiki page

For bug reporting, please use KDE's Bugzilla. Please do not use the issue tracker in GitLab since we want to keep everything in one place.

To contribute patches, use KDE Connect's Gitlab. On Gitlab (as well as on our old Phabricator) you can find a task list with stuff to do and links to other relevant resources. It is a good idea to also subscribe to the KDE Connect mailing list.

Please know that all translations for all KDE apps are handled by the localization team. If you would like to submit a translation, that should be done by working with the proper team for that language.

License

GNU GPL v2 and GNU GPL v3

If you are reading this from Github, you should know that this is just a mirror of the KDE Project repo.

Description
No description provided
Readme 34 MiB
Languages
Kotlin 54.2%
Java 45.4%
Shell 0.4%