mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 14:05:33 +00:00
Code Issues Releases Wiki Activity

[#3084] Clean up

Browse Source
This commit is contained in:
Thomas Markwalder
2023-11-10 13:35:29 -05:00
parent 52a7191294
commit 1a7e140015
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/bin/dhcp4/dhcp4_srv.cc
View File

@@ -1518,7 +1518,6 @@ Dhcpv4Srv::processDhcp4Query(Pkt4Ptr& query, Pkt4Ptr& rsp,
try { try {
callout_handle->getArgument("offer-address-in-use", offer_address_in_use); callout_handle->getArgument("offer-address-in-use", offer_address_in_use);
} catch (const NoSuchArgument& ex) { } catch (const NoSuchArgument& ex) {
/// @todo consider logging this
LOG_DEBUG(hooks_logger, DBG_DHCP4_HOOKS, LOG_DEBUG(hooks_logger, DBG_DHCP4_HOOKS,
DHCP4_HOOK_LEASE4_OFFER_ARGUMENT_MISSING) DHCP4_HOOK_LEASE4_OFFER_ARGUMENT_MISSING)
.arg(query->getLabel()); .arg(query->getLabel());
@@ -4015,14 +4014,14 @@ Dhcpv4Srv::serverDecline(hooks::CalloutHandlePtr& /* callout_handle */, Pkt4Ptr&
StatsMgr::instance().addValue("assigned-addresses", static_cast<int64_t>(1)); StatsMgr::instance().addValue("assigned-addresses", static_cast<int64_t>(1));
} }
/* (comment it out so picky tools don't flag this as dead code /* (comment it out so picky tools don't flag this as dead code
// //
/// @todo #3110, HA will implement a handler for this hook point to /// @todo #3110, HA will implement a handler for this hook point to
/// propagate an update of the lease to peers. /// propagate an update of the lease to peers.
// //
// Let's check if there are hooks installed for server decline hook point. // Let's check if there are hooks installed for server decline hook point.
// If they are, let's pass the lease and client's packet. // If they are, let's pass the lease and client's packet. Note this code
// has never been compiled, it is just an initial draft.
if (HooksManager::calloutsPresent(Hooks.hook_index_lease4_server_decline)) { if (HooksManager::calloutsPresent(Hooks.hook_index_lease4_server_decline)) {
CalloutHandlePtr callout_handle = getCalloutHandle(decline); CalloutHandlePtr callout_handle = getCalloutHandle(decline);