mirror of
https://gitlab.isc.org/isc-projects/kea
synced 2025-08-30 21:45:37 +00:00
[1535] improve OutOfZoneFind text and docstring
This commit is contained in:
@@ -865,8 +865,8 @@ DatabaseClient::Finder::findInternal(const Name& name, const RRType& type,
|
||||
name.compare(getOrigin()).getRelation();
|
||||
if (reln != NameComparisonResult::SUBDOMAIN &&
|
||||
reln != NameComparisonResult::EQUAL) {
|
||||
isc_throw(OutOfZoneFind, "out-of-zone find(): " << name.toText() <<
|
||||
" not in " << getOrigin().toText());
|
||||
isc_throw(OutOfZoneFind, name.toText() << " not in " <<
|
||||
getOrigin().toText());
|
||||
}
|
||||
|
||||
// First, go through all superdomains from the origin down, searching for
|
||||
|
@@ -1206,8 +1206,7 @@ struct InMemoryZoneFinder::InMemoryZoneFinderImpl {
|
||||
name.compare(origin_).getRelation();
|
||||
if (reln != NameComparisonResult::SUBDOMAIN &&
|
||||
reln != NameComparisonResult::EQUAL) {
|
||||
isc_throw(OutOfZoneFind, "out-of-zone find(): " <<
|
||||
name.toText() <<
|
||||
isc_throw(OutOfZoneFind, name.toText() <<
|
||||
" not in " << origin_.toText());
|
||||
}
|
||||
|
||||
|
@@ -99,10 +99,9 @@ Their semantics is as follows (they are or bit-field):\n\
|
||||
of the non existence of any matching wildcard or non existence of an\n\
|
||||
exact match when a wildcard match is found.\n\
|
||||
\n\
|
||||
In general, name is expected to be included in the zone, that is, it\n\
|
||||
should be equal to or a subdomain of the zone origin. Otherwise this\n\
|
||||
method will return NXDOMAIN with an empty RRset. But such a case\n\
|
||||
should rather be considered a caller's bug.\n\
|
||||
Name is expected to be included in the zone, that is, it\n\
|
||||
should be equal to or a subdomain of the zone origin. Otherwise an\n\
|
||||
OutOfZoneFind exception is raised.\n\
|
||||
\n\
|
||||
Note: For this reason it's probably better to throw an exception than\n\
|
||||
returning NXDOMAIN. This point should be revisited in a near future\n\
|
||||
|
Reference in New Issue
Block a user