mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-01 14:35:29 +00:00
Code Issues Releases Wiki Activity

[3973] Added todos for the lease reclamation routines.

Browse Source
This commit is contained in:
Marcin Siodelski
2015-09-11 09:34:37 +02:00
parent 8b01bb335f
commit 2ead25cbea
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/dhcpsrv/alloc_engine.cc
View File

@@ -1291,6 +1291,8 @@ AllocEngine::reclaimExpiredLeases6(const size_t max_leases, const uint16_t timeo
// Create stopwatch and automatically start it to measure the time
// taken by the routine.
/// @todo Monitor time elapsed and return from the lease reclamation routine
/// if it hits the timeout value.
util::Stopwatch stopwatch;
LeaseMgr& lease_mgr = LeaseMgrFactory::instance();
@@ -1371,6 +1373,8 @@ AllocEngine::reclaimExpiredLeases4(const size_t max_leases, const uint16_t timeo
// Create stopwatch and automatically start it to measure the time
// taken by the routine.
/// @todo Monitor time elapsed and return from the lease reclamation routine
/// if it hits the timeout value.
util::Stopwatch stopwatch;
LeaseMgr& lease_mgr = LeaseMgrFactory::instance();

10
src/lib/dhcpsrv/tests/alloc_engine_expiration_unittest.cc
View File

@@ -146,6 +146,16 @@ struct UpperBound {
/// "expired-reclaimed".
///
/// See @c ExpirationAllocEngineTest::testLeases for further details.
///
/// @todo These tests should be extended to cover the following cases:
/// - timeout value in the lease reclamation routines - the most reliable
/// way to test it will be by attaching a lease4_expire/lease6_expire
/// hooks which would block for a specific period of time. This will
/// allow for calculating the approximate number of reclaimed leases
/// within a given timeout. See ticket #3972.
/// - declined leases - declined leases expire and should be removed
/// from the lease database by the lease reclamation routine. See
/// ticket #3976.
template<typename LeasePtrType>
class ExpirationAllocEngineTest : public ::testing::Test {
public: