2
0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 14:05:33 +00:00

[#947] addressed review

This commit is contained in:
Razvan Becheriu
2020-02-12 17:08:27 +02:00
parent 4ecfe62f95
commit 89bfafdb82
16 changed files with 27 additions and 29 deletions

View File

@@ -112,7 +112,7 @@ applied by the template @c process located in flex_option.h. When
required the expression is evaluated on the query packet and the result
is used by the action for instance to add a new option.
@section libdhcp_flex_optionMTCompatibility Multi-Threading Compaibility
@section libdhcp_flex_optionMTCompatibility Multi-Threading Compatibility
The libdhcp_flex_option hooks library is compatible with multi-threading.

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2019-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the End User License
// Agreement. See COPYING file in the premium/ directory.
@@ -122,7 +122,7 @@ int unload() {
return (0);
}
/// @brief This function is called to know the multi-threading compatibility.
/// @brief This function is called to retrieve the multi-threading compatibility.
///
/// @return 1 which means compatible with multi-threading.
int multi_threading_compatible() {

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2017-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2017-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -411,6 +411,6 @@ Addressing this issue requires two enhancements:
The High Availability hooks library currently reports it is not
compatible with multi-threading. This will be revisited as there is
no essential reason for such uncompatibility.
no essential reason for such incompatibility.
*/

View File

@@ -303,10 +303,10 @@ int unload() {
return (0);
}
/// @brief This function is called to know the multi-threading compatibility.
/// @brief This function is called to retrieve the multi-threading compatibility.
///
/// @note: this should be revisited as the library is not essentially
/// uncompatible.
/// incompatible.
///
/// @return 0 which means not compatible with multi-threading.
int multi_threading_compatible() {

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2017-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2017-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -95,10 +95,9 @@ commands that remove all leases from specific subnet. As there were no
queries that could retrieve or otherwise enumerate leases for a specific subnet,
a new query type and a new index had to be added.
@section lease_cmdsTCompatibility Multi-Threading Compatibility
@section lease_cmdsMTCompatibility Multi-Threading Compatibility
The Lease Commands Hook library is compatible with multi-threading.
All commands modifying leases are performed inside a critical section
i.e. with the DHCP server stopped.
All commands are executed inside a critical section, i.e. with threads stopped.
*/

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2017-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2017-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the End User License
// Agreement. See COPYING file in the premium/ directory.
@@ -284,7 +284,7 @@ int unload() {
return (0);
}
/// @brief This function is called to know the multi-threading compatibility.
/// @brief This function is called to retrieve the multi-threading compatibility.
///
/// @return 1 which means compatible with multi-threading.
int multi_threading_compatible() {

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2018-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -45,7 +45,7 @@ int unload() {
return (0);
}
/// @brief This function is called to know the multi-threading compatibility.
/// @brief This function is called to retrieve the multi-threading compatibility.
///
/// @note: the compatibility is based on the assumption this hook library
/// is always called from the main thread.

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2018-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this

View File

@@ -198,9 +198,8 @@ and DHCPv6 response might look like this:
@section stat_cmdsMTCompatibility Multi-Threading Compatibility
The Stat Commands Hook library reports it is compatible with
multi-threading. All commands are executed inside a critical section,
i.e. with threads stopped. It makes sense to not have lease state
changes when taking lease counts.
The Stat Commands Hook library is compatible with multi-threading.
All commands are executed inside a critical section, i.e. with threads stopped.
It makes sense to not have lease state changes when retrieving lease counts.
*/

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2018-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the End User License
// Agreement. See COPYING file in the premium/ directory.
@@ -61,7 +61,7 @@ int unload() {
return (0);
}
/// @brief This function is called to know the multi-threading compatibility.
/// @brief This function is called to retrieve the multi-threading compatibility.
///
/// @return 1 which means compatible with multi-threading.
int multi_threading_compatible() {

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -212,7 +212,7 @@ registered=yes
Note the library always opens this file in append mode and does not limit its size.
@section libdhcp_user_chkMTCompatibility Multi-Threading Compaibility
@section libdhcp_user_chkMTCompatibility Multi-Threading Compatibility
The user_chk hooks library does not define a multi_threading_compatible()
C function so is considered as not compatible with multi-threading

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this

View File

@@ -1,4 +1,4 @@
// Copyright (C) 2013-2019 Internet Systems Consortium, Inc. ("ISC")
// Copyright (C) 2013-2020 Internet Systems Consortium, Inc. ("ISC")
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this