2
0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 14:05:33 +00:00

[65-libyang-generic] Addressed comments

This commit is contained in:
Francis Dupont
2018-09-12 11:37:35 +02:00
parent df15fba97f
commit c2557ffac0
3 changed files with 18 additions and 9 deletions

View File

@@ -107,7 +107,6 @@
*
* @section libraries Kea libraries
* - @subpage libcc
* - @subpage libyang
* - @subpage libdhcp
* - @subpage libdhcpIntro
* - @subpage libdhcpRelay
@@ -130,6 +129,7 @@
* - @subpage libprocess
* - @subpage cpl
* - @subpage cplSignals
* - @subpage libyang
*
* @section miscellaneousTopics Miscellaneous Topics
* - @subpage terminology

View File

@@ -14,11 +14,11 @@ SysrepoConnection::SysrepoConnection() {
SysrepoConnection::~SysrepoConnection() {
if (session_) {
session_->discard_changes();
session_->unlock_datastore();
session_->session_stop();
session_->discard_changes();
session_->unlock_datastore();
session_->session_stop();
// how to call disconnect?
// @todo: how to call disconnect?
}
}
@@ -34,10 +34,10 @@ SysrepoConnection::connect() {
void
SysrepoConnection::commit() {
if (!session_) {
isc_throw(SysrepoConnectionError, "session not established");
}
session_->commit();
if (!session_) {
isc_throw(SysrepoConnectionError, "session not established");
}
session_->commit();
}
}

View File

@@ -13,21 +13,30 @@
namespace isc {
namespace yang {
/// @brief Exception from the sysrepo library for connection.
class SysrepoConnectionError : public Exception {
public:
SysrepoConnectionError(const char* file, size_t line, const char* what) :
isc::Exception(file, line, what) {}
};
/// @brief Connection to the sysrepo library. Provision, i.e. currently unused.
class SysrepoConnection {
public:
// @brief Constructor.
SysrepoConnection();
// @brief Destructor.
virtual ~SysrepoConnection();
// @brief Get a connection and a session.
void connect();
// @brief Commit a session.
void commit();
private:
// @brief The session.
S_Session session_;
};