mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 22:15:23 +00:00
Code Issues Releases Wiki Activity

[65-libyang-generic] Addressed comments

Browse Source
This commit is contained in:
Francis Dupont
2018-09-12 11:37:35 +02:00
parent df15fba97f
commit c2557ffac0
3 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/devel/mainpage.dox
View File

@@ -107,7 +107,6 @@
* *
* @section libraries Kea libraries * @section libraries Kea libraries
* - @subpage libcc * - @subpage libcc
* - @subpage libyang
* - @subpage libdhcp * - @subpage libdhcp
* - @subpage libdhcpIntro * - @subpage libdhcpIntro
* - @subpage libdhcpRelay * - @subpage libdhcpRelay
@@ -130,6 +129,7 @@
* - @subpage libprocess * - @subpage libprocess
* - @subpage cpl * - @subpage cpl
* - @subpage cplSignals * - @subpage cplSignals
* - @subpage libyang
* *
* @section miscellaneousTopics Miscellaneous Topics * @section miscellaneousTopics Miscellaneous Topics
* - @subpage terminology * - @subpage terminology

16
src/lib/yang/sysrepo_connection.cc
View File

@@ -14,11 +14,11 @@ SysrepoConnection::SysrepoConnection() {
SysrepoConnection::~SysrepoConnection() { SysrepoConnection::~SysrepoConnection() {
if (session_) { if (session_) {
session_->discard_changes(); session_->discard_changes();
session_->unlock_datastore(); session_->unlock_datastore();
session_->session_stop(); session_->session_stop();
// how to call disconnect? // @todo: how to call disconnect?
} }
} }
@@ -34,10 +34,10 @@ SysrepoConnection::connect() {
void void
SysrepoConnection::commit() { SysrepoConnection::commit() {
if (!session_) { if (!session_) {
isc_throw(SysrepoConnectionError, "session not established"); isc_throw(SysrepoConnectionError, "session not established");
} }
session_->commit(); session_->commit();
} }
} }

9
src/lib/yang/sysrepo_connection.h
View File

@@ -13,21 +13,30 @@
namespace isc { namespace isc {
namespace yang { namespace yang {
/// @brief Exception from the sysrepo library for connection.
class SysrepoConnectionError : public Exception { class SysrepoConnectionError : public Exception {
public: public:
SysrepoConnectionError(const char* file, size_t line, const char* what) : SysrepoConnectionError(const char* file, size_t line, const char* what) :
isc::Exception(file, line, what) {} isc::Exception(file, line, what) {}
}; };
/// @brief Connection to the sysrepo library. Provision, i.e. currently unused.
class SysrepoConnection { class SysrepoConnection {
public: public:
// @brief Constructor.
SysrepoConnection(); SysrepoConnection();
// @brief Destructor.
virtual ~SysrepoConnection(); virtual ~SysrepoConnection();
// @brief Get a connection and a session.
void connect(); void connect();
// @brief Commit a session.
void commit(); void commit();
private: private:
// @brief The session.
S_Session session_; S_Session session_;
}; };