mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 22:15:23 +00:00
Code Issues Releases Wiki Activity

[#1386] Addressed review comments

Browse Source 
Addressed review comments for !980.

src/bin/dhcp4/tests/fqdn_unittest.cc
src/lib/dhcpsrv/tests/ncr_generator_unittest.cc
    Added missing test parameter comments
This commit is contained in:
Thomas Markwalder
2020-10-23 10:33:15 -04:00
parent 20ed6f005f
commit cfa7928fea
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/bin/dhcp4/tests/fqdn_unittest.cc
View File

@@ -750,6 +750,7 @@ public:
/// @param not_strict_expire_check - when true the comparison of the NCR
/// lease expiration time is conducted as greater than or equal to rather
/// equal to CLTT plus lease length.
/// @param exp_use_cr expected value of conflict resolution flag
void verifyNameChangeRequest(const isc::dhcp_ddns::NameChangeType type,
const bool reverse, const bool forward,
const std::string& addr,

6
src/lib/dhcpsrv/tests/ncr_generator_unittest.cc
View File

@@ -220,9 +220,10 @@ public:
/// @param rev Perform reverse update.
/// @param fqdn Hostname.
/// @param exp_dhcid Expected DHCID.
/// @param exp_use_cr expected value of conflict resolution flag
void testNCR(const NameChangeType chg_type, const bool fwd, const bool rev,
const std::string& fqdn, const std::string exp_dhcid,
const bool conflict_resolution = true) {
const bool exp_use_cr = true) {
// Queue NCR.
ASSERT_NO_FATAL_FAILURE(sendNCR(chg_type, fwd, rev, fqdn));
// Expecting one NCR be generated.
@@ -230,7 +231,7 @@ public:
// Check the details of the NCR.
verifyNameChangeRequest(chg_type, rev, fwd, lease_->addr_.toText(), exp_dhcid,
lease_->cltt_ + lease_->valid_lft_,
lease_->valid_lft_, fqdn, conflict_resolution);
lease_->valid_lft_, fqdn, exp_use_cr);
}
/// @brief Test that calling queueNCR for NULL lease doesn't cause
@@ -242,7 +243,6 @@ public:
ASSERT_NO_FATAL_FAILURE(queueNCR(chg_type, lease_));
EXPECT_EQ(0, d2_mgr_.getQueueSize());
}
};
/// @brief Test fixture class implementation for DHCPv6.