configure.ac
Added mysql/upgrade_019_to_020.sh
src/bin/admin/tests/mysql_tests.sh.in
Updated, adjusted for version check
src/lib/mysql/mysql_constants.h
Bumped schema version to 22
src/share/database/scripts/mysql/.gitignore
upgrade_019_to_020.sh
src/share/database/scripts/mysql/dhcpdb_create.mysql
Moved expire column statements into version 22 update section
src/share/database/scripts/mysql/upgrade_020_to_021.sh.in
Removed expire column updates
src/share/database/scripts/mysql/upgrade_020_to_021.sh.in
New file, modifies expire columns
src/share/database/scripts/mysql/dhcpdb_create.mysql
Change expire column in lease4 and lease6 to accept NULL
src/share/database/scripts/mysql/upgrade_018_to_019.sh.in
Change expire column in lease6 to accept NULL
src/share/database/scripts/mysql/upgrade_020_to_021.sh.in
Change expire column in lease4 and lease6 to accept NULL
Added ChangeLog entry
```
io_service_thread_pool_unittests.cc:24:12: warning: unused variable 'TEST_TIMEOUT' [-Wunused-const-variable]
mysql_connection_unittest.cc:217:75: warning: declaration of ‘out_bindings’ shadows a previous local [-Wshadow]
mysql_host_data_source.cc:171:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:202:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:220:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:254:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:422:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:554:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:579:30: warning: useless cast to type ‘isc::dhcp::SubnetID’ {aka ‘unsigned int’} [-Wuseless-cast]
mysql_host_data_source.cc:586:30: warning: useless cast to type ‘isc::dhcp::SubnetID’ {aka ‘unsigned int’} [-Wuseless-cast]
mysql_host_data_source.cc:674:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:714:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:1313:18: warning: 'processFetchedData' overrides a member function but is not marked 'override' [-Wsuggest-override]
mysql_host_data_source.cc:1353:37: warning: 'createBindForReceive' overrides a member function but is not marked 'override' [-Wsuggest-override]
mysql_host_data_source.cc:1371:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:1456:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:1487:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:1508:18: warning: 'processFetchedData' overrides a member function but is not marked 'override' [-Wsuggest-override]
mysql_host_data_source.cc:1542:37: warning: 'createBindForReceive' overrides a member function but is not marked 'override' [-Wsuggest-override]
mysql_host_data_source.cc:1583:6: warning: extra ';' after member function definition [-Wextra-semi]
mysql_host_data_source.cc:1803:25: warning: unused variable 'OPTION_ID_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1804:25: warning: unused variable 'CODE_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1805:25: warning: unused variable 'VALUE_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1806:25: warning: unused variable 'FORMATTED_VALUE_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1807:25: warning: unused variable 'SPACE_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1808:25: warning: unused variable 'PERSISTENT_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1809:25: warning: unused variable 'CANCELLED_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1810:25: warning: unused variable 'USER_CONTEXT_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1811:25: warning: unused variable 'DHCP_SUBNET_ID_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:1812:25: warning: unused variable 'HOST_ID_COL' [-Wunused-const-variable]
mysql_host_data_source.cc:3222:24: warning: useless cast to type ‘char*’ [-Wuseless-cast]
mysql_host_data_source.cc:3385:24: warning: useless cast to type ‘char*’ [-Wuseless-cast]
mysql_host_data_source.cc:3426:24: warning: useless cast to type ‘char*’ [-Wuseless-cast]
mysql_lease_mgr.cc:89:14: warning: unused variable 'HOSTNAME_MAX_LEN' [-Wunused-const-variable]
mysql_lease_mgr.cc:95:14: warning: unused variable 'ADDRESS6_TEXT_MAX_LEN' [-Wunused-const-variable]
mysql_lease_mgr.cc:98:14: warning: unused variable 'USER_CONTEXT_MAX_LEN' [-Wunused-const-variable]
mysql_lease_mgr.cc:544:29: warning: useless cast to type ‘isc::db::my_bool*’ {aka ‘bool*’} [-Wuseless-cast]
mysql_lease_mgr.cc:1929:10: warning: 'start' overrides a member function but is not marked 'override' [-Wsuggest-override]
mysql_lease_mgr.cc:2010:30: warning: useless cast to type ‘isc::dhcp::SubnetID’ {aka ‘unsigned int’} [-Wuseless-cast]
mysql_lease_mgr.cc:2020:10: warning: 'getNextRow' overrides a member function but is not marked 'override' [-Wsuggest-override]
mysql_lease_mgr.cc:3427:13: warning: useless cast to type ‘uint64_t’ {aka ‘long unsigned int’} [-Wuseless-cast]
mysql_lease_mgr.cc:4114:23: warning: variable length arrays are a C99 feature [-Wvla-extension]
mysql_lease_mgr.cc:4226:23: warning: variable length arrays are a C99 feature [-Wvla-extension]
option_opaque_data_tuples_unittest.cc:533:32: warning: zero size arrays are an extension [-Wzero-length-array]
option_opaque_data_tuples_unittest.cc:552:32: warning: zero size arrays are an extension [-Wzero-length-array]
option_opaque_data_tuples_unittest.cc:572:32: warning: zero size arrays are an extension [-Wzero-length-array]
tcp_connection.cc:28:14: warning: unused variable 'MAX_LOGGED_MESSAGE_SIZE' [-Wunused-const-variable]
test_control.cc:1826:23: warning: useless cast to type ‘class isc::asiolink::IOAddress’ [-Wuseless-cast]
test_control.cc:1830:24: warning: useless cast to type ‘class isc::asiolink::IOAddress’ [-Wuseless-cast]
test_control.cc:1871:34: warning: useless cast to type ‘class isc::asiolink::IOAddress’ [-Wuseless-cast]
test_control.cc:1873:30: warning: useless cast to type ‘class isc::asiolink::IOAddress’ [-Wuseless-cast]
../../../src/lib/http/http_message_parser_base.h:26:45: warning: extra ‘;’ after in-class function definition [-Wextra-semi]
../../../src/lib/http/http_message_parser_base.h:174:18: warning: ‘virtual void isc::http::HttpMessageParserBase::defineEvents()’ can be marked override [-Wsuggest-override]
../../../src/lib/http/http_message_parser_base.h:177:18: warning: ‘virtual void isc::http::HttpMessageParserBase::verifyEvents()’ can be marked override [-Wsuggest-override]
../../../src/lib/http/http_message_parser_base.h:180:18: warning: ‘virtual void isc::http::HttpMessageParserBase::defineStates()’ can be marked override [-Wsuggest-override]
../../../src/lib/http/http_message_parser_base.h:233:18: warning: ‘virtual void isc::http::HttpMessageParserBase::onModelFailure(const string&)’ can be marked override [-Wsuggest-override]
```
```
data.cc:905:21: warning: comparison is always true due to limited range of data type [-Wtype-limits]
data.cc:905:48: warning: comparison is always false due to limited range of data type [-Wtype-limits]
http_message_parser_base.cc:266:15: warning: comparison is always true due to limited range of data type [-Wtype-limits]
http_message_parser_base.cc:271:17: warning: comparison is always true due to limited range of data type [-Wtype-limits]
```
```
warning: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ reading 1 or more bytes from a region of size 0 [-Wstringop-overread]
```
and Wsign-compare in the same file:
```
test_control.cc:116:35: warning: comparison of integers of different signs: 'uint64_t' (aka 'unsigned long') and 'int' [-Wsign-compare] 338ms
test_control.cc:491:43: warning: comparison of integers of different signs: 'size_type' (aka 'unsigned long') and 'const int' [-Wsign-compare]
test_control.cc:529:50: warning: comparison of integers of different signs: 'size_type' (aka 'unsigned long') and 'const int' [-Wsign-compare]
```
... and throw exception if result is unfortunate.
... and check exceptions thrown in unit tests because it is important
now to distinguish that the old exceptions are thrown instead of the new.
src/bin/dhcp4/dhcp4_hooks.dox
src/bin/dhcp4/dhcp6_hooks.dox
Correctec parameter names
src/bin/dhcp4/tests/hooks_unittest.cc
TEST_F(HooksDhcpv4SrvTest, ddns4Update) - new test
src/bin/dhcp6/tests/hooks_unittest.cc
TEST_F(HooksDhcpv6SrvTest, ddns6Update) - new test
src/lib/asiolink/io_service.cc
src/lib/asiolink/io_service.h
- replaced unresolvable @ref with @c for boost::asio::io_service,
(boost code does not use doxygen)
src/lib/dns/tsigkey.h
Replaced @class with @ref, at @class needs to point to a file
Added ChangeLog entry
src/bin/dhcp4/dhcp4_srv.cc
DHCP4_PACKET_RECEIVED and DHCP4_PACKET_SEND moved to INFO
src/bin/dhcp6/dhcp6_srv.cc
DHCP6_PACKET_RECEIVED and DHCP6_PACKET_SEND moved to INFO
- ctrl_dhcp4_srv_unittest.cc:145:6: warning: extra ‘;’ after in-class function definition [-Wextra-semi]
- ctrl_dhcp4_srv_unittest.cc:2172:28: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp4_srv_unittest.cc:2191:33: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp4_srv_unittest.cc:2295:33: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp4_srv_unittest.cc:2352:28: warning: declaration of ‘timeout’ shadows a previous local [-Wshadow]
- ctrl_dhcp4_srv_unittest.cc:2402:28: warning: declaration of ‘timeout’ shadows a previous local [-Wshadow]
- ctrl_dhcp6_srv_unittest.cc:116:6: warning: extra ‘;’ after in-class function definition [-Wextra-semi]
- ctrl_dhcp6_srv_unittest.cc:181:6: warning: extra ‘;’ after in-class function definition [-Wextra-semi]
- ctrl_dhcp6_srv_unittest.cc:264:10: warning: ‘virtual void {anonymous}::CtrlChannelDhcpv6SrvTest::reset()’ can be marked override [-Wsuggest-override]
- ctrl_dhcp6_srv_unittest.cc:2210:28: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp6_srv_unittest.cc:2229:33: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp6_srv_unittest.cc:2333:33: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp6_srv_unittest.cc:2390:28: warning: declaration of ‘timeout’ shadows a previous local [-Wshadow]
- ctrl_dhcp6_srv_unittest.cc:2440:28: warning: declaration of ‘timeout’ shadows a previous local [-Wshadow]
- dhcp6_srv_unittest.cc:2420:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
- dhcp6_srv_unittest.cc:2440:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
- dhcp6_srv_unittest.cc:2932:28: warning: useless cast to type ‘const uint8_t*’ {aka ‘const unsigned char*’} [-Wuseless-cast]
- dhcp6_srv_unittest.cc:2964:26: warning: useless cast to type ‘const uint8_t*’ {aka ‘const unsigned char*’} [-Wuseless-cast]
