2
0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 14:05:33 +00:00
Commit Graph

19460 Commits

Author SHA1 Message Date
Thomas Markwalder
137c12ee4f [3432] Addressed review comments
Consolidated DNSClient::doUpdate variants into a single method which
accepts a smart pointer to a TSIGKey instead of TSIGKey reference.
Simplified some unit tests.
Added missing commentary.
Corrected typos and copyright dates.
2014-05-27 11:05:20 -04:00
Stephen Morris
16bd0ab7a3 [3432] Miscellaneous modifications to DHCP-DDNS documentation made during review 2014-05-26 13:48:05 +01:00
Thomas Markwalder
a5f18aac17 [3432] Updated Admin guide for TSIG key configuration
Updated the admin guilde and minor change to dhcp-ddns.spec file.
2014-05-19 11:08:08 -04:00
Thomas Markwalder
64bf00162a [3432] Changed algorithm strings to match dnsssec-keygen labels
Changed the string values used to configure a TSIG key's algorithm to
match those used by Bind9's dnssec-keygen.
Added tests for all supported algorithms.
2014-05-16 12:15:38 -04:00
Thomas Markwalder
5819b2620f [3432] Fixed d2::TSIGKeyInfo::remake to use correct dns::TSIGKey constructor
The dns::TSIGKey constructor that was being by d2:TSIGKeyINfo expects an
ordinary string value for secret and then encodes it to base64. Since
TSIGKeyInfo configuration value for secret is already expected to be base64
encoded this was causing it to be encoded again resulting in verification
errors when tested against Bind9.

Changed TSIGKeyInfo::remake to use the appropriate TSIGKey constructor.
2014-05-16 07:47:12 -04:00
Thomas Markwalder
ca968c5c71 [3432] Modify NameChangeTransaction to get its TSIGKey from current DdnsDomain
NameChangeTransaction now sets its TSIGKeyPtr inside initServeSelection()
from the domain pased into this method.

This makes TSIG fully fucntionally end-to-end.
2014-05-15 09:51:46 -04:00
Thomas Markwalder
d980423746 [3432] Replaced sting key_name with TSIGKeyInfo in d2::DdnsDomain
Rather than each DdnsDomain storing only the string name of its TSIG key,
it now contains an pointer to the TSIGKeyInfo which corresponds to the
key name given in its configuration.
2014-05-15 07:42:11 -04:00
Thomas Markwalder
3784b4690d [3432] TSIGKeyInfo now creates and owns a dns::TSIGKey
d2::TSIGKeyInfo now has an instance member for a dns::TSIGKey
instance, which is created during the TSIGKeyInfo's construction.
2014-05-14 15:45:34 -04:00
Thomas Markwalder
a00bfe5401 [3432] Added basic TSIG support to NameChangeTransaction
Added TSIGKeyPtr instance member to NameChangeTransaction.
Modified NameChangeTransaction::sendUpdate() to do a TSIG updates if its
TSIGKeyPtr is not null.

Extended FauxServer test class to support TSIG if given a key.
Added round trip TSIG tests to NameChangeTransaction base class tests.

This does not address how the transaction's key is determined. That
requires changes to configuration classes in D2Config.
2014-05-14 10:39:11 -04:00
Thomas Markwalder
dd0024cf1e [3432] Added support for TSIG to D2UpdateMessage and DNSClient
Change D2UpdateMessage to support TSIG signing and verification via its
toWire and fromWire methods.  Both now accept a pointer to a TSIGContext,
which they should use, if its not NULL.

Implemented DNSCLient::doUpdate variant that accepts a TSIGKey. It will
use the key to create a TSIGContext that will then be used to sign the
outbound request and to verify the response in the operator() method.

Added appropriate unit tests.
2014-05-12 16:15:31 -04:00
Stephen Morris
a3598893ad [3398] Miscellaneous corrections and edits as part of review 2014-05-06 17:41:55 +01:00
Tomek Mrugalski
83b2d2b565 [3398] Rather important file has been omitted. :) 2014-05-06 15:37:00 +02:00
Tomek Mrugalski
91c64d2764 [3398] Several Doxygen warnings removed. 2014-05-06 15:07:48 +02:00
Tomek Mrugalski
5acb3cb565 [3398] The result of configuration design discussion added 2014-05-06 14:59:36 +02:00
Marcin Siodelski
777dbdb29a [master] Merge branch 'trac3409'
Conflicts:
	src/lib/dhcpsrv/d2_client_cfg.cc
	src/lib/dhcpsrv/dhcp_parsers.cc
2014-04-29 22:19:56 +02:00
Marcin Siodelski
d596586365 [3409] Addressed review comments. 2014-04-29 18:27:14 +02:00
Marcin Siodelski
dc69d95585 [3409] Append line number to error caused by undefined global parameter. 2014-04-28 17:11:40 +02:00
Marcin Siodelski
5c31704c49 [3409] Append line number for errors when duplicated subnet id is used. 2014-04-28 16:58:24 +02:00
Marcin Siodelski
db9aaee9e4 [3409] Append line number when adding duplicated option definition. 2014-04-28 15:57:41 +02:00
Marcin Siodelski
c49d560620 [3409] Unit tests check that the error message contains line number etc. 2014-04-28 15:25:07 +02:00
Thomas Markwalder
1b72b3e36e [master] Corrected unit test build failure under Solaris 11
Reverted change to configure.ac that broke the test for sys/filio.h.
This include is needed for unit tests in dhcp_ddns.
2014-04-25 13:44:55 -04:00
Marcin Siodelski
17db85fee8 [3409] Fix line number logging in DHCPv4 as a result of manual testing. 2014-04-25 19:18:20 +02:00
Thomas Markwalder
50cd64975e [master] Fix for 3387, asiodns::IOFetch unit test failing
The unit test, IOFetchTest.TcpSendReceive65535, was failing
routinely on a NetBSD VM.  The VM was running so slowly that
this test was timing out.  Typically it takes less than
500ms. On this VM it was taking over 4.5s and then hitting
a safety valve timeout.  That timeout value was increased.
2014-04-25 11:15:39 -04:00
Marcin Siodelski
21eee97b58 [3409] Pass whole context to the OptionDefListParser. 2014-04-25 14:16:43 +02:00
Marcin Siodelski
6db4435309 [3409] Fixed culprit line logging for non-existing parameters. 2014-04-25 14:06:04 +02:00
Marcin Siodelski
265ab8e405 [3409] Log position of the elements in DHCPv6 config parser. 2014-04-25 11:56:46 +02:00
Thomas Markwalder
60d2db6f93 [master] Merge branch 'trac3121'
Internal refactor, moved error logic from commit() to build() for
D2 parsers
2014-04-24 14:06:19 -04:00
Marcin Siodelski
5763b603f2 [3409] Use reset function to set the pointer to the Subnet config parser 2014-04-24 19:55:55 +02:00
Thomas Markwalder
cb53179363 [master] Added ChangeLog entry 782 for Trac #3328. 2014-04-24 13:09:24 -04:00
Marcin Siodelski
7137b4a408 [3409] The DHCPv4 config parser logs positions of the elements in config. 2014-04-24 19:02:19 +02:00
Thomas Markwalder
8d8d0b5eed [master] Merge branch 'trac3328'
Adds sender_ip,sender_port,max_queue_size to D2 client config
2014-04-24 12:45:46 -04:00
Marcin Siodelski
fab3d4c3a5 [3328] Fixed some typos in the bind10-guide. 2014-04-24 18:27:08 +02:00
Thomas Markwalder
830b726a15 [3328] Addressed review comments
Fixed typos and replaced used of DHCPv<n> with b10-dhcp<n> in
D2 relevant sections of the admin guide.
Added sender_ip and max_queue_size value to dhcp4 and dhcp6 unit
tests.
Added used of DFT constants in D2ClientCfg default constructor.
2014-04-24 11:46:11 -04:00
Thomas Markwalder
ac5e4786cc [3121] Addressed review comments
Added suggested code commentary.
2014-04-24 10:04:02 -04:00
Marcin Siodelski
71ceaa0198 [3409] Append position into error messages logged from dhcp_parsers.cc 2014-04-24 10:54:42 +02:00
Marcin Siodelski
e9ab3dbcee [3409] Store position of the data element in the value storage. 2014-04-23 20:51:46 +02:00
Marcin Siodelski
5306438ec3 [master] Added Changelog entry for #3148. trac2406km_base 2014-04-23 19:44:32 +02:00
Marcin Siodelski
d2f0edf473 [master] Merge branch 'trac3148' 2014-04-23 10:57:52 +02:00
Marcin Siodelski
43fc427118 [3148] Implemented getLeases6 methods which take lease type into account. 2014-04-23 10:53:12 +02:00
Marcin Siodelski
8df5e8bd55 [3148] Fixed obvious bugs in Dhcpv6Srv unit tests. 2014-04-23 10:38:00 +02:00
Marcin Siodelski
bfe07f025a [3409] Updated Element data structure to hold the file name. 2014-04-22 16:40:29 +02:00
Thomas Markwalder
94f8425e49 [3328] Updated kea admin guide with new dhcp-ddns config values 2014-04-21 12:03:38 -04:00
Thomas Markwalder
dff934657f [3328] Change Dhcp6 spec file so D2 server IP address matches Dhcp4
Out of the box both DHCP servers should look at the same defualt address
for D2, as D2 only opens one ip/port (currently).
2014-04-21 10:26:16 -04:00
Marcin Siodelski
2dbdfeb0e6 [master] Added Changelog entry for #3408. trac2406_cl_base 2014-04-18 18:53:53 +02:00
Marcin Siodelski
115a52a671 [master] Merge branch 'trac3408' 2014-04-18 18:15:33 +02:00
Marcin Siodelski
c180526d99 [3408] Addressed review comments. 2014-04-18 18:11:48 +02:00
Tomek Mrugalski
51720f5054 [3408] Compilation fix. 2014-04-18 14:45:09 +02:00
Marcin Siodelski
215020f12f [3121] Corrected some little typos. 2014-04-18 12:27:36 +02:00
Marcin Siodelski
3325dc6a12 [3408] Additional doxygen fixes in data.h 2014-04-18 11:22:45 +02:00
Marcin Siodelski
6725cdd4ec [3408] Added a few comments in the data.cc concerning element position. 2014-04-18 11:04:50 +02:00