JINMEI Tatuya
83f878b651
[2207] minor style cleanup: constify
2012-10-17 13:07:40 -07:00
Marcin Siodelski
9bb3d27efd
[2316] Changes according to code review.
2012-10-17 21:31:06 +02:00
JINMEI Tatuya
100929f3fa
[2207] editorial: folded a long line
2012-10-17 11:44:35 -07:00
JINMEI Tatuya
7265ccb300
[2207] editorial: folded long lines
2012-10-17 11:38:54 -07:00
JINMEI Tatuya
399e4f0030
[2207] one more fix of s/reloader/writer/
2012-10-17 11:38:35 -07:00
JINMEI Tatuya
f0f7efe331
[2207] editorial: some more s/reloader/write/ changes in doc.
2012-10-17 10:49:19 -07:00
JINMEI Tatuya
650655fd26
[2332] renamed thread/lock.h to thread/sync.h as it's not only for locks now
2012-10-17 09:05:37 -07:00
JINMEI Tatuya
c450d77e81
[2332] changed one exception to assert() based on review discussion
2012-10-17 08:59:58 -07:00
Jelte Jansen
39faa67b7a
[master] Merge branch 'trac2223'
2012-10-17 15:19:43 +02:00
Michal 'vorner' Vaner
16041df526
[2207] Style: correct capitalization
2012-10-17 13:11:05 +02:00
Michal 'vorner' Vaner
6430d56ffc
[2207] Test it cleans up automatically
2012-10-17 13:10:08 +02:00
Michal 'vorner' Vaner
ccfb2bf2c5
[2207] Throw better exception
2012-10-17 12:59:23 +02:00
Michal 'vorner' Vaner
4601f7ef87
[2207] The parameter of local writer is Local as well
...
But the benefit of this change is questionable.
2012-10-17 12:49:49 +02:00
Michal 'vorner' Vaner
84e0dc1be1
[2207] Provide strong exception guarantee
2012-10-17 12:43:55 +02:00
Michal 'vorner' Vaner
2530e97e66
[2207] Update docs of ZoneWriterLocal
...
They were outdated, for previous version of the interface.
2012-10-17 12:23:33 +02:00
Michal 'vorner' Vaner
5b77cd205f
[2207] Split off the local Writer
...
Into a separate file. It is not needed to be too public.
2012-10-17 12:15:05 +02:00
Michal 'vorner' Vaner
1ae2321d71
[2207] Better documentation for LoadAction
2012-10-17 11:58:51 +02:00
Michal 'vorner' Vaner
03b8bddd30
[2207] Style: Lines between comments and definitions
2012-10-17 11:17:20 +02:00
Michal 'vorner' Vaner
0d336b6f23
[2207] Rename ZoneUpdater -> ZoneWriter
...
According to the review, Updater might be misleading.
2012-10-17 11:14:30 +02:00
JINMEI Tatuya
4b2997b783
[2205] create DataSrcClientsMgr in auth's main() just to confirm it starts/ends
...
it currently does nothing user-visible.
2012-10-16 19:51:25 -07:00
JINMEI Tatuya
c857ced998
[2205] make AUTH_DATASRC_CLIENTS_BUILDER_COMMAND more readable using text.
...
also explicitly reject invalid command ID, which should be internal bug.
2012-10-16 17:30:18 -07:00
JINMEI Tatuya
e7bcdb44ef
[2205] overall documentation updates
2012-10-16 17:12:46 -07:00
JINMEI Tatuya
e21b1a26b3
[2205] cleanups: use more specific internal namespaces and reorder code
...
mainly for better readability. no functional change.
2012-10-16 15:45:01 -07:00
JINMEI Tatuya
07e1f1ddbd
[2207] fixed a minor typo in doc
2012-10-16 14:15:49 -07:00
Mukund Sivaraman
2252c5776f
Revert "Merge branch 'master' into trac2198_2"
...
This reverts commit f8181bb72251fd3d5f33e157d1f2a2a75a58d765, reversing
changes made to 453b58784344390cbc5375624e6e92a86b4ff3f1.
2012-10-17 01:01:14 +05:30
Mukund Sivaraman
f559b99dcc
Revert "[master] Link -lpthread in libb10-threads target"
...
This reverts commit 8d321e3ea9f85227296cfac94a9ce79c7db70fdf.
2012-10-17 00:59:03 +05:30
Mukund Sivaraman
c91151db16
Revert "[master] Check for EDEADLK too when using Mutex::tryLock()"
...
This reverts commit 42c638e07a45b69d902a51b35838ae21ac19d116.
2012-10-17 00:58:45 +05:30
Mukund Sivaraman
7ffd1e0cad
Revert "[master] Avoid static destruction fiasco with InterprocessSyncFile and logger"
...
This reverts commit 34701adba7f7390640c70ba769cdb0b20f01f82c.
2012-10-17 00:58:31 +05:30
Mukund Sivaraman
34701adba7
[master] Avoid static destruction fiasco with InterprocessSyncFile and logger
2012-10-17 00:29:13 +05:30
JINMEI Tatuya
26313fafb0
[2223] editorial: a missing period in comment
2012-10-16 10:41:42 -07:00
Mukund Sivaraman
42c638e07a
[master] Check for EDEADLK too when using Mutex::tryLock()
2012-10-16 23:02:38 +05:30
Marcin Siodelski
82c0737d3d
[2316] Added option collection to the Subnet class.
2012-10-16 17:09:47 +02:00
Jelte Jansen
5735b337b8
[2349] document member in test class
2012-10-16 16:09:24 +02:00
Jelte Jansen
b57f65e686
[2349] Revert pimpl classes, make abstract base class
...
saves a second dynamic allocation (and more importantly, one that couldn't be freed)
2012-10-16 15:54:11 +02:00
Jelte Jansen
579b92381b
[2223] some minor cleanups in final review
2012-10-16 14:43:42 +02:00
JINMEI Tatuya
93c198a7b9
[2205] make sure wating for builder thread in the mgr destructor.
...
on second thought I realized we need to synchronize them because the builder
thread refers to the main thread's class member variables.
shutdown() method is now meaningless so deprecated for now.
2012-10-15 23:00:28 -07:00
Mukund Sivaraman
8d321e3ea9
[master] Link -lpthread in libb10-threads target
2012-10-16 10:34:31 +05:30
JINMEI Tatuya
5bf4005eb7
[2205] cover the case where Thread.wait() throws.
2012-10-15 20:46:30 -07:00
Mukund Sivaraman
83d00dc305
Merge branch 'master' into trac2268
2012-10-16 06:35:50 +05:30
JINMEI Tatuya
15724e5de1
[2205] catch exceptions inside builder and log it.
2012-10-15 17:35:07 -07:00
Mukund Sivaraman
f8181bb722
Merge branch 'master' into trac2198_2
2012-10-16 06:01:22 +05:30
Mukund Sivaraman
6adfc24434
[2198] Don't return anything from thread functions
2012-10-16 06:00:19 +05:30
JINMEI Tatuya
16d31a6793
[2205] handle the case where manager is destroyed without shutdown()
2012-10-15 16:31:18 -07:00
JINMEI Tatuya
f05b0be9d2
[2205] small refactoring: extracting send-command part to a thread
...
we'll use this pattern for other commands.
2012-10-15 16:10:12 -07:00
JINMEI Tatuya
ae89f6e491
[2205] added a test case using a real thread
2012-10-15 16:04:46 -07:00
JINMEI Tatuya
b4ec1b3e23
[2205] (unrelated small fix) don't define constants in .h. see also #2358 .
2012-10-15 15:52:48 -07:00
JINMEI Tatuya
d2009fd950
[2205] supported manager's shutdown command
2012-10-15 15:06:21 -07:00
JINMEI Tatuya
0c6ad26d37
[2205] introduce DataSrcClientsMgr, tested initial startup.
2012-10-15 14:30:11 -07:00
JINMEI Tatuya
8c02f8a83f
[2332] added comments about missing pthread_cond_xxx variants
2012-10-15 13:45:53 -07:00
JINMEI Tatuya
a439004524
[2332] fixing typos and wording in doc
2012-10-15 13:42:24 -07:00
