JINMEI Tatuya
410987bf3c
[2332] updated doc for wait() on what should happen if mutex isn't locked.
...
mentioning pthread_cond_wait() seems to be confusing, so I'd rather
just describing what this method does.
2012-10-15 13:39:32 -07:00
JINMEI Tatuya
7f94f671e0
[2332] Make sure preUnlockAction() doesn't throw when it shouldn't.
...
adding a parameter to control that.
2012-10-15 13:31:04 -07:00
JINMEI Tatuya
453b587843
[master] added changelog for #1858
2012-10-15 13:16:24 -07:00
JINMEI Tatuya
405d85c8a0
[master] Merge branch 'trac1858'
...
commit.
2012-10-15 13:13:45 -07:00
JINMEI Tatuya
671005eea2
[2332] changed the type of Locker::mutex_ to a reference.
...
may not be a big deal in such a simple case, but just as suggested in review.
2012-10-15 11:21:47 -07:00
JINMEI Tatuya
b6d2a03ff5
[2332] renamed a too-short test name a possibly better one
2012-10-15 11:17:21 -07:00
JINMEI Tatuya
d504c06cbe
[2332] use EXPECT_DEATH_IF_SUPPORTED instead of ifdef.
...
avoiding ifdef is generally better, and _IF_SUPPORTED seems to have been
supported since googletest 1.4 and should be commonly available for us.
2012-10-15 11:14:56 -07:00
JINMEI Tatuya
50500e62ac
[2223] style fix: brace position
2012-10-15 10:16:51 -07:00
JINMEI Tatuya
66524e1594
[2268] use textToRRset instead of building RRset manually
...
this will make the test code a bit more concise.
2012-10-15 09:50:00 -07:00
Jelte Jansen
6920774dd6
[2349] forgot to remove a line from makefile as well
2012-10-15 17:22:05 +02:00
Jelte Jansen
3a73fff8f4
[2349] forgot to remove a line from configure.ac
2012-10-15 16:09:50 +02:00
Tomek Mrugalski
9565a7939e
[master] Using the default value of second parameter for substr
2012-10-15 15:55:19 +02:00
Jelte Jansen
9c2e94bb8a
[2349] Documentation for the pimpling of two classes
2012-10-15 15:49:39 +02:00
Jelte Jansen
efded5c371
[2223] completely pull out sigs and check entire set
2012-10-15 14:57:05 +02:00
Michal 'vorner' Vaner
d5569a62a3
[2207] Implementation of the getZoneReloader
...
The concrete version for local table segment and reloader.
2012-10-15 12:14:04 +02:00
Michal 'vorner' Vaner
b06d8d764e
[2207] Docs and capitalization fix
2012-10-15 12:13:49 +02:00
Michal 'vorner' Vaner
51580fd1a4
[2207] Tests for the getZoneReloader
2012-10-15 12:13:06 +02:00
Michal 'vorner' Vaner
c55218e6be
[2207] interface of the getZoneReloader
2012-10-15 11:28:35 +02:00
Mukund Sivaraman
5b781744ac
[2198] Update comment
2012-10-15 10:01:18 +05:30
Mukund Sivaraman
4ed683ce42
[2198] Test the non-blocking variant of Mutex::Locker
2012-10-15 09:59:22 +05:30
Mukund Sivaraman
e6ac5ef47d
[2198] Check pthread_mutex_trylock()'s return value
2012-10-15 09:38:39 +05:30
Mukund Sivaraman
48e80a5c75
[2198] Revert include to local
2012-10-15 00:03:13 +05:30
Mukund Sivaraman
fff8929b13
[2198] Stop using direct lock methods on Mutex inside InterprocessSyncFile
2012-10-14 22:22:35 +05:30
Mukund Sivaraman
ecef170dd0
[2198] Make direct methods on Mutex private
2012-10-14 22:19:47 +05:30
Mukund Sivaraman
350c775f7b
[2198] Add a block argument to Mutex::Locker constructor
2012-10-14 22:17:29 +05:30
Mukund Sivaraman
666bfa9c7b
[2198] Add AlreadyLocked exception to Mutex::Locker
2012-10-14 22:16:41 +05:30
Mukund Sivaraman
932edbb0ec
Merge branch 'master' into trac2302
2012-10-14 20:13:42 +05:30
Mukund Sivaraman
0e2c14089b
[2268] Make minor code cleanup
2012-10-14 20:00:06 +05:30
Mukund Sivaraman
45f0d1f2e7
[2168] Untabify
2012-10-14 19:57:32 +05:30
Mukund Sivaraman
31d092681c
[2268] Remove per-test iterator classes and use MockVectorIterator instead
2012-10-14 19:57:06 +05:30
Mukund Sivaraman
3744e7a858
[2268] Add MockVectorIterator class
2012-10-14 19:56:10 +05:30
Michal 'vorner' Vaner
c0e090f453
[2207] Deprecate InstallAction
...
As we want to directly modify the ZoneTable in ZoneReloaderLocal
(because it is memory-type dependant), we don't need the InstallAction
for anything. If we don't need it, we don't pass it as constructor
parameter -- it'll be called from a factory anyway and the factory may
know we don't need it.
Also adding a setTable() method to ZoneTableHeader. The header had no
way to specify the table currently and we need it for the tests. The
method is currently tentative, we'll probably replace it by something.
2012-10-13 13:03:26 +02:00
Michal 'vorner' Vaner
70aa7bfa24
[2207] Check the load action returns something
...
NULL makes no sense, so throw in that case.
2012-10-13 11:48:18 +02:00
Michal 'vorner' Vaner
419020c407
[2207] Change signature of LoadAction
...
We allocate the ZoneData in the LoadAction, to match what happens in
ticket #2268 -- there's a function to load zone which allocates it
itself, we want to use it.
2012-10-13 11:38:58 +02:00
Michal 'vorner' Vaner
58c41ea9cd
[2207] Rename updater to reloader
...
This might be less confusing.
2012-10-13 11:21:44 +02:00
JINMEI Tatuya
26ea6b0e30
[2205] added DataSrcClientsBuilder class, main part of configurator thread
2012-10-12 19:44:18 -07:00
JINMEI Tatuya
4629279de0
[2205] Merge branch 'trac2332' into trac2205
2012-10-12 14:32:53 -07:00
JINMEI Tatuya
d3983e1e68
[2332] missing cleanup: removed an unused function.
2012-10-12 14:32:22 -07:00
JINMEI Tatuya
0bacd45815
[2205] Merge branch 'trac2332' into trac2205
2012-10-12 14:30:21 -07:00
JINMEI Tatuya
ae0565a4ed
[1858] (unrelated cleanup) removed BIND10_START_AS_NON_ROOT_AUTH log.
...
with the introduction of socket creation this log message hasn't been
making sense. It would be rather confusing and harmful.
2012-10-12 13:48:46 -07:00
JINMEI Tatuya
e93e6f3873
[2268] minor editorial cleanups
2012-10-12 11:49:07 -07:00
Jelte Jansen
95a47e7f0a
[2349] Same for RunningQuery
...
See 26483ea27726d4c1097485196a0908c565478188
2012-10-12 17:04:15 +02:00
Jelte Jansen
26483ea277
[2349] clean up ForwardQuery objects in tests
...
an attempt to clean up memory; ForwardQuery objects are supposed to delete themselves when they are no longer needed, but due to the direct calls in tests this often does not happen.
To keep internals in recursive_query to a minimum, I did add something to the API; ForwardQuery is now a public class, a pointer of which is returned by RecursiveQuery::forward. Tests that mess around can then delete the query themselves, and the way these are handled does not have to be changed.
Ideally, we should however not need unscoped allocated memory in the first place; we either need to use a centrally managed pool of objects to (re)use, or we need to change the entire design that needs these objects in the first place.
However, these are both non-trivial, and probably better suited in the main resolver work that has been planned.
2012-10-12 14:19:19 +02:00
Marcin Siodelski
9062cbabae
[2304] Minor additions in comments.
2012-10-12 09:28:40 +02:00
Marcin Siodelski
f3414d4ba6
[2304] Fixes for the code review.
...
Includes adding missing tests for signed integer values
2012-10-12 09:02:33 +02:00
Mukund Sivaraman
0e1a1b2ee0
[2268] Remove obsolete comment (the bug was fixed)
2012-10-12 10:30:31 +05:30
Mukund Sivaraman
e2b120a2e0
[2268] Move FileNameDeleter out of InMemoryClient
2012-10-12 10:10:11 +05:30
Mukund Sivaraman
1e6d2102d1
[2268] Update API doc
2012-10-12 10:07:13 +05:30
Mukund Sivaraman
8b59a7d661
[2268] Move ZoneDataLoader into an unnamed namespace
2012-10-12 10:07:04 +05:30
Mukund Sivaraman
f176512171
[2268] Move ZoneDataLoader class out of its header
2012-10-12 09:55:33 +05:30
