Simplify hasModifications check

Change-Id: Idcbd9a20ab13d0717f8728673e2c55e87aa92be4

configmgr/source/components.cxx

@@ -277,18 +277,11 @@ void Components::addModification(Path const & path) {
     data_.modifications.add(path);
 }
 
-bool Components::hasModifications() const
-{
-    return data_.modifications.getRoot().children.begin() !=
-        data_.modifications.getRoot().children.end();
-}
-
 void Components::writeModifications() {
 
-    if (!hasModifications() || modificationFileUrl_.isEmpty())
-        return;
-
-    if (!writeThread_.is()) {
+    if (!(data_.modifications.empty() || modificationFileUrl_.isEmpty()
+          || writeThread_.is()))
+    {
         writeThread_ = new WriteThread(
             &writeThread_, *this, modificationFileUrl_, data_);
         writeThread_->launch();

configmgr/source/components.hxx

@@ -78,8 +78,6 @@ public:
 
     void writeModifications();
 
-    bool hasModifications() const;
-
     void flushModifications();
         // must be called with configmgr::lock unaquired; must be called before
         // shutdown if writeModifications has ever been called (probably

configmgr/source/modifications.hxx

@@ -45,6 +45,8 @@ public:
 
     void remove(Path const & path);
 
+    bool empty() const { return root_.children.empty(); }
+
     Node const & getRoot() const { return root_;}
 
 private: