mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:constvars in accessibility..basegfx

Browse Source 
Change-Id: Id6a0b48c3440be394419e87bd7a4f63bd0a1e758
Reviewed-on: https://gerrit.libreoffice.org/77721
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-08-19 15:09:56 +02:00
parent c31fa068ad
commit 16da5e2cc9
14 changed files with 27 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
accessibility/source/extended/accessibletabbar.cxx
View File

@@ -173,7 +173,7 @@ namespace accessibility
AccessibleTabBarBase::disposing();
// dispose all children
for (Reference<XAccessible>& i : m_aAccessibleChildren)
for (const Reference<XAccessible>& i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i, UNO_QUERY );
if ( xComponent.is() )

4
accessibility/source/extended/accessibletabbarpagelist.cxx
View File

@@ -58,7 +58,7 @@ namespace accessibility
void AccessibleTabBarPageList::UpdateShowing( bool bShowing )
{
for (Reference<XAccessible>& xChild : m_aAccessibleChildren)
for (const Reference<XAccessible>& xChild : m_aAccessibleChildren)
{
if ( xChild.is() )
{
@@ -346,7 +346,7 @@ namespace accessibility
AccessibleTabBarBase::disposing();
// dispose all children
for (Reference<XAccessible>& i : m_aAccessibleChildren)
for (const Reference<XAccessible>& i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i, UNO_QUERY );
if ( xComponent.is() )

8
accessibility/source/standard/accessiblemenubasecomponent.cxx
View File

@@ -227,7 +227,7 @@ void OAccessibleMenuBaseComponent::UpdateFocused( sal_Int32 i, bool bFocused )
void OAccessibleMenuBaseComponent::UpdateVisible()
{
SetVisible( IsVisible() );
for (Reference<XAccessible>& xChild : m_aAccessibleChildren)
for (const Reference<XAccessible>& xChild : m_aAccessibleChildren)
{
if ( xChild.is() )
{
@@ -456,7 +456,7 @@ bool OAccessibleMenuBaseComponent::IsChildHighlighted()
{
bool bChildHighlighted = false;
for (Reference<XAccessible>& xChild : m_aAccessibleChildren)
for (const Reference<XAccessible>& xChild : m_aAccessibleChildren)
{
if ( xChild.is() )
{
@@ -606,7 +606,7 @@ void OAccessibleMenuBaseComponent::ProcessMenuEvent( const VclMenuEvent& rVclMen
m_pMenu = nullptr;
// dispose all menu items
for (Reference<XAccessible>& i : m_aAccessibleChildren)
for (const Reference<XAccessible>& i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i, UNO_QUERY );
if ( xComponent.is() )
@@ -650,7 +650,7 @@ void OAccessibleMenuBaseComponent::disposing()
m_pMenu = nullptr;
// dispose all menu items
for (Reference<XAccessible>& i : m_aAccessibleChildren)
for (const Reference<XAccessible>& i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i, UNO_QUERY );
if ( xComponent.is() )

4
accessibility/source/standard/vclxaccessiblelist.cxx
View File

@@ -205,7 +205,7 @@ void VCLXAccessibleList::UpdateSelection_Impl_Acc(bool bHasDropDownList)
{
sal_Int32 i=0;
m_nCurSelectedPos = LISTBOX_ENTRY_NOTFOUND;
for ( auto& rChild : m_aAccessibleChildren )
for ( const auto& rChild : m_aAccessibleChildren )
{
Reference< XAccessible > xHold = rChild;
if ( xHold.is() )
@@ -670,7 +670,7 @@ void VCLXAccessibleList::UpdateSelection_Impl(sal_Int32)
{
sal_Int32 i=0;
m_nCurSelectedPos = LISTBOX_ENTRY_NOTFOUND;
for ( auto& rChild : m_aAccessibleChildren )
for ( const auto& rChild : m_aAccessibleChildren )
{
Reference< XAccessible > xHold = rChild;
if ( xHold.is() )

4
accessibility/source/standard/vclxaccessiblestatusbar.cxx
View File

@@ -220,7 +220,7 @@ void VCLXAccessibleStatusBar::ProcessWindowEvent( const VclWindowEvent& rVclWind
m_pStatusBar = nullptr;
// dispose all children
for (Reference<XAccessible>& i : m_aAccessibleChildren)
for (const Reference<XAccessible>& i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i, UNO_QUERY );
if ( xComponent.is() )
@@ -250,7 +250,7 @@ void VCLXAccessibleStatusBar::disposing()
m_pStatusBar = nullptr;
// dispose all children
for (Reference<XAccessible>& i : m_aAccessibleChildren)
for (const Reference<XAccessible>& i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i, UNO_QUERY );
if ( xComponent.is() )

6
accessibility/source/standard/vclxaccessibletabcontrol.cxx
View File

@@ -57,7 +57,7 @@ VCLXAccessibleTabControl::VCLXAccessibleTabControl( VCLXWindow* pVCLXWindow )
void VCLXAccessibleTabControl::UpdateFocused()
{
for (Reference<XAccessible>& xChild : m_aAccessibleChildren)
for (const Reference<XAccessible>& xChild : m_aAccessibleChildren)
{
if ( xChild.is() )
{
@@ -234,7 +234,7 @@ void VCLXAccessibleTabControl::ProcessWindowEvent( const VclWindowEvent& rVclWin
m_pTabControl = nullptr;
// dispose all tab pages
for (Reference<XAccessible>& i : m_aAccessibleChildren)
for (const Reference<XAccessible>& i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i, UNO_QUERY );
if ( xComponent.is() )
@@ -314,7 +314,7 @@ void VCLXAccessibleTabControl::disposing()
m_pTabControl = nullptr;
// dispose all tab pages
for (Reference<XAccessible>& i : m_aAccessibleChildren)
for (const Reference<XAccessible>& i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i, UNO_QUERY );
if ( xComponent.is() )

10
basctl/source/accessibility/accessibledialogwindow.cxx
View File

@@ -118,7 +118,7 @@ AccessibleDialogWindow::~AccessibleDialogWindow()
void AccessibleDialogWindow::UpdateFocused()
{
for (ChildDescriptor & i : m_aAccessibleChildren)
for (const ChildDescriptor & i : m_aAccessibleChildren)
{
Reference< XAccessible > xChild( i.rxAccessible );
if ( xChild.is() )
@@ -135,7 +135,7 @@ void AccessibleDialogWindow::UpdateSelected()
{
NotifyAccessibleEvent( AccessibleEventId::SELECTION_CHANGED, Any(), Any() );
for (ChildDescriptor & i : m_aAccessibleChildren)
for (const ChildDescriptor & i : m_aAccessibleChildren)
{
Reference< XAccessible > xChild( i.rxAccessible );
if ( xChild.is() )
@@ -150,7 +150,7 @@ void AccessibleDialogWindow::UpdateSelected()
void AccessibleDialogWindow::UpdateBounds()
{
for (ChildDescriptor & i : m_aAccessibleChildren)
for (const ChildDescriptor & i : m_aAccessibleChildren)
{
Reference< XAccessible > xChild( i.rxAccessible );
if ( xChild.is() )
@@ -378,7 +378,7 @@ void AccessibleDialogWindow::ProcessWindowEvent( const VclWindowEvent& rVclWindo
m_pDlgEdModel = nullptr;
// dispose all children
for (ChildDescriptor & i : m_aAccessibleChildren)
for (const ChildDescriptor & i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i.rxAccessible, UNO_QUERY );
if ( xComponent.is() )
@@ -523,7 +523,7 @@ void AccessibleDialogWindow::disposing()
m_pDlgEdModel = nullptr;
// dispose all children
for (ChildDescriptor & i : m_aAccessibleChildren)
for (const ChildDescriptor & i : m_aAccessibleChildren)
{
Reference< XComponent > xComponent( i.rxAccessible, UNO_QUERY );
if ( xComponent.is() )

4
basctl/source/basicide/bastype3.cxx
View File

@@ -295,7 +295,7 @@ SbxVariable* SbTreeListBox::FindVariable(const weld::TreeIter* pEntry)
{
std::reverse(aEntries.begin(), aEntries.end());
bool bDocumentObjects = false;
for (auto& pair : aEntries)
for (const auto& pair : aEntries)
{
Entry* pBE = pair.first;
assert(pBE && "No data found in entry!");
@@ -497,7 +497,7 @@ EntryDescriptor SbTreeListBox::GetEntryDescriptor(const weld::TreeIter* pEntry)
if ( !aEntries.empty() )
{
std::reverse(aEntries.begin(), aEntries.end());
for (auto& pair : aEntries)
for (const auto& pair : aEntries)
{
Entry* pBE = pair.first;
assert(pBE && "No data found in entry!");

2
basctl/source/basicide/breakpoint.cxx
View File

@@ -67,7 +67,7 @@ void BreakPointList::SetBreakPointsInBasic(SbModule* pModule)
{
pModule->ClearAllBP();
for (BreakPoint& rBrk : maBreakPoints)
for (const BreakPoint& rBrk : maBreakPoints)
{
if ( rBrk.bEnabled )
pModule->SetBP( rBrk.nLine );

2
basegfx/source/polygon/b2dpolygonclipper.cxx
View File

@@ -796,7 +796,7 @@ namespace basegfx
else
{
// the last triangle has not been altered, simply copy to result
for(basegfx::B2DPoint & i : stack)
for(const basegfx::B2DPoint & i : stack)
aResult.append(i);
}
}

2
basegfx/source/polygon/b2dpolygoncutandtouch.cxx
View File

@@ -411,7 +411,7 @@ namespace basegfx
}
// append remapped tempVector entries for edge to tempPoints for edge
for(temporaryPoint & rTempPoint : aTempPointVectorEdge)
for(const temporaryPoint & rTempPoint : aTempPointVectorEdge)
{
rTempPointsB.emplace_back(rTempPoint.getPoint(), nIndB, rTempPoint.getCut());
}

2
basegfx/source/polygon/b2dpolypolygoncutter.cxx
View File

@@ -1037,7 +1037,7 @@ namespace basegfx
B2DPolyPolygonVector aResult;
aResult.reserve(aInput.size());
for(basegfx::B2DPolyPolygon & a : aInput)
for(const basegfx::B2DPolyPolygon & a : aInput)
{
const basegfx::B2DPolyPolygon aCandidate(prepareForPolygonOperation(a));

2
basegfx/source/polygon/b2dtrapezoid.cxx
View File

@@ -424,7 +424,7 @@ namespace basegfx
// there were horizontal edges. These can be excluded, but
// cuts with other edges need to be solved and added before
// ignoring them
for(TrDeSimpleEdge & rHorEdge : rTrDeSimpleEdges)
for(const TrDeSimpleEdge & rHorEdge : rTrDeSimpleEdges)
{
// get horizontal edge as candidate; prepare its range and fixed Y
const B1DRange aRange(rHorEdge.getStart().getX(), rHorEdge.getEnd().getX());

2
basegfx/source/tools/systemdependentdata.cxx
View File

@@ -137,7 +137,7 @@ namespace basegfx
SystemDependentDataHolder::~SystemDependentDataHolder()
{
for(auto& candidate : maSystemDependentReferences)
for(const auto& candidate : maSystemDependentReferences)
{
basegfx::SystemDependentData_SharedPtr aData(candidate.second.lock());