Remove HAVE_GCC_VISIBILITY_BROKEN, never true

The check for broken -fvisiblity-inlines-hidden doesn't mention a specific bug.
Its roots date back to 072e89cf68 "INTEGRATION:
CWS newportstl" of the --with(out)-stlport area.  Lets assume whatever failure
is long since fixed.

Make this a fatal configure error for now.  The check should be removed
completely after LO 5.3 branch-off.

Change-Id: I7c64c2e8b9bd342beec9b84ff71f5712a6155b7d
Reviewed-on: https://gerrit.libreoffice.org/29075
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

config_host.mk.in

@@ -250,7 +250,6 @@ export HAVE_GCC_FNO_INLINE=@HAVE_GCC_FNO_INLINE@
 export HAVE_GCC_FNO_SIZED_DEALLOCATION=@HAVE_GCC_FNO_SIZED_DEALLOCATION@
 export HAVE_GCC_GGDB2=@HAVE_GCC_GGDB2@
 export HAVE_GCC_PRAGMA_OPERATOR=@HAVE_GCC_PRAGMA_OPERATOR@
-export HAVE_GCC_VISIBILITY_BROKEN=@HAVE_GCC_VISIBILITY_BROKEN@
 export HAVE_GNUMAKE_FILE_FUNC=@HAVE_GNUMAKE_FILE_FUNC@
 export HAVE_LD_BSYMBOLIC_FUNCTIONS=@HAVE_LD_BSYMBOLIC_FUNCTIONS@
 export HAVE_LD_HASH_STYLE=@HAVE_LD_HASH_STYLE@

configure.ac

@@ -6476,7 +6476,6 @@ AC_SUBST([HAVE_GCC_FNO_SIZED_DEALLOCATION])
 dnl ===================================================================
 dnl system stl sanity tests
 dnl ===================================================================
-HAVE_GCC_VISIBILITY_BROKEN=
 if test \( "$_os" != "WINNT" -o "$WITH_MINGW" = "yes" \); then
 
     AC_LANG_PUSH([C++])
@@ -6518,16 +6517,14 @@ istringstream strm( "test" ); return 0;
     ])
     AC_MSG_RESULT([$gccvisok])
     if test "$gccvisok" = "no"; then
-        AC_MSG_WARN([Your gcc is not -fvisibility-inlines-hidden safe, disabling that.])
-        add_warning "Your gcc is not -fvisibility-inlines-hidden safe, disabling that."
-        HAVE_GCC_VISIBILITY_BROKEN="TRUE"
+        AC_MSG_ERROR([Your gcc is not -fvisibility-inlines-hidden safe. This is no longer supported.])
     fi
 
     LDFLAGS=$sharedlink_ldflags_save
 
     # As the below test checks things when linking self-compiled dynamic libraries, it presumably is irrelevant
     # when we don't make any dynamic libraries?
-    if test "$DISABLE_DYNLOADING" = "" -a "$HAVE_GCC_VISIBILITY_BROKEN" != "TRUE"; then
+    if test "$DISABLE_DYNLOADING" = ""; then
         AC_MSG_CHECKING([if gcc is -fvisibility-inlines-hidden safe (Clang bug 11250)])
         cat > conftestlib1.cc <<_ACEOF
 template<typename T> struct S1 { virtual ~S1() {} virtual void f() {} };
@@ -6611,8 +6608,6 @@ _ACEOF
     AC_LANG_POP([C++])
 fi
 
-AC_SUBST(HAVE_GCC_VISIBILITY_BROKEN)
-
 dnl ===================================================================
 dnl  Clang++ tests
 dnl ===================================================================

solenv/gbuild/platform/com_GCC_defs.mk

@@ -110,9 +110,7 @@ gb_VISIBILITY_FLAGS := -fvisibility-ms-compat
 endif
 endif
 endif
-ifneq ($(HAVE_GCC_VISIBILITY_BROKEN),TRUE)
 gb_VISIBILITY_FLAGS_CXX := -fvisibility-inlines-hidden
-endif
 gb_CXXFLAGS_COMMON += $(gb_VISIBILITY_FLAGS_CXX)
 
 ifeq ($(HAVE_GCC_STACK_PROTECTOR_STRONG),TRUE)